diff --git a/pkg/rtc/participant_sdp.go b/pkg/rtc/participant_sdp.go index 731f328b3..ca8c82c5e 100644 --- a/pkg/rtc/participant_sdp.go +++ b/pkg/rtc/participant_sdp.go @@ -538,10 +538,6 @@ func (p *ParticipantImpl) setCodecPreferencesForPublisherMedia( unmatch.MediaName.Formats = append(unmatch.MediaName.Formats, leftCodecs...) } - - // SINGLE-PEER-CONNECTION-TODO: can set mid in TrackInfo before sending offer and check on receiving answer to set SdpCid - // SINGLE-PEER-CONNECTION-TODO: this has to be do publish enabled codecs filtering also, cannot do it with setting registered codecs on peer connection as subscriber codecs could be different from publisher codecs - // SINGLE-PEER-CONNECTION-TODO: probably have to do RTP Header Extensions and RTCP feedback filtering also here } return parsedOffer, unprocessed diff --git a/pkg/rtc/transport.go b/pkg/rtc/transport.go index d8fa9c0b7..dfad9d53a 100644 --- a/pkg/rtc/transport.go +++ b/pkg/rtc/transport.go @@ -266,14 +266,12 @@ type PCTransport struct { } type TransportParams struct { - Handler transport.Handler - ProtocolVersion types.ProtocolVersion - Config *WebRTCConfig - Twcc *lktwcc.Responder - // SINGLE-PEER-CONNECTION-TODO: guess this has to be superset of published and subscribed direction configs - DirectionConfig DirectionConfig - CongestionControlConfig config.CongestionControlConfig - // SINGLE-PEER-CONNECTION-TODO: guess this has to be superset of published and subscribed codecs + Handler transport.Handler + ProtocolVersion types.ProtocolVersion + Config *WebRTCConfig + Twcc *lktwcc.Responder + DirectionConfig DirectionConfig + CongestionControlConfig config.CongestionControlConfig EnabledCodecs []*livekit.Codec Logger logger.Logger Transport livekit.SignalTarget