From ee7bb0a1ad42e5c70af711d3f1cc623edf031ed0 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Sun, 10 Apr 2022 12:09:11 +0530 Subject: [PATCH] Log both estimate and nack ratio when congestion detected (#608) --- pkg/sfu/streamallocator.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/sfu/streamallocator.go b/pkg/sfu/streamallocator.go index d018f80ad..48e0e31b1 100644 --- a/pkg/sfu/streamallocator.go +++ b/pkg/sfu/streamallocator.go @@ -1620,12 +1620,14 @@ func (c *ChannelObserver) GetTrend() (ChannelTrend, ChannelCongestionReason) { "channel observer: estimate is trending downward", "name", c.params.Name, "estimate", c.estimateTrend.ToString(), + "ratio", nackRatio, ) return ChannelTrendCongesting, ChannelCongestionReasonEstimate case c.params.NackWindowMinDuration != 0 && !c.nackWindowStartTime.IsZero() && time.Since(c.nackWindowStartTime) > c.params.NackWindowMinDuration && nackRatio > c.params.NackRatioThreshold: c.logger.Debugw( "channel observer: high rate of repeated NACKs", "name", c.params.Name, + "estimate", c.estimateTrend.ToString(), "ratio", nackRatio, ) return ChannelTrendCongesting, ChannelCongestionReasonLoss