From f8a94c21250c16ad3cbd9a762117a0de9bfd8de1 Mon Sep 17 00:00:00 2001 From: David Zhao Date: Wed, 12 Apr 2023 21:01:57 -0700 Subject: [PATCH] Fixed timing-related failures with tests (#1608) --- pkg/rtc/subscriptionmanager_test.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkg/rtc/subscriptionmanager_test.go b/pkg/rtc/subscriptionmanager_test.go index 0132abb80..6a0edfdb5 100644 --- a/pkg/rtc/subscriptionmanager_test.go +++ b/pkg/rtc/subscriptionmanager_test.go @@ -105,7 +105,9 @@ func TestSubscribe(t *testing.T) { }, subSettleTimeout, subCheckInterval, "track was not resubscribed") // was subscribed twice, unsubscribed once (due to close) - require.Equal(t, int32(2), numParticipantSubscribed.Load()) + require.Eventually(t, func() bool { + return numParticipantSubscribed.Load() == 2 + }, subSettleTimeout, subCheckInterval, "participant subscribe status was not updated twice") require.Equal(t, int32(1), numParticipantUnsubscribed.Load()) }) @@ -325,7 +327,10 @@ func TestUpdateSettingsBeforeSubscription(t *testing.T) { }, subSettleTimeout, subCheckInterval, "Track should be subscribed") st := s.getSubscribedTrack().(*typesfakes.FakeSubscribedTrack) - require.Equal(t, 1, st.UpdateSubscriberSettingsCallCount()) + require.Eventually(t, func() bool { + return st.UpdateSubscriberSettingsCallCount() == 1 + }, subSettleTimeout, subCheckInterval, "UpdateSubscriberSettings should be called once") + applied := st.UpdateSubscriberSettingsArgsForCall(0) require.Equal(t, settings.Disabled, applied.Disabled) require.Equal(t, settings.Width, applied.Width)