diff --git a/pkg/rtc/participant_signal.go b/pkg/rtc/participant_signal.go index dc0a2405a..6f84eadd9 100644 --- a/pkg/rtc/participant_signal.go +++ b/pkg/rtc/participant_signal.go @@ -314,9 +314,7 @@ func (p *ParticipantImpl) writeMessage(msg *livekit.SignalResponse) error { func (p *ParticipantImpl) CloseSignalConnection(reason types.SignallingCloseReason) { sink := p.getResponseSink() if sink != nil { - if reason != types.SignallingCloseReasonParticipantClose { - p.params.Logger.Infow("closing signal connection", "reason", reason, "connID", sink.ConnectionID()) - } + p.params.Logger.Debugw("closing signal connection", "reason", reason, "connID", sink.ConnectionID()) sink.Close() p.SetResponseSink(nil) } diff --git a/pkg/sfu/connectionquality/scorer.go b/pkg/sfu/connectionquality/scorer.go index 7364e3dc3..5c960c8e8 100644 --- a/pkg/sfu/connectionquality/scorer.go +++ b/pkg/sfu/connectionquality/scorer.go @@ -440,7 +440,7 @@ func (q *qualityScorer) updateAtLocked(stat *windowStat, at time.Time) { prevCQ := scoreToConnectionQuality(q.score) currCQ := scoreToConnectionQuality(score) if utils.IsConnectionQualityLower(prevCQ, currCQ) { - q.params.Logger.Infow( + q.params.Logger.Debugw( "quality drop", "reason", reason, "prevScore", q.score, diff --git a/pkg/sfu/streamallocator/probe_controller.go b/pkg/sfu/streamallocator/probe_controller.go index 3796e3bfa..7426683c5 100644 --- a/pkg/sfu/streamallocator/probe_controller.go +++ b/pkg/sfu/streamallocator/probe_controller.go @@ -99,12 +99,12 @@ func (p *ProbeController) CheckProbe(trend ChannelTrend, highestEstimate int64) // In rare cases, the estimate gets stuck. Prevent from probe running amok // STREAM-ALLOCATOR-TODO: Need more testing here to ensure that probe does not cause a lot of damage // - p.params.Logger.Infow("stream allocator: probe: aborting, no trend", "cluster", p.probeClusterId) + p.params.Logger.Debugw("stream allocator: probe: aborting, no trend", "cluster", p.probeClusterId) p.abortProbeLocked() case trend == ChannelTrendCongesting: // stop immediately if the probe is congesting channel more - p.params.Logger.Infow("stream allocator: probe: aborting, channel is congesting", "cluster", p.probeClusterId) + p.params.Logger.Debugw("stream allocator: probe: aborting, channel is congesting", "cluster", p.probeClusterId) p.abortProbeLocked() case highestEstimate > p.probeGoalBps: diff --git a/pkg/sfu/streamallocator/prober.go b/pkg/sfu/streamallocator/prober.go index c30202454..d2fca217e 100644 --- a/pkg/sfu/streamallocator/prober.go +++ b/pkg/sfu/streamallocator/prober.go @@ -189,7 +189,7 @@ func (p *Prober) Reset() { p.clustersMu.Lock() if p.activeCluster != nil { - p.logger.Infow("prober: resetting active cluster", "cluster", p.activeCluster.String()) + p.logger.Debugw("prober: resetting active cluster", "cluster", p.activeCluster.String()) reset = true info = p.activeCluster.GetInfo() } diff --git a/pkg/sfu/streamallocator/streamallocator.go b/pkg/sfu/streamallocator/streamallocator.go index 87092b434..caeb594db 100644 --- a/pkg/sfu/streamallocator/streamallocator.go +++ b/pkg/sfu/streamallocator/streamallocator.go @@ -818,16 +818,29 @@ func (s *StreamAllocator) handleNewEstimateInNonProbe() { action = "skipping" } - s.params.Logger.Infow( - fmt.Sprintf("stream allocator: channel congestion detected, %s channel capacity update", action), - "reason", reason, - "old(bps)", s.committedChannelCapacity, - "new(bps)", estimateToCommit, - "lastReceived(bps)", s.lastReceivedEstimate, - "expectedUsage(bps)", expectedBandwidthUsage, - "commitThreshold(bps)", commitThreshold, - "channel", s.channelObserver.ToString(), - ) + if action == "applying" { + s.params.Logger.Infow( + fmt.Sprintf("stream allocator: channel congestion detected, %s channel capacity update", action), + "reason", reason, + "old(bps)", s.committedChannelCapacity, + "new(bps)", estimateToCommit, + "lastReceived(bps)", s.lastReceivedEstimate, + "expectedUsage(bps)", expectedBandwidthUsage, + "commitThreshold(bps)", commitThreshold, + "channel", s.channelObserver.ToString(), + ) + } else { + s.params.Logger.Debugw( + fmt.Sprintf("stream allocator: channel congestion detected, %s channel capacity update", action), + "reason", reason, + "old(bps)", s.committedChannelCapacity, + "new(bps)", estimateToCommit, + "lastReceived(bps)", s.lastReceivedEstimate, + "expectedUsage(bps)", expectedBandwidthUsage, + "commitThreshold(bps)", commitThreshold, + "channel", s.channelObserver.ToString(), + ) + } /* STREAM-ALLOCATOR-DATA s.params.Logger.Debugw( fmt.Sprintf("stream allocator: channel congestion detected, %s channel capacity: experimental", action),