mirror of
https://github.com/livekit/livekit.git
synced 2026-08-21 18:49:44 +00:00
Benjamin PrachtandGitHub
2cad1cc936
- Renovate config:recommended (config:base is deprecated) and matchPackageNames globs instead of the deprecated matchPackagePrefixes. Vulnerability alerts get a fast path: 2-day quarantine, no concurrency/hourly/schedule limits. Go modules are no longer grouped into one "go deps" PR — each gets its own, so a bad bump can be reverted alone. The pion modules stay grouped as a documented exception: they're co-released and interdependent, so individual PRs wouldn't build. First-party github.com/livekit/** skips the 2-week quarantine. go.mod's go directive is no longer an update target — the build toolchain is pinned in the Dockerfile instead. Dockerfile deps get pinDigests; the golang image is ungrouped with separateMinorPatch so a patch and a minor bump are each separately approvable. Custom manager to bump the builder image's -alpineA.B suffix together with its digest, which the stock docker manager holds fixed. - Pinning Both Dockerfiles pin golang and alpine by digest alongside the readable tag. GOTOOLCHAIN=local so a go.mod bump fails loudly instead of silently downloading a different toolchain. apk upgrade in the runtime stage — a digest pin plus the 2-week quarantine would otherwise ship base-package CVEs Alpine has already fixed. This relies on a cold layer cache, which holds today because the release workflow configures no buildx cache; there's a comment saying so. Workflows resolve the Go version from the Dockerfile via .github/scripts/go-version.sh, so tests, releases and images share one toolchain. - Tools All four code generators now come from the module graph, and tools/tools.go (the pre-Go-1.24 blank-import idiom) is replaced by go.mod tool directives: tool how why goimports go tool lives in x/tools — its own module is the one being selected gotestfmt go tool zero dependencies, nothing to skew wire go run pins x/tools v0.24.1; building it in our graph changes its output counterfeiter go run unchanged, matches its //go:generate directives The wire distinction is load-bearing. Building wire inside our module raises it from the x/tools v0.24.1 it pins to our v0.48.0, and that module version difference changes what it generates: it falls back to v/v2/v3 instead of deriving real identifiers from the type. wire_gen.go is regenerated here to match the in-module build — a cosmetic rename of 9 lines, with no other change to the generated code. golangci-lint deliberately keeps its action rather than becoming a tool: it pins its own x/tools (v0.44.0 vs our v0.48.0) for the analyzers it bundles, adding it to go.mod would double our go.mod/go.sum (158→338 / 441→889 lines), and the action supplies caching, only-new-issues and PR annotations that invoking a binary can't. Its version stays manual by request.
51 lines
1.8 KiB
Bash
Executable File
51 lines
1.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Copyright 2026 LiveKit, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
#
|
|
# Print the Go toolchain version pinned by a Dockerfile's golang builder image.
|
|
#
|
|
# usage: .github/scripts/go-version.sh [dockerfile] (default: Dockerfile)
|
|
#
|
|
# The pinned `golang:X.Y.Z-alpineA.B@sha256:...` builder image is the single source
|
|
# of truth, and Renovate keeps it current via an approvable PR. Each workflow reads
|
|
# the version out of the Dockerfile it builds against (setup-go cannot parse a
|
|
# Dockerfile itself), so a job's Go runtime always matches the image it produces.
|
|
#
|
|
# Deliberately NOT derived from go.mod's `go` directive: that is the module
|
|
# minimum, owned by the toolchain and by dependency requirements, and the go
|
|
# command may rewrite it to a bare major.minor.
|
|
set -euo pipefail
|
|
|
|
dockerfile="${1:-Dockerfile}"
|
|
|
|
if [ ! -f "$dockerfile" ]; then
|
|
echo "$dockerfile: no such file" >&2
|
|
exit 1
|
|
fi
|
|
|
|
version=$(sed -nE 's/^FROM[[:space:]]+golang:([0-9]+\.[0-9]+\.[0-9]+)[^[:space:]]*.*/\1/p' "$dockerfile" | sort -u)
|
|
|
|
if [ -z "$version" ]; then
|
|
echo "$dockerfile: no pinned 'FROM golang:X.Y.Z-...' base image found" >&2
|
|
exit 1
|
|
fi
|
|
|
|
if [ "$(printf '%s\n' "$version" | wc -l)" -ne 1 ]; then
|
|
echo "$dockerfile pins more than one Go version: $(echo $version)" >&2
|
|
exit 1
|
|
fi
|
|
|
|
echo "$version"
|