mirror of
https://github.com/livekit/livekit.git
synced 2026-03-30 19:55:41 +00:00
2192b0fc8d
* Limit dynacast to video and media loss proxy to audio Was looking at keeping the track type out of those modules and do a check at a higher level, but it is a bit unwieldy. So, adding checks to the modules. Also, ensuring that media loss proxy does not reset unconditionally every second. Audio RTCP happens once in 5 seconds or so. So, if server proxied let say 2% at t = 5, t = 6 would have proxied 0 loss which may or may not be true. So, ensure that a report was received and proxy value is updated by an actual report. * Remove track type from modules
92 lines
1.8 KiB
Go
92 lines
1.8 KiB
Go
package rtc
|
|
|
|
import (
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/pion/rtcp"
|
|
|
|
"github.com/livekit/protocol/livekit"
|
|
"github.com/livekit/protocol/logger"
|
|
|
|
"github.com/livekit/livekit-server/pkg/sfu"
|
|
)
|
|
|
|
const (
|
|
downLostUpdateDelta = time.Second
|
|
)
|
|
|
|
type MediaLossProxyParams struct {
|
|
Logger logger.Logger
|
|
}
|
|
|
|
type MediaLossProxy struct {
|
|
params MediaLossProxyParams
|
|
|
|
lock sync.Mutex
|
|
maxDownFracLost uint8
|
|
maxDownFracLostTs time.Time
|
|
maxDownFracLostValid bool
|
|
|
|
onMediaLossUpdate func(fractionalLoss uint8)
|
|
}
|
|
|
|
func NewMediaLossProxy(params MediaLossProxyParams) *MediaLossProxy {
|
|
return &MediaLossProxy{params: params}
|
|
}
|
|
|
|
func (m *MediaLossProxy) OnMediaLossUpdate(f func(fractionalLoss uint8)) {
|
|
m.lock.Lock()
|
|
m.onMediaLossUpdate = f
|
|
m.lock.Unlock()
|
|
}
|
|
|
|
func (m *MediaLossProxy) HandleMaxLossFeedback(_ *sfu.DownTrack, report *rtcp.ReceiverReport) {
|
|
m.lock.Lock()
|
|
for _, rr := range report.Reports {
|
|
m.maxDownFracLostValid = true
|
|
if m.maxDownFracLost < rr.FractionLost {
|
|
m.maxDownFracLost = rr.FractionLost
|
|
}
|
|
}
|
|
m.lock.Unlock()
|
|
|
|
m.maybeUpdateLoss()
|
|
}
|
|
|
|
func (m *MediaLossProxy) NotifySubscriberNodeMediaLoss(_nodeID livekit.NodeID, fractionalLoss uint8) {
|
|
m.lock.Lock()
|
|
m.maxDownFracLostValid = true
|
|
if m.maxDownFracLost < fractionalLoss {
|
|
m.maxDownFracLost = fractionalLoss
|
|
}
|
|
m.lock.Unlock()
|
|
|
|
m.maybeUpdateLoss()
|
|
}
|
|
|
|
func (m *MediaLossProxy) maybeUpdateLoss() {
|
|
var (
|
|
shouldUpdate bool
|
|
maxLost uint8
|
|
)
|
|
|
|
m.lock.Lock()
|
|
now := time.Now()
|
|
if now.Sub(m.maxDownFracLostTs) > downLostUpdateDelta && m.maxDownFracLostValid {
|
|
shouldUpdate = true
|
|
maxLost = m.maxDownFracLost
|
|
m.maxDownFracLost = 0
|
|
m.maxDownFracLostTs = now
|
|
m.maxDownFracLostValid = false
|
|
}
|
|
onMediaLossUpdate := m.onMediaLossUpdate
|
|
m.lock.Unlock()
|
|
|
|
if shouldUpdate {
|
|
if onMediaLossUpdate != nil {
|
|
onMediaLossUpdate(maxLost)
|
|
}
|
|
}
|
|
}
|