mirror of
https://github.com/livekit/livekit.git
synced 2026-04-27 02:05:25 +00:00
0d8848cfcd
* Do not count padding packets in stream tracker. There are cases where publisher uses padding only packets in a layer to probe the channel. Treating those as valid layer packets makes stream tracker declare that the layer is active where in reality, it is not. Also, removing check for out-of-order packets. Out-of-order packets can happen and should be counted in bitrate calculation. There is the extreme case of heavy loss which might skew it, but that is an extreme case. * Fix test
187 lines
4.8 KiB
Go
187 lines
4.8 KiB
Go
package sfu
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"go.uber.org/atomic"
|
|
|
|
"github.com/livekit/livekit-server/pkg/testutils"
|
|
"github.com/livekit/protocol/logger"
|
|
)
|
|
|
|
func newStreamTracker(samplesRequired uint32, cyclesRequired uint32, cycleDuration time.Duration) *StreamTracker {
|
|
return NewStreamTracker(StreamTrackerParams{
|
|
SamplesRequired: samplesRequired,
|
|
CyclesRequired: cyclesRequired,
|
|
CycleDuration: cycleDuration,
|
|
Logger: logger.GetDefaultLogger(),
|
|
})
|
|
}
|
|
|
|
func TestStreamTracker(t *testing.T) {
|
|
t.Run("flips to active on first observe", func(t *testing.T) {
|
|
callbackCalled := atomic.NewBool(false)
|
|
tracker := newStreamTracker(5, 60, 500*time.Millisecond)
|
|
tracker.Start()
|
|
tracker.OnStatusChanged(func(status StreamStatus) {
|
|
callbackCalled.Store(true)
|
|
})
|
|
require.Equal(t, StreamStatusStopped, tracker.Status())
|
|
|
|
// observe first packet
|
|
tracker.Observe(1, 0, 20, 10)
|
|
|
|
testutils.WithTimeout(t, func() string {
|
|
if callbackCalled.Load() {
|
|
return ""
|
|
} else {
|
|
return "first packet didn't activate stream"
|
|
}
|
|
})
|
|
|
|
require.Equal(t, StreamStatusActive, tracker.Status())
|
|
require.True(t, callbackCalled.Load())
|
|
|
|
tracker.Stop()
|
|
})
|
|
|
|
t.Run("flips to inactive immediately", func(t *testing.T) {
|
|
tracker := newStreamTracker(5, 60, 500*time.Millisecond)
|
|
tracker.Start()
|
|
require.Equal(t, StreamStatusStopped, tracker.Status())
|
|
|
|
tracker.Observe(1, 0, 20, 10)
|
|
testutils.WithTimeout(t, func() string {
|
|
if tracker.Status() == StreamStatusActive {
|
|
return ""
|
|
} else {
|
|
return "first packet did not activate stream"
|
|
}
|
|
})
|
|
|
|
callbackCalled := atomic.NewBool(false)
|
|
tracker.OnStatusChanged(func(status StreamStatus) {
|
|
callbackCalled.Store(true)
|
|
})
|
|
require.Equal(t, StreamStatusActive, tracker.Status())
|
|
|
|
// run a single iteration
|
|
tracker.detectChanges()
|
|
|
|
testutils.WithTimeout(t, func() string {
|
|
if callbackCalled.Load() {
|
|
return ""
|
|
} else {
|
|
return "inactive cycle did not declare stream stopped"
|
|
}
|
|
})
|
|
require.Equal(t, StreamStatusStopped, tracker.Status())
|
|
require.True(t, callbackCalled.Load())
|
|
|
|
tracker.Stop()
|
|
})
|
|
|
|
t.Run("flips back to active after iterations", func(t *testing.T) {
|
|
tracker := newStreamTracker(1, 2, 500*time.Millisecond)
|
|
tracker.Start()
|
|
require.Equal(t, StreamStatusStopped, tracker.Status())
|
|
|
|
tracker.Observe(1, 0, 20, 10)
|
|
testutils.WithTimeout(t, func() string {
|
|
if tracker.Status() == StreamStatusActive {
|
|
return ""
|
|
} else {
|
|
return "first packet did not activate stream"
|
|
}
|
|
})
|
|
|
|
tracker.maybeSetStatus(StreamStatusStopped)
|
|
|
|
tracker.Observe(2, 0, 20, 10)
|
|
tracker.detectChanges()
|
|
require.Equal(t, StreamStatusStopped, tracker.Status())
|
|
|
|
tracker.Observe(3, 0, 20, 10)
|
|
tracker.detectChanges()
|
|
require.Equal(t, StreamStatusActive, tracker.Status())
|
|
|
|
tracker.Stop()
|
|
})
|
|
|
|
t.Run("changes to inactive when paused", func(t *testing.T) {
|
|
tracker := newStreamTracker(5, 60, 500*time.Millisecond)
|
|
tracker.Start()
|
|
tracker.Observe(1, 0, 20, 10)
|
|
testutils.WithTimeout(t, func() string {
|
|
if tracker.Status() == StreamStatusActive {
|
|
return ""
|
|
} else {
|
|
return "first packet did not activate stream"
|
|
}
|
|
})
|
|
|
|
tracker.SetPaused(true)
|
|
tracker.detectChanges()
|
|
require.Equal(t, StreamStatusStopped, tracker.Status())
|
|
|
|
tracker.Stop()
|
|
})
|
|
|
|
t.Run("flips back to active on first observe after reset", func(t *testing.T) {
|
|
callbackCalled := atomic.NewUint32(0)
|
|
tracker := newStreamTracker(5, 60, 500*time.Millisecond)
|
|
tracker.Start()
|
|
tracker.OnStatusChanged(func(status StreamStatus) {
|
|
callbackCalled.Inc()
|
|
})
|
|
require.Equal(t, StreamStatusStopped, tracker.Status())
|
|
|
|
// observe first packet
|
|
tracker.Observe(1, 0, 20, 10)
|
|
|
|
testutils.WithTimeout(t, func() string {
|
|
if callbackCalled.Load() == 1 {
|
|
return ""
|
|
} else {
|
|
return fmt.Sprintf("expected onStatusChanged to be called once, actual: %d", callbackCalled.Load())
|
|
}
|
|
})
|
|
|
|
require.Equal(t, StreamStatusActive, tracker.Status())
|
|
require.Equal(t, uint32(1), callbackCalled.Load())
|
|
|
|
// observe a few more
|
|
tracker.Observe(2, 0, 20, 10)
|
|
tracker.Observe(3, 0, 20, 10)
|
|
tracker.Observe(4, 0, 20, 10)
|
|
tracker.Observe(5, 0, 20, 10)
|
|
tracker.detectChanges()
|
|
|
|
// should still be active
|
|
require.Equal(t, StreamStatusActive, tracker.Status())
|
|
|
|
// Reset. The first packet after reset should flip state again
|
|
tracker.Reset()
|
|
require.Equal(t, StreamStatusStopped, tracker.Status())
|
|
|
|
// first packet after reset
|
|
tracker.Observe(1, 0, 20, 10)
|
|
|
|
testutils.WithTimeout(t, func() string {
|
|
if callbackCalled.Load() == 2 {
|
|
return ""
|
|
} else {
|
|
return fmt.Sprintf("expected onStatusChanged to be called twice, actual %d", callbackCalled.Load())
|
|
}
|
|
})
|
|
|
|
require.Equal(t, StreamStatusActive, tracker.Status())
|
|
require.Equal(t, uint32(2), callbackCalled.Load())
|
|
|
|
tracker.Stop()
|
|
})
|
|
}
|