mirror of
https://github.com/livekit/livekit.git
synced 2026-10-15 17:40:16 +00:00
Ryan GausandClaude Opus 5.5
5a5a6132c7
Firefox 155 enabled AV1 for WebRTC by default, but Firefox 155/156 decode only the base spatial layer of an AV1 SVC stream. SVC is not visible in SDP, so such a subscriber that negotiates AV1 is forwarded the publisher's AV1 SVC stream instead of its backup codec, rendering black whenever a higher layer is selected. Firefox 157 decodes the higher layers correctly (client-sdk-js#2116), so it keeps AV1. Removing AV1 from the subscriber's enabled codecs keeps it out of the SFU's offers and answers, so the down track binds to the backup codec. Firefox never publishes AV1 either, so it is disabled in both directions, the same as Safari. The Firefox for Android H.264 rule is switched to merge so it no longer drops the AV1 rule for that browser. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
82 lines
2.9 KiB
Go
82 lines
2.9 KiB
Go
// Copyright 2023 LiveKit, Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package clientconfiguration
|
|
|
|
import (
|
|
"github.com/livekit/protocol/codecs/mime"
|
|
"github.com/livekit/protocol/livekit"
|
|
"github.com/livekit/protocol/utils/must"
|
|
)
|
|
|
|
// StaticConfigurations list specific device-side limitations that should be disabled at a global level
|
|
var StaticConfigurations = []ConfigurationItem{
|
|
// {
|
|
// Match: must.Get(NewScriptMatch(`c.protocol <= 5 || c.browser == "firefox"`)),
|
|
// Configuration: &livekit.ClientConfiguration{ResumeConnection: livekit.ClientConfigSetting_DISABLED},
|
|
// Merge: false,
|
|
// },
|
|
{
|
|
Match: must.Get(NewScriptMatch(`c.browser == "safari"`)),
|
|
Configuration: &livekit.ClientConfiguration{
|
|
DisabledCodecs: &livekit.DisabledCodecs{
|
|
Codecs: []*livekit.Codec{
|
|
{Mime: mime.MimeTypeAV1.String()},
|
|
},
|
|
},
|
|
},
|
|
Merge: true,
|
|
},
|
|
{
|
|
Match: must.Get(NewScriptMatch(`c.browser == "safari" && c.browser_version > "18.3"`)),
|
|
Configuration: &livekit.ClientConfiguration{
|
|
DisabledCodecs: &livekit.DisabledCodecs{
|
|
Publish: []*livekit.Codec{
|
|
{Mime: mime.MimeTypeVP9.String()},
|
|
},
|
|
},
|
|
},
|
|
Merge: true,
|
|
},
|
|
// Firefox 155 enabled AV1 for WebRTC by default, but 155/156 decode only the base spatial
|
|
// layer of an AV1 SVC stream. SVC is not visible in SDP, so such a subscriber negotiating AV1
|
|
// would be forwarded the SVC stream in place of the publisher's backup codec and render
|
|
// higher layers black. Firefox 157 decodes the higher layers, so it keeps AV1.
|
|
// Firefox does not publish AV1 either (no SVC encoding), so disable it in both directions.
|
|
{
|
|
Match: must.Get(NewScriptMatch(`(c.browser == "firefox" || c.browser == "firefox mobile") && c.browser_version < "157"`)),
|
|
Configuration: &livekit.ClientConfiguration{
|
|
DisabledCodecs: &livekit.DisabledCodecs{
|
|
Codecs: []*livekit.Codec{
|
|
{Mime: mime.MimeTypeAV1.String()},
|
|
},
|
|
},
|
|
},
|
|
Merge: true,
|
|
},
|
|
{
|
|
Match: must.Get(NewScriptMatch(`(c.device_model == "xiaomi 2201117ti" && c.os == "android") ||
|
|
((c.browser == "firefox" || c.browser == "firefox mobile") && c.os == "android")`)),
|
|
Configuration: &livekit.ClientConfiguration{
|
|
DisabledCodecs: &livekit.DisabledCodecs{
|
|
Publish: []*livekit.Codec{
|
|
{Mime: mime.MimeTypeH264.String()},
|
|
},
|
|
},
|
|
},
|
|
// merged so Firefox for Android keeps the AV1 rule above
|
|
Merge: true,
|
|
},
|
|
}
|