mirror of
https://github.com/livekit/livekit.git
synced 2026-09-25 15:34:14 +00:00
Raja SubramanianandClaude Fable 5.1
61a31d31ff
SendPacket allocated four times per down track write: a 3 byte slice for abs-send-time, a 2 byte slice for transport-cc, and two appends to a nil Extensions slice because the pooled header was reset to a zero value. Give pacer.Packet fixed scratch arrays for the two extensions and marshal into them. The Packet is pooled and owned by one send until SendPacket returns, so nothing is shared across down tracks. Keep the pooled header's Extensions capacity across reuse, both when returning it to the pool and when a down track initializes it. Adds a test that asserts zero allocations per SendPacket. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
44 lines
1.1 KiB
Go
44 lines
1.1 KiB
Go
// Copyright 2023 LiveKit, Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package sfu
|
|
|
|
import (
|
|
"sync"
|
|
|
|
"github.com/pion/rtp"
|
|
)
|
|
|
|
var (
|
|
PacketFactory = &sync.Pool{
|
|
New: func() any {
|
|
b := make([]byte, 1460)
|
|
return &b
|
|
},
|
|
}
|
|
|
|
RTPHeaderFactory = &sync.Pool{
|
|
New: func() any {
|
|
return &rtp.Header{}
|
|
},
|
|
}
|
|
)
|
|
|
|
// initPooledRTPHeader sets hdr to h while keeping the pooled header's
|
|
// Extensions capacity, so SetExtension does not allocate per packet.
|
|
func initPooledRTPHeader(hdr *rtp.Header, h rtp.Header) {
|
|
h.Extensions = hdr.Extensions[:0]
|
|
*hdr = h
|
|
}
|