Files
livekit/pkg/sfu/codecmunger/vp8dd.go
T
Raja SubramanianandClaude Opus 5.5 152328c76a sfu: filter VP8 temporal layers by frame when the dependency descriptor is sent (#4976)
* sfu: filter VP8 temporal layers by frame when the dependency descriptor is sent

With the dependency descriptor, libwebrtc sends a one byte VP8 payload
descriptor without a picture ID, so the VP8 munger's picture ID based
temporal drop logic stops filtering after the first gap. A new VP8DD codec
munger decides once per frame from the descriptor's frame number and
temporal ID and applies that decision to every packet of the frame.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* sfu: use the VP8 munger when picture IDs come with the dependency descriptor

VP8DD needs the one byte VP8 payload descriptor that libwebrtc sends with
the dependency descriptor. If a publisher keeps picture IDs next to the
descriptor, they need rewriting, so the forwarder switches to the VP8
munger and keeps switching temporal layers with the descriptor.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-11 11:16:34 +05:30

132 lines
3.8 KiB
Go

// Copyright 2026 LiveKit, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package codecmunger
import (
"github.com/livekit/livekit-server/pkg/sfu/buffer"
"github.com/livekit/mediatransportutil/pkg/codec"
"github.com/livekit/protocol/logger"
)
// frames with a remembered decision, behind the highest frame number
const vp8DDFrameWindow = 64
// VP8DD filters VP8 temporal layers with the dependency descriptor. libwebrtc sends a
// one byte VP8 payload descriptor with the dependency descriptor, so there is no picture
// ID, TL0PICIDX or key index to munge, and the header goes out unchanged. Every packet
// names its frame and temporal layer, so the munger decides once per frame and applies
// that decision to all packets of the frame, a late one included. It needs the one byte
// descriptor: the forwarder uses the VP8 munger for a stream that keeps picture IDs.
type VP8DD struct {
logger logger.Logger
initialized bool
highestFrame uint64
decidedMask uint64 // bit i: frame highestFrame - i has a decision
forwardedMask uint64 // bit i: frame highestFrame - i is forwarded
}
func NewVP8DD(logger logger.Logger) *VP8DD {
return &VP8DD{
logger: logger,
}
}
func (v *VP8DD) GetState() any {
return nil
}
func (v *VP8DD) SeedState(_state any) {
}
func (v *VP8DD) SetLast(_extPkt *buffer.ExtPacket) {
v.initialized = false
}
func (v *VP8DD) UpdateOffsets(_extPkt *buffer.ExtPacket) {
// a layer switch starts a stream with its own frame numbers
v.initialized = false
}
func (v *VP8DD) UpdateAndGet(extPkt *buffer.ExtPacket, snOutOfOrder bool, _snHasGap bool, maxTemporalLayer int32) (int, [MaxHeaderSize]byte, int, error) {
var hdr [MaxHeaderSize]byte
ddwdt := extPkt.DependencyDescriptor
if ddwdt == nil {
return 0, hdr, 0, nil
}
frame := ddwdt.ExtFrameNum
isForwarded, ok := v.decision(frame)
if !ok {
isForwarded = extPkt.Temporal <= maxTemporalLayer
if !v.record(frame, isForwarded) {
// a late packet of a frame that is too old to have a decision
isForwarded = false
}
}
switch {
case isForwarded:
return 0, hdr, 0, nil
case snOutOfOrder:
return 0, hdr, 0, ErrFilteredVP8OutOfOrder
default:
return 0, hdr, 0, ErrFilteredVP8TemporalLayer
}
}
func (v *VP8DD) UpdateAndGetPadding(_newPicture bool) ([]byte, error) {
// the one byte payload descriptor of a key frame that starts a partition
vp8Packet := &codec.VP8{
FirstByte: 0x10,
IsKeyFrame: true,
HeaderSize: 1,
}
return vp8Packet.Marshal()
}
func (v *VP8DD) decision(frame uint64) (isForwarded bool, ok bool) {
if !v.initialized || frame > v.highestFrame || v.highestFrame-frame >= vp8DDFrameWindow {
return false, false
}
bit := uint64(1) << (v.highestFrame - frame)
return v.forwardedMask&bit != 0, v.decidedMask&bit != 0
}
func (v *VP8DD) record(frame uint64, isForwarded bool) bool {
switch {
case !v.initialized || frame >= v.highestFrame+vp8DDFrameWindow:
v.initialized = true
v.highestFrame = frame
v.decidedMask = 0
v.forwardedMask = 0
case frame > v.highestFrame:
v.decidedMask <<= frame - v.highestFrame
v.forwardedMask <<= frame - v.highestFrame
v.highestFrame = frame
case v.highestFrame-frame >= vp8DDFrameWindow:
return false
}
bit := uint64(1) << (v.highestFrame - frame)
v.decidedMask |= bit
if isForwarded {
v.forwardedMask |= bit
}
return true
}