mirror of
https://github.com/livekit/livekit.git
synced 2026-06-29 14:01:55 +00:00
Paul Wells
b882ccc86d
* service: enforce metadata size limit in CreateRoom, bump default to 512 KiB CreateRoom previously accepted any metadata size; only UpdateRoomMetadata rejected oversized payloads. Mirror the same CheckMetadataSize check at the CreateRoom API boundary so both entrypoints are bounded. Default MaxMetadataSize moves from 64000 to 512 * 1024 to match the practical needs of customers using room metadata for richer state. The limit remains configurable via the existing limits.max_metadata_size knob. * service: split room vs. participant metadata limit, enforce on join + agent dispatch LimitConfig.MaxMetadataSize was shared between room metadata and participant metadata. Last commit's bump to 512 KiB lifted both ceilings; this restores the participant ceiling to 64 KB and introduces a separate MaxRoomMetadataSize (default 512 KiB) for room metadata. Additional enforcement: - RoomManager.StartSession rejects joins whose JWT-grants metadata or attributes exceed the participant/attributes limits. The check was missing entirely from this path. - AgentDispatchService.CreateDispatch and the embedded CreateRoomRequest.Agents path now validate metadata and attributes against the common 64 KB ceilings (previously unbounded). NewAgentDispatchService gains a LimitConfig parameter; the two wire_gen callsites are updated. * service: collapse metadata size limit to single 512 KiB knob Reverts the LimitConfig split introduced in the previous commit: MaxRoomMetadataSize, CheckRoomMetadataSize, and the max_room_metadata_size yaml key are removed. MaxMetadataSize moves back to 512 * 1024 and gates all metadata uniformly — room (CreateRoom, UpdateRoomMetadata), participant (UpdateParticipant, signal UpdateMetadata, JWT grants on join), and agent dispatch (CreateDispatch + embedded RoomAgentDispatch). MaxAttributesSize stays at 64 KB and continues to gate participant and agent-dispatch attributes separately. Test cases consolidated under the single knob. * kb -> kib