mirror of
https://github.com/livekit/livekit.git
synced 2026-09-29 06:49:01 +00:00
Raja SubramanianandClaude Opus 4.8
be944ee964
* sfu: don't hold bindLock across the blank-frame flush in CloseWithFlush CloseWithFlush held bindLock across the up-to-flushTimeout (1s) wait for the closing blank-frame flush. bindLock is a control-plane lock, also taken by Bind/SetConnected/ReceiverRestart, so every close serialized those behind its flush wait. This was the single largest accumulator in mutex contention profiling under track churn, aggregated across all closing downtracks. The flush runs in its own goroutine (writeBlankFrameRTP) and is cancelled via blankFramesGeneration, so the lock guards nothing during the wait; release it and re-acquire for the unbind/delete teardown. Guard the control-plane mutators on isClosed so none can act on a downtrack through the newly opened window. Bind in particular was reachable: its bindState != unbound check does not catch a closed track, since close leaves the state unbound. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * sfu: drop redundant isClosed guard in Bind Bind already handles a closed downtrack after codec matching (returns the codec with no error, preserving pion's non-error contract and never rebuilding state). The early guard returned errDownTrackClosed, which handleRemoteAnswerReceived treats as a negotiation failure, so a close/negotiation race could abort the remote answer. Remove it and the error type. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>