mirror of
https://github.com/livekit/livekit.git
synced 2026-04-25 22:02:08 +00:00
17236799bb
* Fix handling of non-monotonic timestamps Timed version is inspired by Hybrid Clock. We used to have a mixed behavior by using time.Time: * during local comparisons, it does increment monotonically * when deserializing remote timestamps, we lose that attribute So it's possible for two requests to be sent in the same microsecond, and for the latter one to be dropped. To fix that behavior, I'm switching it to keeping timestamps to consolidate that behavior, and accepting multiple updates in the same ms by incrementing ticks. Also using @paulwe's idea of a version generator.
294 lines
9.0 KiB
Go
294 lines
9.0 KiB
Go
package rtc
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/livekit/livekit-server/pkg/utils"
|
|
"github.com/livekit/protocol/livekit"
|
|
"github.com/livekit/protocol/logger"
|
|
|
|
"github.com/livekit/livekit-server/pkg/rtc/types"
|
|
"github.com/livekit/livekit-server/pkg/rtc/types/typesfakes"
|
|
)
|
|
|
|
var defaultUptrackManagerParams = UpTrackManagerParams{
|
|
Logger: logger.GetLogger(),
|
|
VersionGenerator: utils.NewDefaultTimedVersionGenerator(),
|
|
}
|
|
|
|
func TestUpdateSubscriptionPermission(t *testing.T) {
|
|
t.Run("updates subscription permission", func(t *testing.T) {
|
|
um := NewUpTrackManager(defaultUptrackManagerParams)
|
|
|
|
tra := &typesfakes.FakeMediaTrack{}
|
|
tra.IDReturns("audio")
|
|
um.publishedTracks["audio"] = tra
|
|
|
|
trv := &typesfakes.FakeMediaTrack{}
|
|
trv.IDReturns("video")
|
|
um.publishedTracks["video"] = trv
|
|
|
|
// no restrictive subscription permission
|
|
subscriptionPermission := &livekit.SubscriptionPermission{
|
|
AllParticipants: true,
|
|
}
|
|
um.UpdateSubscriptionPermission(subscriptionPermission, nil, nil, nil)
|
|
require.Nil(t, um.subscriberPermissions)
|
|
|
|
// nobody is allowed to subscribe
|
|
subscriptionPermission = &livekit.SubscriptionPermission{
|
|
TrackPermissions: []*livekit.TrackPermission{},
|
|
}
|
|
um.UpdateSubscriptionPermission(subscriptionPermission, nil, nil, nil)
|
|
require.NotNil(t, um.subscriberPermissions)
|
|
require.Equal(t, 0, len(um.subscriberPermissions))
|
|
|
|
lp1 := &typesfakes.FakeLocalParticipant{}
|
|
lp1.IdentityReturns("p1")
|
|
lp2 := &typesfakes.FakeLocalParticipant{}
|
|
lp2.IdentityReturns("p2")
|
|
|
|
sidResolver := func(sid livekit.ParticipantID) types.LocalParticipant {
|
|
if sid == "p1" {
|
|
return lp1
|
|
}
|
|
|
|
if sid == "p2" {
|
|
return lp2
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// allow all tracks for participants
|
|
perms1 := &livekit.TrackPermission{
|
|
ParticipantSid: "p1",
|
|
AllTracks: true,
|
|
}
|
|
perms2 := &livekit.TrackPermission{
|
|
ParticipantSid: "p2",
|
|
AllTracks: true,
|
|
}
|
|
subscriptionPermission = &livekit.SubscriptionPermission{
|
|
TrackPermissions: []*livekit.TrackPermission{
|
|
perms1,
|
|
perms2,
|
|
},
|
|
}
|
|
um.UpdateSubscriptionPermission(subscriptionPermission, nil, nil, sidResolver)
|
|
require.Equal(t, 2, len(um.subscriberPermissions))
|
|
require.EqualValues(t, perms1, um.subscriberPermissions["p1"])
|
|
require.EqualValues(t, perms2, um.subscriberPermissions["p2"])
|
|
|
|
// allow all tracks for some and restrictive for others
|
|
perms1 = &livekit.TrackPermission{
|
|
ParticipantIdentity: "p1",
|
|
AllTracks: true,
|
|
}
|
|
perms2 = &livekit.TrackPermission{
|
|
ParticipantIdentity: "p2",
|
|
TrackSids: []string{"audio"},
|
|
}
|
|
perms3 := &livekit.TrackPermission{
|
|
ParticipantIdentity: "p3",
|
|
TrackSids: []string{"video"},
|
|
}
|
|
subscriptionPermission = &livekit.SubscriptionPermission{
|
|
TrackPermissions: []*livekit.TrackPermission{
|
|
perms1,
|
|
perms2,
|
|
perms3,
|
|
},
|
|
}
|
|
um.UpdateSubscriptionPermission(subscriptionPermission, nil, nil, nil)
|
|
require.Equal(t, 3, len(um.subscriberPermissions))
|
|
require.EqualValues(t, perms1, um.subscriberPermissions["p1"])
|
|
require.EqualValues(t, perms2, um.subscriberPermissions["p2"])
|
|
require.EqualValues(t, perms3, um.subscriberPermissions["p3"])
|
|
})
|
|
|
|
t.Run("updates subscription permission using both", func(t *testing.T) {
|
|
um := NewUpTrackManager(defaultUptrackManagerParams)
|
|
|
|
tra := &typesfakes.FakeMediaTrack{}
|
|
tra.IDReturns("audio")
|
|
um.publishedTracks["audio"] = tra
|
|
|
|
trv := &typesfakes.FakeMediaTrack{}
|
|
trv.IDReturns("video")
|
|
um.publishedTracks["video"] = trv
|
|
|
|
lp1 := &typesfakes.FakeLocalParticipant{}
|
|
lp1.IdentityReturns("p1")
|
|
lp2 := &typesfakes.FakeLocalParticipant{}
|
|
lp2.IdentityReturns("p2")
|
|
|
|
sidResolver := func(sid livekit.ParticipantID) types.LocalParticipant {
|
|
if sid == "p1" {
|
|
return lp1
|
|
}
|
|
|
|
if sid == "p2" {
|
|
return lp2
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// allow all tracks for participants
|
|
perms1 := &livekit.TrackPermission{
|
|
ParticipantSid: "p1",
|
|
ParticipantIdentity: "p1",
|
|
AllTracks: true,
|
|
}
|
|
perms2 := &livekit.TrackPermission{
|
|
ParticipantSid: "p2",
|
|
ParticipantIdentity: "p2",
|
|
AllTracks: true,
|
|
}
|
|
subscriptionPermission := &livekit.SubscriptionPermission{
|
|
TrackPermissions: []*livekit.TrackPermission{
|
|
perms1,
|
|
perms2,
|
|
},
|
|
}
|
|
err := um.UpdateSubscriptionPermission(subscriptionPermission, nil, nil, sidResolver)
|
|
require.NoError(t, err)
|
|
require.Equal(t, 2, len(um.subscriberPermissions))
|
|
require.EqualValues(t, perms1, um.subscriberPermissions["p1"])
|
|
require.EqualValues(t, perms2, um.subscriberPermissions["p2"])
|
|
|
|
// mismatched identities should fail a permission update
|
|
badSidResolver := func(sid livekit.ParticipantID) types.LocalParticipant {
|
|
if sid == "p1" {
|
|
return lp2
|
|
}
|
|
|
|
if sid == "p2" {
|
|
return lp1
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
err = um.UpdateSubscriptionPermission(subscriptionPermission, nil, nil, badSidResolver)
|
|
require.NoError(t, err)
|
|
require.Equal(t, 2, len(um.subscriberPermissions))
|
|
require.EqualValues(t, perms1, um.subscriberPermissions["p1"])
|
|
require.EqualValues(t, perms2, um.subscriberPermissions["p2"])
|
|
})
|
|
}
|
|
|
|
func TestSubscriptionPermission(t *testing.T) {
|
|
t.Run("checks subscription permission", func(t *testing.T) {
|
|
um := NewUpTrackManager(defaultUptrackManagerParams)
|
|
|
|
tra := &typesfakes.FakeMediaTrack{}
|
|
tra.IDReturns("audio")
|
|
um.publishedTracks["audio"] = tra
|
|
|
|
trv := &typesfakes.FakeMediaTrack{}
|
|
trv.IDReturns("video")
|
|
um.publishedTracks["video"] = trv
|
|
|
|
// no restrictive permission
|
|
subscriptionPermission := &livekit.SubscriptionPermission{
|
|
AllParticipants: true,
|
|
}
|
|
um.UpdateSubscriptionPermission(subscriptionPermission, nil, nil, nil)
|
|
require.True(t, um.hasPermissionLocked("audio", "p1"))
|
|
require.True(t, um.hasPermissionLocked("audio", "p2"))
|
|
|
|
// nobody is allowed to subscribe
|
|
subscriptionPermission = &livekit.SubscriptionPermission{
|
|
TrackPermissions: []*livekit.TrackPermission{},
|
|
}
|
|
um.UpdateSubscriptionPermission(subscriptionPermission, nil, nil, nil)
|
|
require.False(t, um.hasPermissionLocked("audio", "p1"))
|
|
require.False(t, um.hasPermissionLocked("audio", "p2"))
|
|
|
|
// allow all tracks for participants
|
|
subscriptionPermission = &livekit.SubscriptionPermission{
|
|
TrackPermissions: []*livekit.TrackPermission{
|
|
{
|
|
ParticipantIdentity: "p1",
|
|
AllTracks: true,
|
|
},
|
|
{
|
|
ParticipantIdentity: "p2",
|
|
AllTracks: true,
|
|
},
|
|
},
|
|
}
|
|
um.UpdateSubscriptionPermission(subscriptionPermission, nil, nil, nil)
|
|
require.True(t, um.hasPermissionLocked("audio", "p1"))
|
|
require.True(t, um.hasPermissionLocked("video", "p1"))
|
|
require.True(t, um.hasPermissionLocked("audio", "p2"))
|
|
require.True(t, um.hasPermissionLocked("video", "p2"))
|
|
|
|
// add a new track after permissions are set
|
|
trs := &typesfakes.FakeMediaTrack{}
|
|
trs.IDReturns("screen")
|
|
um.publishedTracks["screen"] = trs
|
|
|
|
require.True(t, um.hasPermissionLocked("audio", "p1"))
|
|
require.True(t, um.hasPermissionLocked("video", "p1"))
|
|
require.True(t, um.hasPermissionLocked("screen", "p1"))
|
|
require.True(t, um.hasPermissionLocked("audio", "p2"))
|
|
require.True(t, um.hasPermissionLocked("video", "p2"))
|
|
require.True(t, um.hasPermissionLocked("screen", "p2"))
|
|
|
|
// allow all tracks for some and restrictive for others
|
|
subscriptionPermission = &livekit.SubscriptionPermission{
|
|
TrackPermissions: []*livekit.TrackPermission{
|
|
{
|
|
ParticipantIdentity: "p1",
|
|
AllTracks: true,
|
|
},
|
|
{
|
|
ParticipantIdentity: "p2",
|
|
TrackSids: []string{"audio"},
|
|
},
|
|
{
|
|
ParticipantIdentity: "p3",
|
|
TrackSids: []string{"video"},
|
|
},
|
|
},
|
|
}
|
|
um.UpdateSubscriptionPermission(subscriptionPermission, nil, nil, nil)
|
|
require.True(t, um.hasPermissionLocked("audio", "p1"))
|
|
require.True(t, um.hasPermissionLocked("video", "p1"))
|
|
require.True(t, um.hasPermissionLocked("screen", "p1"))
|
|
|
|
require.True(t, um.hasPermissionLocked("audio", "p2"))
|
|
require.False(t, um.hasPermissionLocked("video", "p2"))
|
|
require.False(t, um.hasPermissionLocked("screen", "p2"))
|
|
|
|
require.False(t, um.hasPermissionLocked("audio", "p3"))
|
|
require.True(t, um.hasPermissionLocked("video", "p3"))
|
|
require.False(t, um.hasPermissionLocked("screen", "p3"))
|
|
|
|
// add a new track after restrictive permissions are set
|
|
trw := &typesfakes.FakeMediaTrack{}
|
|
trw.IDReturns("watch")
|
|
um.publishedTracks["watch"] = trw
|
|
|
|
require.True(t, um.hasPermissionLocked("audio", "p1"))
|
|
require.True(t, um.hasPermissionLocked("video", "p1"))
|
|
require.True(t, um.hasPermissionLocked("screen", "p1"))
|
|
require.True(t, um.hasPermissionLocked("watch", "p1"))
|
|
|
|
require.True(t, um.hasPermissionLocked("audio", "p2"))
|
|
require.False(t, um.hasPermissionLocked("video", "p2"))
|
|
require.False(t, um.hasPermissionLocked("screen", "p2"))
|
|
require.False(t, um.hasPermissionLocked("watch", "p2"))
|
|
|
|
require.False(t, um.hasPermissionLocked("audio", "p3"))
|
|
require.True(t, um.hasPermissionLocked("video", "p3"))
|
|
require.False(t, um.hasPermissionLocked("screen", "p3"))
|
|
require.False(t, um.hasPermissionLocked("watch", "p3"))
|
|
})
|
|
}
|