mirror of
https://github.com/livekit/livekit.git
synced 2026-09-09 14:05:33 +00:00
Raja SubramanianandClaude Opus 5
0aae7a4894
* fix: hold signal messages until the ReconnectResponse goes out Clients take the ReconnectResponse as the first message on a resumed or migrated in signal connection, anything ahead of it is dropped. Hold messages back until it has been written. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: keep queued participant updates on a path that always flushes Queue only while the participant is not ready, that queue is always drained by the join or reconnect response. Log a dropped SDP, it leaves the negotiation waiting until the state machine recovers it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: flush queued updates whenever the connection opens Queue participant updates while the handshake is pending again, and give the signaller a hook that fires when the connection opens, on an explicit open and on the handshake window expiring, so the queue always drains. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: drive the handshake window off a timer and read the gate atomically The window ran only when something asked whether the handshake was pending, so a connection with nothing else to send held its queue. Reading the gate under the lock the flush takes closes the race where an update queued just after a flush. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: ignore a handshake timeout from a wait that has ended Stop cannot cancel a timeout that is already running, so tag each wait and let a timeout act only on its own. Count opens atomically in the test, the timer fires on its own goroutine. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
75 lines
3.7 KiB
Go
75 lines
3.7 KiB
Go
// Copyright 2023 LiveKit, Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package signalling
|
|
|
|
import (
|
|
"github.com/livekit/protocol/livekit"
|
|
|
|
"github.com/livekit/livekit-server/pkg/routing"
|
|
"github.com/livekit/livekit-server/pkg/rtc/types"
|
|
|
|
"google.golang.org/protobuf/proto"
|
|
)
|
|
|
|
type ParticipantSignalHandler interface {
|
|
HandleMessage(msg proto.Message) error
|
|
}
|
|
|
|
type ParticipantSignaller interface {
|
|
SwapResponseSink(sink routing.MessageSink, reason types.SignallingCloseReason)
|
|
GetResponseSink() routing.MessageSink
|
|
CloseSignalConnection(reason types.SignallingCloseReason)
|
|
|
|
// HandshakePending reports whether a resumed connection is still waiting for the
|
|
// ReconnectResponse it has to open with
|
|
HandshakePending() bool
|
|
// OpenHandshake lets messages flow on a resumed connection that does not open with
|
|
// a ReconnectResponse
|
|
OpenHandshake()
|
|
|
|
WriteMessage(msg proto.Message) error
|
|
}
|
|
|
|
type ParticipantSignalling interface {
|
|
SignalJoinResponse(join *livekit.JoinResponse) proto.Message
|
|
SignalParticipantUpdate(participants []*livekit.ParticipantInfo) proto.Message
|
|
SignalSpeakerUpdate(speakers []*livekit.SpeakerInfo) proto.Message
|
|
SignalRoomUpdate(room *livekit.Room) proto.Message
|
|
SignalConnectionQualityUpdate(connectionQuality *livekit.ConnectionQualityUpdate) proto.Message
|
|
SignalRefreshToken(token string) proto.Message
|
|
SignalRequestResponse(requestResponse *livekit.RequestResponse) proto.Message
|
|
SignalRoomMovedResponse(roomMoved *livekit.RoomMovedResponse) proto.Message
|
|
SignalReconnectResponse(reconnect *livekit.ReconnectResponse) proto.Message
|
|
SignalICECandidate(trickle *livekit.TrickleRequest) proto.Message
|
|
SignalTrackMuted(mute *livekit.MuteTrackRequest) proto.Message
|
|
SignalTrackPublished(trackPublished *livekit.TrackPublishedResponse) proto.Message
|
|
SignalTrackUnpublished(trackUnpublished *livekit.TrackUnpublishedResponse) proto.Message
|
|
SignalTrackSubscribed(trackSubscribed *livekit.TrackSubscribed) proto.Message
|
|
SignalLeaveRequest(leave *livekit.LeaveRequest) proto.Message
|
|
SignalSdpAnswer(answer *livekit.SessionDescription) proto.Message
|
|
SignalSdpOffer(offer *livekit.SessionDescription) proto.Message
|
|
SignalStreamStateUpdate(streamStateUpdate *livekit.StreamStateUpdate) proto.Message
|
|
SignalSubscribedQualityUpdate(subscribedQualityUpdate *livekit.SubscribedQualityUpdate) proto.Message
|
|
SignalSubscriptionResponse(subscriptionResponse *livekit.SubscriptionResponse) proto.Message
|
|
SignalSubscriptionPermissionUpdate(subscriptionPermissionUpdate *livekit.SubscriptionPermissionUpdate) proto.Message
|
|
SignalMediaSectionsRequirement(mediaSectionsRequirement *livekit.MediaSectionsRequirement) proto.Message
|
|
SignalSubscribedAudioCodecUpdate(subscribedAudioCodecUpdate *livekit.SubscribedAudioCodecUpdate) proto.Message
|
|
SignalPublishDataTrackResponse(publishDataTrackResponse *livekit.PublishDataTrackResponse) proto.Message
|
|
SignalUnpublishDataTrackResponse(unpublishDataTrackResponse *livekit.UnpublishDataTrackResponse) proto.Message
|
|
SignalDataTrackSubscriberHandles(dataTrackSubscriberHandles *livekit.DataTrackSubscriberHandles) proto.Message
|
|
SignalStoreDataBlobResponse(storeDataBlobResponse *livekit.StoreDataBlobResponse) proto.Message
|
|
SignalGetDataBlobResponse(getDataBlobResponse *livekit.GetDataBlobResponse) proto.Message
|
|
}
|