From 647b5a79acd31f8bb123ee5e425bcc359d8ea964 Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Tue, 5 May 2026 20:27:13 +0100 Subject: [PATCH] Revert "WIP disable caching in release workflows" This reverts commit 72e5ae40b08e3c110462c2ed0d3ea68763442b3e. Let's do this in a follow-up PR. --- .github/workflows/ci.yaml | 9 --------- .github/workflows/coverage.yaml | 5 +---- .github/workflows/release-branch.yaml | 3 --- .github/workflows/translations-upload.yaml | 3 --- 4 files changed, 1 insertion(+), 19 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 834cd6d0d..2667807ce 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -123,9 +123,6 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: 24 - # Disable caching in release workflows. - # As advised by https://docs.zizmor.sh/audits/#cache-poisoning. - package-manager-cache: ${{ github.event_name != 'release' && github.event_name != 'workflow_dispatch' }} - name: Install Node dependencies working-directory: ./frontend @@ -196,9 +193,6 @@ jobs: rustup default stable - name: Setup sccache - # Disable caching in release workflows. - # As advised by https://docs.zizmor.sh/audits/#cache-poisoning. - if: github.event_name != 'release' && github.event_name != 'workflow_dispatch' uses: mozilla-actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad # v0.0.9 - uses: ./.github/actions/build-frontend @@ -243,9 +237,6 @@ jobs: - uses: ./.github/actions/build-policies - name: Setup sccache - # Disable caching in release workflows. - # As advised by https://docs.zizmor.sh/audits/#cache-poisoning. - if: github.event_name != 'release' && github.event_name != 'workflow_dispatch' uses: mozilla-actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad # v0.0.9 - name: Run clippy diff --git a/.github/workflows/coverage.yaml b/.github/workflows/coverage.yaml index 744f8eaba..784c3836d 100644 --- a/.github/workflows/coverage.yaml +++ b/.github/workflows/coverage.yaml @@ -114,10 +114,7 @@ jobs: # See https://github.com/rust-lang/rust/issues/85658 for stability tracking issue. run: rustup toolchain install stable --profile minimal --component llvm-tools-preview - - name: Setup sccache (not used on release runs) - # Disable caching in release workflows. - # As advised by https://docs.zizmor.sh/audits/#cache-poisoning. - if: github.event_name != 'release' && github.event_name != 'workflow_dispatch' + - name: Setup sccache uses: mozilla-actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad # v0.0.9 - name: Install grcov diff --git a/.github/workflows/release-branch.yaml b/.github/workflows/release-branch.yaml index e54b3b5eb..b19eaa469 100644 --- a/.github/workflows/release-branch.yaml +++ b/.github/workflows/release-branch.yaml @@ -72,9 +72,6 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: 24 - # Disable caching in release workflows. - # As advised by https://docs.zizmor.sh/audits/#cache-poisoning. - package-manager-cache: false - name: Install Localazy CLI run: npm install -g @localazy/cli diff --git a/.github/workflows/translations-upload.yaml b/.github/workflows/translations-upload.yaml index 6b83722b8..a1de3381a 100644 --- a/.github/workflows/translations-upload.yaml +++ b/.github/workflows/translations-upload.yaml @@ -26,9 +26,6 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: 24 - # Disable caching in release workflows. - # As advised by https://docs.zizmor.sh/audits/#cache-poisoning. - package-manager-cache: false - name: Install Localazy CLI run: npm install -g @localazy/cli