From 2196102eaebd78d9f8d07e4ce7692ac08be1377d Mon Sep 17 00:00:00 2001 From: Kpa-clawbot Date: Fri, 29 May 2026 10:01:00 -0700 Subject: [PATCH] test(channels): skip processWSBatch-explicit-sender step pending #1498 root-cause (#1502) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Master CI failing across all recent PRs due to this single test. The #1499 find-by-hash fix didn't resolve it — root cause is deeper than the index-vs-hash race (possibly closure staleness on `_channelsProcessWSBatchForTest` vs `_channelsGetStateForTest`). Skipping to unblock master per operator directive. Filed #1498 for proper diagnosis with CDP repro. Co-authored-by: mc-bot --- test-channels-ws-batch-e2e.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/test-channels-ws-batch-e2e.js b/test-channels-ws-batch-e2e.js index c5077d89..8f2c1c14 100644 --- a/test-channels-ws-batch-e2e.js +++ b/test-channels-ws-batch-e2e.js @@ -18,11 +18,15 @@ const { chromium } = require('playwright'); const BASE = process.env.BASE_URL || 'http://localhost:13581'; -let passed = 0, failed = 0; +let passed = 0, failed = 0, skipped = 0; async function step(name, fn) { try { await fn(); passed++; console.log(' ✓ ' + name); } catch (e) { failed++; console.error(' ✗ ' + name + ': ' + e.message); } } +step.skip = function (name, _fn) { + skipped++; + console.log(' ⊘ ' + name + ' (skipped)'); +}; function assert(c, m) { if (!c) throw new Error(m || 'assertion failed'); } (async () => { @@ -53,7 +57,10 @@ function assert(c, m) { if (!c) throw new Error(m || 'assertion failed'); } return t && /—/.test(t.textContent); }, { timeout: 5000 }); - await step('processWSBatch with explicit sender appends to messages', async () => { + // #1498: this test is genuinely flaky on master CI — closure-over-stale-messages + // hypothesis isn't yet root-caused. Skipping to unblock master while the real + // diagnosis is pending. Re-enable by changing step.skip back to step. + await step.skip('processWSBatch with explicit sender appends to messages', async () => { await page.evaluate((h) => { window._channelsProcessWSBatchForTest([{ type: 'message',