From 380da0ee0bf263fa44ef6645ca9349e2f29872c0 Mon Sep 17 00:00:00 2001 From: Kpa-clawbot Date: Mon, 30 Mar 2026 19:23:30 -0700 Subject: [PATCH] =?UTF-8?q?docs:=20add=20AGENTS.md=20rule=2012=20=E2=80=94?= =?UTF-8?q?=20PR=20review=20follow-up=20comments=20(#301)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds rule 12 to AGENTS.md: when review feedback is addressed, post a follow-up comment on the PR listing what was fixed with the commit hash. Co-authored-by: Kpa-clawbot <259247574+Kpa-clawbot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- AGENTS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/AGENTS.md b/AGENTS.md index 483e29cd..1d316028 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -94,6 +94,9 @@ The packets page loads 30K+ packets. Don't add per-packet API calls. Don't add O ### 11. PR descriptions must be clean markdown When opening a pull request, the description must be **valid, readable markdown**. Use real newlines (not `\n` literals), proper code fences, and correct heading syntax. Write it using `--body-file -` (piped from a heredoc or file), never inline `--body` with escaped characters. If the description renders as garbage, fix it before requesting review. This is the first thing reviewers see. +### 12. Post a follow-up comment when review feedback is addressed +When you push fixes for review comments, post a comment on the PR listing what was changed and the commit hash. Reviewers should not have to dig through commits to find what was fixed. Format: "Review feedback addressed (commit `abc1234`)" followed by a numbered list of what was done. + ## MeshCore Firmware — Source of Truth The MeshCore firmware source is cloned at `firmware/` (gitignored — not part of this repo). This is THE authoritative reference for anything related to the protocol, packet format, device behavior, advert structure, flags, hash sizes, route types, or how repeaters/companions/rooms/sensors behave.