From 827b2a3b8a7b6059c84924515ebdde15312e7cb1 Mon Sep 17 00:00:00 2001
From: efiten <erwin.fiten@gmail.com>
Date: Sat, 28 Mar 2026 17:20:25 +0100
Subject: [PATCH] fix: HB column always shows 1-4, remove null fallback

Every packet has a path byte so hash bytes is always 1-4.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 public/packets.js | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/public/packets.js b/public/packets.js
index ac4bf90a..68a2daeb 100644
--- a/public/packets.js
+++ b/public/packets.js
@@ -1021,8 +1021,7 @@
         const groupTypeName = payloadTypeName(p.payload_type);
         const groupTypeClass = payloadTypeColor(p.payload_type);
         const groupSize = p.raw_hex ? Math.floor(p.raw_hex.length / 2) : 0;
-        const groupRawPathByte = p.raw_hex ? parseInt(p.raw_hex.slice(2, 4), 16) : NaN;
-        const groupHashBytes = isNaN(groupRawPathByte) ? null : ((groupRawPathByte >> 6) + 1);
+        const groupHashBytes = ((parseInt(p.raw_hex?.slice(2, 4), 16) || 0) >> 6) + 1;
         const isSingle = p.count <= 1;
         html += `<tr class="${isSingle ? '' : 'group-header'} ${isExpanded ? 'expanded' : ''}" data-hash="${p.hash}" data-action="${isSingle ? 'select-hash' : 'toggle-select'}" data-value="${p.hash}" tabindex="0" role="row">
           <td style="width:28px;text-align:center;cursor:pointer">${isSingle ? '' : (isExpanded ? '▼' : '▶')}</td>
@@ -1030,7 +1029,7 @@
           <td class="col-time">${timeAgo(p.latest)}</td>
           <td class="mono col-hash">${truncate(p.hash || '—', 8)}</td>
           <td class="col-size">${groupSize ? groupSize + 'B' : '—'}</td>
-          <td class="col-hashsize mono">${groupHashBytes !== null ? groupHashBytes : '—'}</td>
+          <td class="col-hashsize mono">${groupHashBytes}</td>
           <td class="col-type">${p.payload_type != null ? `<span class="badge badge-${groupTypeClass}">${groupTypeName}</span>` : '—'}</td>
           <td class="col-observer">${isSingle ? truncate(obsName(headerObserverId), 16) : truncate(obsName(headerObserverId), 10) + (p.observer_count > 1 ? ' +' + (p.observer_count - 1) : '')}</td>
           <td class="col-path"><span class="path-hops">${groupPathStr}</span></td>
@@ -1049,8 +1048,7 @@
             const typeName = payloadTypeName(c.payload_type);
             const typeClass = payloadTypeColor(c.payload_type);
             const size = c.raw_hex ? Math.floor(c.raw_hex.length / 2) : 0;
-            const childRawPathByte = c.raw_hex ? parseInt(c.raw_hex.slice(2, 4), 16) : NaN;
-            const childHashBytes = isNaN(childRawPathByte) ? null : ((childRawPathByte >> 6) + 1);
+            const childHashBytes = ((parseInt(c.raw_hex?.slice(2, 4), 16) || 0) >> 6) + 1;
             const childRegion = c.observer_id ? (observers.find(o => o.id === c.observer_id)?.iata || '') : '';
             let childPath = [];
             try { childPath = JSON.parse(c.path_json || '[]'); } catch {}
@@ -1060,7 +1058,7 @@
               <td class="col-time">${timeAgo(c.timestamp)}</td>
               <td class="mono col-hash">${truncate(c.hash || '', 8)}</td>
               <td class="col-size">${size}B</td>
-              <td class="col-hashsize mono">${childHashBytes !== null ? childHashBytes : '—'}</td>
+              <td class="col-hashsize mono">${childHashBytes}</td>
               <td class="col-type"><span class="badge badge-${typeClass}">${typeName}</span></td>
               <td class="col-observer">${truncate(obsName(c.observer_id), 16)}</td>
               <td class="col-path"><span class="path-hops">${childPathStr}</span></td>
@@ -1083,8 +1081,7 @@
       const typeName = payloadTypeName(p.payload_type);
       const typeClass = payloadTypeColor(p.payload_type);
       const size = p.raw_hex ? Math.floor(p.raw_hex.length / 2) : 0;
-      const rawPathByte = p.raw_hex ? parseInt(p.raw_hex.slice(2, 4), 16) : NaN;
-      const hashBytes = isNaN(rawPathByte) ? null : ((rawPathByte >> 6) + 1);
+      const hashBytes = ((parseInt(p.raw_hex?.slice(2, 4), 16) || 0) >> 6) + 1;
       const pathStr = renderPath(pathHops, p.observer_id);      const detail = getDetailPreview(decoded);
 
       return `<tr data-id="${p.id}" data-hash="${p.hash || ''}" data-action="select-hash" data-value="${p.hash || p.id}" tabindex="0" role="row" class="${selectedId === p.id ? 'selected' : ''}">
@@ -1092,7 +1089,7 @@
         <td class="col-time">${timeAgo(p.timestamp)}</td>
         <td class="mono col-hash">${truncate(p.hash || String(p.id), 8)}</td>
         <td class="col-size">${size}B</td>
-        <td class="col-hashsize mono">${hashBytes !== null ? hashBytes : '—'}</td>
+        <td class="col-hashsize mono">${hashBytes}</td>
         <td class="col-type"><span class="badge badge-${typeClass}">${typeName}</span></td>
         <td class="col-observer">${truncate(obsName(p.observer_id), 16)}</td>
         <td class="col-path"><span class="path-hops">${pathStr}</span></td>