From a89b577ce5cb58dbfe5675e58b563d9bc50a9c21 Mon Sep 17 00:00:00 2001
From: you <you@example.com>
Date: Thu, 2 Apr 2026 23:44:50 +0000
Subject: [PATCH] fix: use CSS variables for section colors, fix overlap test,
 remove redundant repeatHex

- style.css: section-row rules now use var(--section-*-bg) instead of
  hardcoded rgba() values, completing the review feedback fix
- decoder_test.go: overlap check condition was too strict (required both
  <= AND <, effectively only catching <). Fixed to just <=
- decoder_test.go: replaced custom repeatHex() with strings.Repeat()
  from stdlib (DRY)
---
 cmd/server/decoder_test.go | 22 ++++++++--------------
 public/style.css           |  8 ++++----
 2 files changed, 12 insertions(+), 18 deletions(-)

diff --git a/cmd/server/decoder_test.go b/cmd/server/decoder_test.go
index dbc100b3..31c8afa1 100644
--- a/cmd/server/decoder_test.go
+++ b/cmd/server/decoder_test.go
@@ -160,9 +160,9 @@ func TestBuildBreakdown_AdvertBasic(t *testing.T) {
 	// PathByte 0x01: 1 hop, 1-byte hash
 	// PathHop: AA
 	// Payload: 100 bytes (PubKey32 + Timestamp4 + Signature64) + Flags=0x02 (repeater, no extras)
-	pubkey := repeatHex("AB", 32)
+	pubkey := strings.Repeat("AB", 32)
 	ts := "00000000" // 4 bytes
-	sig := repeatHex("CD", 64)
+	sig := strings.Repeat("CD", 64)
 	flags := "02"
 	hex := "1101AA" + pubkey + ts + sig + flags
 	b := BuildBreakdown(hex)
@@ -177,9 +177,9 @@ func TestBuildBreakdown_AdvertBasic(t *testing.T) {
 
 func TestBuildBreakdown_AdvertWithLocation(t *testing.T) {
 	// flags=0x12: hasLocation bit set
-	pubkey := repeatHex("00", 32)
+	pubkey := strings.Repeat("00", 32)
 	ts := "00000000"
-	sig := repeatHex("00", 64)
+	sig := strings.Repeat("00", 64)
 	flags := "12" // 0x10 = hasLocation
 	latBytes := "00000000"
 	lonBytes := "00000000"
@@ -191,9 +191,9 @@ func TestBuildBreakdown_AdvertWithLocation(t *testing.T) {
 
 func TestBuildBreakdown_AdvertWithName(t *testing.T) {
 	// flags=0x82: hasName bit set
-	pubkey := repeatHex("00", 32)
+	pubkey := strings.Repeat("00", 32)
 	ts := "00000000"
-	sig := repeatHex("00", 64)
+	sig := strings.Repeat("00", 64)
 	flags := "82" // 0x80 = hasName
 	name := "4E6F6465" // "Node" in hex
 	hex := "1101AA" + pubkey + ts + sig + flags + name
@@ -236,13 +236,7 @@ func assertRange(t *testing.T, ranges []HexRange, label string, wantStart, wantE
 	t.Errorf("range %q not found in %v", label, rangeLabels(ranges))
 }
 
-func repeatHex(byteHex string, n int) string {
-	s := ""
-	for i := 0; i < n; i++ {
-		s += byteHex
-	}
-	return s
-}
+
 
 // --- BuildBreakdown tests (PR #500 review feedback) ---
 
@@ -307,7 +301,7 @@ func TestBuildBreakdown_AdvertAllFlags(t *testing.T) {
 	}
 	// Verify no overlaps
 	for i := 1; i < len(bd.Ranges); i++ {
-		if bd.Ranges[i].Start <= bd.Ranges[i-1].End && bd.Ranges[i].Start < bd.Ranges[i-1].End {
+		if bd.Ranges[i].Start <= bd.Ranges[i-1].End {
 			t.Errorf("overlap: %s [%d-%d] and %s [%d-%d]",
 				bd.Ranges[i-1].Label, bd.Ranges[i-1].Start, bd.Ranges[i-1].End,
 				bd.Ranges[i].Label, bd.Ranges[i].Start, bd.Ranges[i].End)
diff --git a/public/style.css b/public/style.css
index d4ae7abc..035fc81d 100644
--- a/public/style.css
+++ b/public/style.css
@@ -387,10 +387,10 @@ a:focus-visible, button:focus-visible, input:focus-visible, select:focus-visible
   background: var(--section-bg, #eef2ff); font-weight: 700; font-size: 11px;
   text-transform: uppercase; letter-spacing: .5px; color: var(--accent);
 }
-.field-table .section-header td  { background: rgba(243,139,168,0.18); }
-.field-table .section-transport td { background: rgba(137,180,250,0.18); }
-.field-table .section-path td    { background: rgba(166,227,161,0.18); }
-.field-table .section-payload td { background: rgba(249,226,175,0.18); }
+.field-table .section-header td  { background: var(--section-header-bg); }
+.field-table .section-transport td { background: var(--section-transport-bg); }
+.field-table .section-path td    { background: var(--section-path-bg); }
+.field-table .section-payload td { background: var(--section-payload-bg); }
 
 /* === Path display === */
 .path-hops {