From ba68069c23fc9835fdcc2123f2d42506e5e514f5 Mon Sep 17 00:00:00 2001 From: Kpa-clawbot Date: Mon, 6 Jul 2026 20:13:04 -0700 Subject: [PATCH] fix(#1825): add cross-nav links between observer and node detail pages (#1826) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds cross-navigation between the observer detail page and the node detail page for the same pubkey (community feature request from cwichura). **Changes** - `public/observer-detail.js`: new `View node detail →` inside `.page-header`, next to the `

`. - `public/nodes.js`: new sibling `Observer →` in the same button row as the `Analytics` / `Reach` anchors on the full node detail page. Uses the existing `ph-eye` phosphor icon. **Test — TDD red→green** - Red commit: `8c2315e1` (`test(#1825): red — observer<->node cross-link anchors missing`) — 4/4 assertions fail on master; CI RED. - Green commit: `ff8f6ed7` — minimum production change; 4/4 assertions pass locally. Test file: `test-issue-1825-observer-node-cross-links.js` — static-source DOM-grep style consistent with the neighbouring `test-issue-1789-observer-firmware-cols.js` / `test-observers-headings.js` pattern. It asserts: 1. observer-detail.js contains `href="#/nodes/${encodeURIComponent(currentId)}"`. 2. That anchor sits inside the `.page-header` block. 3. nodes.js contains `href="#/observers/${encodeURIComponent(n.public_key)}"`. 4. That anchor is a sibling of the analytics/reach anchors in the same flex row. **Notes** - Pubkeys are `encodeURIComponent`-escaped on both sides (defense-in-depth; MeshCore pubkeys are hex only). - No API changes. No CSS changes. No new dependencies. Fixes #1825 --------- Co-authored-by: meshcore-bot --- public/nodes.js | 1 + public/observer-detail.js | 1 + test-issue-1825-observer-node-cross-links.js | 74 ++++++++++++++++++++ 3 files changed, 76 insertions(+) create mode 100644 test-issue-1825-observer-node-cross-links.js diff --git a/public/nodes.js b/public/nodes.js index 7d1253d1..fd6aab87 100644 --- a/public/nodes.js +++ b/public/nodes.js @@ -617,6 +617,7 @@ Analytics Reach + Observer → diff --git a/public/observer-detail.js b/public/observer-detail.js index e00c740f..addcc3d1 100644 --- a/public/observer-detail.js +++ b/public/observer-detail.js @@ -81,6 +81,7 @@ window.ObserverDetailNaiveBanner = {
←

Observer Detail

+ View node detail →
diff --git a/test-issue-1825-observer-node-cross-links.js b/test-issue-1825-observer-node-cross-links.js new file mode 100644 index 00000000..bfee38fe --- /dev/null +++ b/test-issue-1825-observer-node-cross-links.js @@ -0,0 +1,74 @@ +/* test-issue-1825-observer-node-cross-links.js — Issue #1825 regression test. + * + * Asserts cross-navigation links exist between the observer detail page and + * the node detail page for the same pubkey: + * + * - public/observer-detail.js renders an anchor `href="#/nodes/${encodeURIComponent(currentId)}"` + * inside the .page-header (near the `

`). + * - public/nodes.js renders an anchor `href="#/observers/${encodeURIComponent(n.public_key)}"` + * in the same button row as the analytics/reach anchors on the full node + * detail page. + * + * Static-source test (grep the file text). No server, no DOM. + */ +'use strict'; + +const fs = require('fs'); +const path = require('path'); +const assert = require('assert'); + +let passed = 0, failed = 0; +function test(name, fn) { + try { fn(); passed++; console.log(` \u2713 ${name}`); } + catch (e) { failed++; console.log(` \u2717 ${name}\n ${e.message}`); } +} + +console.log('\u2500\u2500 Observer <-> Node cross-links (#1825) \u2500\u2500'); + +const obsSrc = fs.readFileSync(path.join(__dirname, 'public', 'observer-detail.js'), 'utf8'); +const nodesSrc = fs.readFileSync(path.join(__dirname, 'public', 'nodes.js'), 'utf8'); + +test('observer-detail.js links to #/nodes/${encodeURIComponent(currentId)}', () => { + assert.ok( + /href="#\/nodes\/\$\{encodeURIComponent\(currentId\)\}"/.test(obsSrc), + 'expected anchor href="#/nodes/${encodeURIComponent(currentId)}" in observer-detail.js' + ); +}); + +test('observer-detail.js cross-link sits inside the .page-header block', () => { + const m = obsSrc.match(/class="page-header"[\s\S]*?<\/div>/); + assert.ok(m, '.page-header block not found in observer-detail.js'); + assert.ok( + /href="#\/nodes\/\$\{encodeURIComponent\(currentId\)\}"/.test(m[0]), + 'observer -> node cross-link is not inside the .page-header block' + ); +}); + +test('nodes.js links to #/observers/${encodeURIComponent(n.public_key)}', () => { + assert.ok( + /href="#\/observers\/\$\{encodeURIComponent\(n\.public_key\)\}"/.test(nodesSrc), + 'expected anchor href="#/observers/${encodeURIComponent(n.public_key)}" in nodes.js' + ); +}); + +test('nodes.js Observer link is a sibling of the analytics/reach anchors', () => { + // Find the button row that contains both analytics and reach anchors and + // assert it now also contains the observers anchor. + const rowRe = /]*display:flex[^>]*flex-wrap:wrap[^>]*>[\s\S]*?<\/div>/g; + let found = false; + let m; + while ((m = rowRe.exec(nodesSrc)) !== null) { + const row = m[0]; + if (/href="#\/nodes\/\$\{encodeURIComponent\(n\.public_key\)\}\/analytics"/.test(row) && + /href="#\/nodes\/\$\{encodeURIComponent\(n\.public_key\)\}\/reach"/.test(row)) { + if (/href="#\/observers\/\$\{encodeURIComponent\(n\.public_key\)\}"/.test(row)) { + found = true; + break; + } + } + } + assert.ok(found, 'observer anchor not found in the same button row as analytics/reach anchors'); +}); + +console.log(`\n${passed} passed, ${failed} failed`); +process.exit(failed ? 1 : 0);