2 Commits

Author	SHA1	Message	Date
Kpa-clawbot	353c5264ad	fix(#1197): plumb hop-context + observation-count tiebreak to disambiguator (#1198) ... Red commit: 5ffdf6b07c (CI run: pending — see PR Checks tab) Fixes #1197 ## What this changes Two-part fix matching the issue spec: 1. **Tier-3/4 tiebreak by observation count, not slice order** (`store.go` resolver + `getAllNodes`). - Plumbs `nodes.advert_count` → new `nodeInfo.ObservationCount` field via the existing `getAllNodes` query (graceful fallback when the column is absent on legacy DBs). - `resolveWithContext` tier 3 (GPS preference) now picks the GPS-having candidate with the highest observation count. - Tier 4 (no-GPS fallback) likewise picks by observation count instead of `candidates[0]`. 2. **Plumb hop-context to the resolver** at all four call sites called out in the issue. - New `buildHopContextPubkeys(tx, pm)` collects: sender pubkey from `tx.DecodedJSON.pubKey`, observer pubkey from `tx.ObserverID`, plus unambiguous-prefix anchors (single-candidate prefixes in the path). - Wired into the four sites: broadcast distance compute (~1707), recompute-on-path-change (~2944), `buildDistanceIndex` (~2982), `computeAnalyticsTopology` (~5125). - Per-tx hop caches were moved inside the per-tx loop on the distance paths since context now varies per tx (was safely shared before only because every caller passed `nil`). - `computeAnalyticsTopology` aggregates context across the analytics scan rather than per-tx because `resolveHop` is called outside the scan loop downstream. ## Tests Red→green pairs visible in the commit history: - Pair A — tier-3 observation-count tiebreak (`TestResolveWithContext_Tier3_PicksHigherObservationCount`). - Pair B — context plumbing (`TestBuildHopContextPubkeys_IncludesSenderAndUnambiguousAnchors`) + tier-2 geo-proximity (`TestResolveWithContext_Tier2_PicksGeographicallyCloserCandidate`). `go test ./...` green on `cmd/server`. ## Out of scope (per issue) 300 km hop cap, API confidence/alternative-count surfacing, firmware prefix-collision space — all explicitly excluded in #1197. --------- Co-authored-by: openclaw-bot <bot@openclaw.local> Co-authored-by: corescope-bot <bot@corescope.local> Co-authored-by: Kpa-clawbot <bot@kpa-clawbot.local>	2026-05-15 09:16:39 -07:00
Kpa-clawbot	58f791266d	feat: affinity debugging tools (#482) — milestone 6 (#521) ... ## Summary Milestone 6 of #482: Observability & Debugging tools for the neighbor affinity system. These tools exist because someone will need them at 3 AM when "Show Neighbors is showing the wrong node for C0DE" and they have 5 minutes to diagnose it. ## Changes ### 1. Debug API — `GET /api/debug/affinity` - Full graph state dump: all edges with weights, observation counts, last-seen timestamps - Per-prefix resolution log with disambiguation reasoning (Jaccard scores, ratios, thresholds) - Query params: `?prefix=C0DE` filter to specific prefix, `?node=<pubkey>` for specific node's edges - Protected by API key (same auth as `/api/admin/prune`) - Response includes: edge count, node count, cache age, last rebuild time ### 2. Debug Overlay on Map - Toggle-able checkbox "🔍 Affinity Debug" in map controls - Draws lines between nodes showing affinity edges with color coding: - Green = high confidence (score ≥ 0.6) - Yellow = medium (0.3–0.6) - Red = ambiguous (< 0.3) - Line thickness proportional to weight, dashed for ambiguous - Unresolved prefixes shown as ❓ markers - Click edge → popup with observation count, last seen, score, observers - Hidden behind `debugAffinity` config flag or `localStorage.setItem('meshcore-affinity-debug', 'true')` ### 3. Per-Node Debug Panel - Expandable "🔍 Affinity Debug" section in node detail page (collapsed by default) - Shows: neighbor edges table with scores, prefix resolutions with reasoning trace - Candidates table with Jaccard scores, highlighting the chosen candidate - Graph-level stats summary ### 4. Server-Side Structured Logging - Integrated into `disambiguate()` — logs every resolution decision during graph build - Format: `[affinity] resolve C0DE: c0dedad4 score=47 Jaccard=0.82 vs c0dedad9 score=3 Jaccard=0.11 → neighbor_affinity (ratio 15.7×)` - Logs ambiguous decisions: `scores too close (12 vs 9, ratio 1.3×) → ambiguous` - Gated by `debugAffinity` config flag ### 5. Dashboard Stats Widget - Added to analytics overview tab when debug mode is enabled - Metrics: total edges/nodes, resolved/ambiguous counts (%), avg confidence, cold-start coverage, cache age, last rebuild ## Files Changed - `cmd/server/neighbor_debug.go` — new: debug API handler, resolution builder, cold-start coverage - `cmd/server/neighbor_debug_test.go` — new: 7 tests for debug API - `cmd/server/neighbor_graph.go` — added structured logging to disambiguate(), `logFn` field, `BuildFromStoreWithLog` - `cmd/server/neighbor_api.go` — pass debug flag through `BuildFromStoreWithLog` - `cmd/server/config.go` — added `DebugAffinity` config field - `cmd/server/routes.go` — registered `/api/debug/affinity` route, exposed `debugAffinity` in client config - `cmd/server/types.go` — added `DebugAffinity` to `ClientConfigResponse` - `public/map.js` — affinity debug overlay layer with edge visualization - `public/nodes.js` — per-node affinity debug panel - `public/analytics.js` — dashboard stats widget - `test-e2e-playwright.js` — 3 Playwright tests for debug UI ## Tests - ✅ 7 Go unit tests (API shape, prefix/node filters, auth, structured logging, cold-start coverage) - ✅ 3 Playwright E2E tests (overlay checkbox, toggle without crash, panel expansion) - ✅ All existing tests pass (`go test ./cmd/server/... -count=1`) Part of #482 --------- Co-authored-by: you <you@example.com>	2026-04-02 23:45:03 -07:00