Commit Graph
1 Commits
Author SHA1 Message Date
d72ab69f87 fix(#1639): observers table — wire TableSort with numeric/time column types (#1641)
## Summary

Wires the shared `TableSort` helper (already used by the nodes table,
#679) into the observers table at `#/observers`. Adds `data-sort-key` /
`data-type` attrs on every `<th>`, `data-value` on every `<td>` with the
raw sortable value (epoch-ms for times, integers for counts, abs-seconds
for clock skew, derived health rank for the status dot), and initializes
`TableSort` at the end of `render()` — after the new `tbody` is in the
DOM — to avoid the #679 init race on async refresh.

## Before / after

- **Before:** clicking any column header on `#/observers` does nothing —
bare `<th>` cells, no click handlers, no `TableSort.init` call (per
#1639 repro).
- **After:** clicking a header toggles asc/desc with `aria-sort`
indicator + ▲/▼ glyph. Numeric columns (Packet Health, Total Packets,
Packets/Hour, Clock Offset, Uptime) sort numerically. Time columns (Last
Status, Last Packet) sort by ISO timestamp, not the `"23d ago"` display
string. Active column + direction persisted in `localStorage` under
`meshcore-observers-sort`. Default sort: Last Status desc (matches
existing default ordering).

## Test plan

- TDD red commit `0dcd5304` — fails on assertion `Total Packets <th>
must carry data-sort-key="packet_count"` against master.
- Green commit `d4f0376f` — both assertions pass.
- E2E assertion added: `test-issue-1639-observers-sort-e2e.js:46`
(header has `data-sort-key`+`data-type`) and `:62` (click reorders rows
numerically desc).
- Local commands run from the worktree:
- `cd cmd/migrate && go build -o ../../cs-migrate-1639 .` →
`./cs-migrate-1639 -db test-fixtures/e2e-fixture.db`
- `cd cmd/server && go build -o ../../cs-server-1639 .` → run on port
13581 against the fixture DB
- `CHROMIUM_PATH=/usr/bin/chromium BASE_URL=http://localhost:13581 node
test-issue-1639-observers-sort-e2e.js` → ✅ both tests pass
- `node test-observers-headings.js` (#1039 regression) → ✅ still passes
- Browser verified: headless chromium against the local fixture server.
Clicked Total Packets header three times: first click →
`aria-sort=descending` + ▼ glyph + rows ordered 139,261 → 5,791. Second
click → `aria-sort=ascending` + ▲ glyph. Third click → back to
descending. tbody re-renders correctly after the 30s `loadObservers`
auto-refresh (no init race — the new TableSort controller binds to the
fresh header).
- pr-preflight: clean (all hard gates + warnings pass against
`origin/master`).

## Files changed

- `public/observers.js` — wire TableSort, add
`data-sort-key`/`data-type`/`data-value`, init after render
- `test-issue-1639-observers-sort-e2e.js` — new E2E (red→green)
- `.github/workflows/deploy.yml` — run the new E2E alongside existing
playwright group

Fixes #1639

---------

Co-authored-by: openclaw-bot <bot@openclaw>
Co-authored-by: clawbot <clawbot@users.noreply.github.com>
Co-authored-by: openclaw-bot <bot@openclaw.local>
2026-06-10 11:29:57 -07:00