2 Commits

Include renames

Author	SHA1	Message	Date
Kpa-clawbot	b812a98a71	M3: emoji → Phosphor Icons — detail panes & badges (#1648) (#1651) ... Red commit: 537fbbc6b0 (CI run: https://github.com/Kpa-clawbot/CoreScope/actions?query=branch%3Afix%2F1648-m3-details-badges) Partial fix for #1648 (M3 of 6). Do NOT close the tracking issue. M3 covers detail panes, status pills, role/payload-type badges per the tracking-issue M3 checklist. Builds on M1 sprite + M2 chrome. ## Per-file swap counts | file | swaps (sprite refs) | | --- | --- | | public/home.js | 26 | | public/channels.js | 27 | | public/route-view-utils.js | 11 | | public/route-view.js | 4 | | public/app.js | 4 | | public/hop-display.js | 3 | | public/path-inspector.js | 1 | | **total** | **76** | Plus 6 new Phosphor SVG symbols vendored into `public/icons/phosphor-sprite.svg` (regular weight, alphabetical): `ph-bluetooth`, `ph-camera`, `ph-hexagon`, `ph-paper-plane-tilt`, `ph-plant`, `ph-rocket`. ## Status-token integration (design decision 3) `.status-{ok,warn,err,muted}` rules added in `public/style.css` (lines 22-35). Each threads a `--status-*` color via `color:` and Phosphor sprites inside inherit via `currentColor` — no fill colors baked into sprite refs. Verified by an emoji-scan assertion (`test-issue-1648-m3-emoji-scan.js` `assertStatusTokenCss()`) and an E2E computed-style probe. ## TDD evidence - Red commit `537fbbc6` adds the failing scan (`test-issue-1648-m3-emoji-scan.js`) alone — see branch CI history. - Green commit `4a0cd89a` implements the swaps. - Anti-tautology: reverting one sprite swap in `path-inspector.js` reproduces the assertion failure; restored. ## E2E assertions added `test-issue-1648-m3-icons-e2e.js:1-188` — Playwright behavioral checks for `/home` (welcome cards), `/channels` (sidebar + modal), `/nodes/<pk>` (detail pane), `/analytics`, `/live`, plus `.notdef` resolver and `.status-ok` computed-color probe. Registered in `.github/workflows/deploy.yml`. ## Test updates (drift) `test-frontend-helpers.js` updated 6 assertions to match sprite-rendered HTML: hop-display unreliable-badge (`#ph-warning`), `#1504` `PATH_SYMBOLS_LEGEND` (`glyph` → `glyphHtml`), `#781`/`#811` channel-lock affordance (`#ph-lock`). Pre-existing 2 `favStar` failures from M2 baseline remain unchanged (out-of-scope here). ## Out of scope (next milestones) - `public/customize.js` / `public/customize-v2.js` operator-customizable emoji config → **M5** - `cmd/server/routes.go` server-rendered onboarding config → **M6** - `public/route-view-v2.js` route-overlay glyph logic → **M4** (this PR touches only `route-view-utils.js` payload taxonomy + `route-view.js` sidebar, not the overlay)	2026-06-11 02:06:32 -07:00
4 people	d837166158	test(coverage): add Playwright E2E for channels page (#1297 B3) (#1300) ... ## #1297 B3 — Playwright E2E coverage for `public/channels.js` Pure-coverage PR. Adds five Playwright suites targeting the largest under-tested branches of `public/channels.js` (1950 LOC, was **19.9% statements** per the live coverage refinement in #1297 — the single biggest delta opportunity in the umbrella). No production code changes. ### Coverage exemption Per repo `AGENTS.md` TDD rule: this is the **net-new test coverage** case — there is no production change to gate, so a failing-then-passing red commit isn't applicable. All five suites exercise existing channels init() code paths that ship today. ### New test files | File | Scenarios exercised | | --- | --- | | `test-channels-list-render-e2e.js` | Sectioned sidebar (My Channels / Network / Encrypted) headers, encrypted collapse toggle + localStorage persistence, row badges + previews, color dot + color clear control, sidebar resize handle width persist | | `test-channels-selection-flow-e2e.js` | `selectChannel()` header update + URL replaceState, message row rendering (avatars, sender colors, packet links), node detail panel open via mouse + keyboard + close-with-focus-restore, deep-link route restoration, scroll button initial state | | `test-channels-add-modal-e2e.js` | Generate PSK Channel (key + QR + status banner + localStorage persist), Add PSK invalid hex error path, Add PSK valid hex success + close + My Channels row, Monitor Hashtag with and without leading `#`, empty-hashtag no-op, Scan QR unavailable fallback, Escape close, Remove ✕ flow | | `test-channels-share-color-e2e.js` | Share modal normal mode (dedicated `#chShareModal` with QR + Hex Key + Copy success label), Share modal error mode (`openShareModalError` when no stored key — field groups hidden), Escape close, `ChannelColorPicker.show` invocation on color-dot click, keyboard Enter on a `[data-share-channel]` span | | `test-channels-ws-batch-e2e.js` | `processWSBatch` via `_channelsProcessWSBatchForTest`: explicit-sender append, `"Sender: text"` parsing branch, packetHash dedup + observer accumulation, new-channel append (channel previously unseen), scroll-button branch when user not at bottom, region-filter exclusion code path | All five tests wired into `.github/workflows/deploy.yml` after the existing `test-channel-fluid-e2e.js` step. ### Preflight `bash ~/.openclaw/skills/pr-preflight/scripts/run-all.sh origin/master` → exit 0, all gates pass (PII, CSS vars, branch scope, etc.). Refs #1297 --------- Co-authored-by: openclaw-bot <openclaw-bot@users.noreply.github.com> Co-authored-by: openclaw-bot <bot@openclaw.local> Co-authored-by: mc-bot <bot@meshcore.local>	2026-05-29 11:46:51 +00:00