2 Commits

Author	SHA1	Message	Date
Kpa-clawbot	2beeb2b324	fix(#1199): 6 deferred quality items from PR #1198 r2 review (#1200) ... Red commit: 75563ce (CI run: pending — pushed at branch open) Follows up PR #1198 round-2 adversarial review (issue #1199). Six robustness / perf-hot-path / maintenance items, one commit per logical change. Stacked on top of `fix/issue-1197` (PR #1198) — base must move to `master` after #1198 merges. | # | Item | Commit(s) | Discipline | |---|---|---|---| | 1 | Brittle static-grep regex → go/parser AST walk in `resolve_context_callsites_test.go` | 33d80b6 (RED) → 450236d (GREEN) | red→green | | 2 | `computeAnalyticsTopology` double-pass filter → materialize `filteredTxs` once | 00005f6 | refactor | | 3 | `BenchmarkBuildAggregateHopContextPubkeys` baseline + tiny smoke test | b520048 | net-new bench/test | | 4 | `hopResolverPerTx` CONCURRENCY doc — single-goroutine invariant | 155ff07 | doc-only | | 5 | `schemaDegradationLogged` package-level `sync.Map` → PacketStore field | 75563ce (RED) → 7dbf193 (GREEN) | red→green | | 6 | `buildHopContextPubkeys` `out` slice cap hint (`make([]string, 0, 16)`) | 2040962 | refactor | Items 2 & 6 are pure refactors — no test files modified for items 2 & 6 (per AGENTS.md exemption rule). Existing tests stay green and unaltered. Item 4 is doc-only (CONCURRENCY: comment); no behavior change. Item 3 adds a bench + a smoke assertion for the aggregate helper that previously had no coverage. Local arm64 baseline: ~72ms/op, 130k allocs at 5k txs. Items 1 & 5 follow red→green: 33d80b6 demonstrates the regex blindspot via a synthetic AST-detectable input the regex misses; 75563ce demonstrates per-store log dedup leaks across instances. Both flips visible in branch history. Full `go test ./cmd/server/...` runs clean post-amend. Fixes #1199 --------- Co-authored-by: openclaw-bot <bot@openclaw.local>	2026-05-15 16:21:14 +00:00
Kpa-clawbot	353c5264ad	fix(#1197): plumb hop-context + observation-count tiebreak to disambiguator (#1198) ... Red commit: 5ffdf6b07c (CI run: pending — see PR Checks tab) Fixes #1197 ## What this changes Two-part fix matching the issue spec: 1. **Tier-3/4 tiebreak by observation count, not slice order** (`store.go` resolver + `getAllNodes`). - Plumbs `nodes.advert_count` → new `nodeInfo.ObservationCount` field via the existing `getAllNodes` query (graceful fallback when the column is absent on legacy DBs). - `resolveWithContext` tier 3 (GPS preference) now picks the GPS-having candidate with the highest observation count. - Tier 4 (no-GPS fallback) likewise picks by observation count instead of `candidates[0]`. 2. **Plumb hop-context to the resolver** at all four call sites called out in the issue. - New `buildHopContextPubkeys(tx, pm)` collects: sender pubkey from `tx.DecodedJSON.pubKey`, observer pubkey from `tx.ObserverID`, plus unambiguous-prefix anchors (single-candidate prefixes in the path). - Wired into the four sites: broadcast distance compute (~1707), recompute-on-path-change (~2944), `buildDistanceIndex` (~2982), `computeAnalyticsTopology` (~5125). - Per-tx hop caches were moved inside the per-tx loop on the distance paths since context now varies per tx (was safely shared before only because every caller passed `nil`). - `computeAnalyticsTopology` aggregates context across the analytics scan rather than per-tx because `resolveHop` is called outside the scan loop downstream. ## Tests Red→green pairs visible in the commit history: - Pair A — tier-3 observation-count tiebreak (`TestResolveWithContext_Tier3_PicksHigherObservationCount`). - Pair B — context plumbing (`TestBuildHopContextPubkeys_IncludesSenderAndUnambiguousAnchors`) + tier-2 geo-proximity (`TestResolveWithContext_Tier2_PicksGeographicallyCloserCandidate`). `go test ./...` green on `cmd/server`. ## Out of scope (per issue) 300 km hop cap, API confidence/alternative-count surfacing, firmware prefix-collision space — all explicitly excluded in #1197. --------- Co-authored-by: openclaw-bot <bot@openclaw.local> Co-authored-by: corescope-bot <bot@corescope.local> Co-authored-by: Kpa-clawbot <bot@kpa-clawbot.local>	2026-05-15 09:16:39 -07:00