mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-09-01 22:29:12 +00:00
Kpa-clawbotandyou
ad97c0fdd1
## Summary Fixes #504 — Expanding a packet in the packets UI showed the same path on every observation instead of each observation's unique path. ## Root Cause PR #400 (fixing #387) added caching of `JSON.parse` results as `_parsedPath` and `_parsedDecoded` properties on packet objects. When observation packets are created via object spread (`{...parentPacket, ...obs}`), these cache properties are copied from the parent. Subsequent calls to `getParsedPath(obsPacket)` hit the stale cache and return the parent's path, ignoring the observation's own `path_json`. ## Fix After every object spread that creates an observation packet from a parent packet, delete the cache properties so they get re-parsed from the observation's own data: ```js delete obsPacket._parsedPath; delete obsPacket._parsedDecoded; ``` Applied to all 5 spread sites in `public/packets.js`: - Line 271: detail pane observation selection - Line 504: flat view observation expansion - Line 840: grouped view observation expansion - Line 1012: child observation selection in grouped view - Line 1982: WebSocket live update observation expansion ## Tests Added 2 new tests in `test-frontend-helpers.js`: 1. Verifies observation packets get their own path after cache invalidation (not the parent's) 2. Verifies observation path differs from parent path after cache invalidation All 431 frontend helper tests pass. All 62 packet filter tests pass. --------- Co-authored-by: you <you@example.com>
44 lines
1.5 KiB
JavaScript
44 lines
1.5 KiB
JavaScript
/* === CoreScope — packet-helpers.js (shared packet utilities) === */
|
|
'use strict';
|
|
|
|
/**
|
|
* Cached JSON.parse helpers for packet data (issue #387).
|
|
* Avoids repeated parsing of path_json / decoded_json on the same packet object.
|
|
* Results are cached as _parsedPath / _parsedDecoded properties on the packet.
|
|
*
|
|
* Handles pre-parsed objects (non-string values) gracefully — returns them as-is.
|
|
*/
|
|
|
|
window.getParsedPath = function getParsedPath(p) {
|
|
if (p._parsedPath !== undefined) return p._parsedPath;
|
|
var raw = p.path_json;
|
|
if (typeof raw !== 'string') {
|
|
p._parsedPath = Array.isArray(raw) ? raw : [];
|
|
return p._parsedPath;
|
|
}
|
|
try { p._parsedPath = JSON.parse(raw) || []; } catch (e) { p._parsedPath = []; }
|
|
return p._parsedPath;
|
|
};
|
|
|
|
/**
|
|
* Clear cached _parsedPath/_parsedDecoded from a packet object.
|
|
* Must be called after spreading a parent packet into an observation/child,
|
|
* otherwise the child inherits stale cached values from the parent (issue #504).
|
|
*/
|
|
window.clearParsedCache = function clearParsedCache(p) {
|
|
delete p._parsedPath;
|
|
delete p._parsedDecoded;
|
|
return p;
|
|
};
|
|
|
|
window.getParsedDecoded = function getParsedDecoded(p) {
|
|
if (p._parsedDecoded !== undefined) return p._parsedDecoded;
|
|
var raw = p.decoded_json;
|
|
if (typeof raw !== 'string') {
|
|
p._parsedDecoded = (raw && typeof raw === 'object') ? raw : {};
|
|
return p._parsedDecoded;
|
|
}
|
|
try { p._parsedDecoded = JSON.parse(raw) || {}; } catch (e) { p._parsedDecoded = {}; }
|
|
return p._parsedDecoded;
|
|
};
|