mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-11-22 03:17:04 +00:00
Draft for feedback: a working version of native repeater claims and edits from mobile clients, built on the repeater info feature from #2415. Four open questions are at the end. ## Situation Repeater info (#2415) can only be claimed and edited from a browser session. Device tokens from `POST /api/auth/device-token` are limited to `rx` (CoreDrive RX: settings and companion linking), and `GET /api/repeaters/{pubkey}/info` treats a bearer token as anonymous. A mobile client can show a repeater's details but can't offer "claim" or "edit" natively. `PUT /api/repeaters/{pubkey}/info` is also a full replace with no precondition. Two people editing from the same copy silently overwrite each other. That's rare in the browser, but likelier from an app that keeps a cached copy. ## Change Three commits, one per piece. **1. Device-token scopes for the repeater routes** (`8aba3715`) - `POST /api/auth/device-token` takes an optional `scopes` list. Omitted (or `null`) still means `["rx"]`, so CoreDrive RX and every existing token keep exactly their current permissions. An empty list or an unknown scope answers 400, checked before the password. - New scopes: - `repeater:claim`: `POST` and `DELETE /api/repeaters/{pubkey}/claim`. These already only add or remove the caller's own claim. Several claimers per repeater, idempotent `POST`, unchanged. - `repeater:edit`: `PUT /api/repeaters/{pubkey}/info`, still subject to `CanEditRepeater`. - Every device token may use `/api/auth/me` and `/api/auth/logout`, so a repeater-only token can check and end its own login. - `GET /api/repeaters/{pubkey}/info` with a token holding either repeater scope returns `canEdit` and `claimedByMe`. An unknown or expired token answers 401 rather than passing as anonymous, so a client learns its login is gone. A valid token without a repeater scope still gets the public view. A cookie still wins over a bearer header, as elsewhere. - `GET /api/account/repeaters` (My repeaters, from #2430) also takes a token holding either repeater scope, so an app gets the account's claims in one request. It can't build that list from the public catalog, where claimers are display names, and reading repeaters one at a time would miss a claimed repeater that has left the node list. An `rx`-only token still answers 403. - Scope checks are method-aware (`bearerScopesFor(method, path)`). The repeater paths are added to the bearer CORS paths. - Same handlers, validation, rate limit (`repeater`, 120/h per user and per IP), audit actions and admin claim removal as the browser. Token writes add `via: device` to the `repeater.claim`, `repeater.edit` and `repeater.unclaim` rows, and the `user.login` row records the granted scopes. The admin route keeps refusing bearer tokens. **2. Conditional edits with a revision** (`9f9bf47b`) - `users.db` schema v10 adds `repeater_info.revision`. Existing rows start at 1; a repeater with no saved details is at 0. Claims don't change it. - `GET` (single and list) and `PUT` responses include `revision`. - `PUT` accepts an optional `baseRevision`. The check is part of the write statement, so of two saves from the same base exactly one lands: - `baseRevision: 0` (first save): `INSERT … ON CONFLICT(pubkey) DO NOTHING`. - `baseRevision: n`: `UPDATE … SET revision = revision + 1 … WHERE pubkey = ? AND revision = ?`. - No match answers `409` with the stored details (`canEdit`/`claimedByMe` included) and writes nothing. That's the same shape `PUT /api/account/settings` uses for its conflicts. - A stale base is refused even when the body would change nothing. - Permission is checked first, so a 409 never shows details to someone who can't edit. - Without `baseRevision` the save is unconditional and bumps the revision, so `public/repeater-info.js` works unchanged. - `/api/config/client` adds `userManagement.repeaterTokens: true`, so a client can tell this server from one without the scopes or `baseRevision` (older servers answer the device-token request with the SPA page, as noted for `companionLinking`). **Discovery and conflict recovery, for a client:** 1. Check `userManagement.repeaterTokens` in `/api/config/client`. Without it, keep the claim and edit actions hidden. 2. Log in with `scopes: ["repeater:claim", "repeater:edit"]` (or just what the client offers). The response echoes the granted `scopes`. 3. Read `GET /api/repeaters/{pubkey}/info` with the token. Show Claim/Unclaim from `claimedByMe` and Edit from `canEdit`, and keep `revision`. 4. Save with `PUT …/info` and `baseRevision` set to that revision. On 200, keep the new `revision` from the response. On 409, the body is the current record: show or merge it, then retry with its `revision`. On 401, log in again. On 403, the account can no longer edit (for example someone claimed it), so refresh from `canEdit`. **3. Account page device list** (`d28374aa`) My account, Devices labelled every device token "CoreDrive RX". `/api/account/sessions` now includes a device token's `scopes`. The page keeps the CoreDrive RX label for `rx` tokens (and rows without scopes). It shows other tokens under the device name the app sent, with a line such as "can claim repeaters and edit repeater details". Docs: `openapi.go`, `docs/api-spec.md` and the Repeater info section of `docs/user-guide/accounts.md`. ## Questions 1. **One scope or two?** This uses separate `repeater:claim` and `repeater:edit`, so a client can ask for less, and a token that only edits can't put the user's name on a repeater publicly. One `repeater` scope would be simpler if you'd rather not split it. 2. **Editing unclaimed repeaters from mobile.** This keeps web parity: any active user may edit a repeater nobody has claimed, and once it has claimers only they (and admins) can. The alternative is to require a claim before a token may edit. That's stricter, but then app and browser rules differ. 3. **Operator switch.** There's no new setting: the scopes are available whenever `userManagement` is on, and the user opts in when the app asks for them at login. Would you want an explicit opt-in such as `userManagement.mobileRepeaterWrites`? 4. **Stale-edit contract.** Does `revision` plus `baseRevision` in the body, with 409 returning the current record, fit? I matched account settings rather than `ETag`/`If-Match`, to keep one pattern in the API. The browser editor doesn't send `baseRevision` yet. Making it send one would be a small follow-up, if you want browser saves protected too. ## Tests - `cmd/server/repeater_device_token_test.go`: - default and requested scopes, rejected scopes, and the method-aware route table; - per-scope allowed and denied routes, logout with a repeater-only token; - claim and unclaim of own claim only, alongside another claimer; - edit permission (unclaimed repeater, claimer, non-claimer, admin) and a disabled account; - the admin route refusing tokens; - authenticated, public and expired-token reads; - `via: device` audit rows, cookie writes still needing CSRF, and session scopes. - My repeaters with a claim or edit token (own claims only), and 403 for an `rx`-only token. - `cmd/server/repeater_revision_test.go`: - revision on reads, a first edit with no saved row, and a stale base returning 409 with the current record and no audit row; - unconditional browser saves, validation and permission order; - two concurrent saves from the same revision (one 200, one 409), and the client config flag. - `internal/users/repeater_revision_test.go`: - revision counting and conditional first and later saves; - an 8-way race for both cases (`-race`); - the v9 to v10 upgrade. - `tests/unit/test-user-management-ui.js`: app token labels and scope line. Run locally: - `make test`: all 16 modules OK. - `sh test-all.sh`: all suites pass, run in `node:24-bookworm`. On macOS, `test-manage-workflow.js` fails 2 cases on unchanged master because of the BSD tools. - `npx eslint public/*.js`: 0 errors, the same 87 warnings as master. - `node tests/e2e/test-lint-network-calls.js` - `tests/e2e/test-user-management-e2e.js` against local e2etest servers with the CI config: 44/44. - Manually against a local instance: - in the browser: claim, edit, unclaim, and the Devices list; - with curl: the token flow, including a 409 after a browser save. Not run: the full Playwright shard matrix from CI. --------- Co-authored-by: Adam <196335+anieto@users.noreply.github.com>
349 lines
16 KiB
Go
349 lines
16 KiB
Go
package main
|
|
|
|
import (
|
|
"net/http"
|
|
"slices"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/meshcore-analyzer/users"
|
|
)
|
|
|
|
// scopedToken logs in like a mobile client asking for scopes.
|
|
func (f *authFixture) scopedToken(t *testing.T, email, name string, scopes ...string) string {
|
|
t.Helper()
|
|
w := f.do("POST", "/api/auth/device-token",
|
|
deviceTokenRequest{Email: email, Password: pw, DeviceName: name, Scopes: scopes})
|
|
expectStatus(t, w, http.StatusOK)
|
|
got := decode[deviceTokenResponse](t, w)
|
|
if !slices.Equal(got.Scopes, scopes) {
|
|
t.Fatalf("granted scopes = %v, want %v", got.Scopes, scopes)
|
|
}
|
|
return got.Token
|
|
}
|
|
|
|
func TestDeviceTokenScopesDefaultToRX(t *testing.T) {
|
|
f := newAuthFixture(t)
|
|
f.registerAndActivate(t, "alice@example.org", "Alice", pw)
|
|
got := f.deviceToken(t, "alice@example.org", pw, "Pixel")
|
|
if !slices.Equal(got.Scopes, []string{deviceScopeRX}) {
|
|
t.Fatalf("scopes = %v, want [rx]", got.Scopes)
|
|
}
|
|
sess, err := f.st.LookupSession(got.Token)
|
|
if err != nil || sess.HasScope(deviceScopeRepeaterClaim) || sess.HasScope(deviceScopeRepeaterEdit) {
|
|
t.Fatalf("an RX token holds repeater scopes: %+v, %v", sess, err)
|
|
}
|
|
}
|
|
|
|
func TestDeviceTokenScopesRequested(t *testing.T) {
|
|
f := newAuthFixture(t)
|
|
alice := f.registerAndActivate(t, "alice@example.org", "Alice", pw)
|
|
// Repeats collapse and the order is fixed.
|
|
w := f.do("POST", "/api/auth/device-token", deviceTokenRequest{Email: "alice@example.org", Password: pw,
|
|
DeviceName: "iPhone", Scopes: []string{deviceScopeRepeaterEdit, deviceScopeRepeaterClaim, deviceScopeRepeaterEdit}})
|
|
expectStatus(t, w, http.StatusOK)
|
|
got := decode[deviceTokenResponse](t, w)
|
|
want := []string{deviceScopeRepeaterClaim, deviceScopeRepeaterEdit}
|
|
if !slices.Equal(got.Scopes, want) {
|
|
t.Fatalf("scopes = %v, want %v", got.Scopes, want)
|
|
}
|
|
sess, err := f.st.LookupSession(got.Token)
|
|
if err != nil || !slices.Equal(sess.Scopes, want) || sess.HasScope(deviceScopeRX) {
|
|
t.Fatalf("stored session = %+v, %v", sess, err)
|
|
}
|
|
rows := auditOf(t, f, alice.me.ID, "user.login")
|
|
if len(rows) == 0 || rows[0].Detail["scopes"] != "repeater:claim,repeater:edit" {
|
|
t.Fatalf("login audit = %+v", rows)
|
|
}
|
|
}
|
|
|
|
func TestDeviceTokenScopesRejected(t *testing.T) {
|
|
f := newAuthFixture(t)
|
|
alice := f.registerAndActivate(t, "alice@example.org", "Alice", pw)
|
|
for _, scopes := range [][]string{{}, {"admin"}, {deviceScopeRX, "repeater:delete"}, {""}} {
|
|
w := f.do("POST", "/api/auth/device-token", deviceTokenRequest{Email: "alice@example.org", Password: pw,
|
|
DeviceName: "x", Scopes: scopes})
|
|
if w.Code != http.StatusBadRequest {
|
|
t.Errorf("scopes %q = %d, want 400", scopes, w.Code)
|
|
}
|
|
}
|
|
list, err := f.st.ListSessions(alice.me.ID)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
for _, s := range list {
|
|
if s.Kind == users.SessionKindDevice {
|
|
t.Fatalf("a rejected request created a device session: %+v", s)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBearerScopesForRoutes(t *testing.T) {
|
|
both := []string{deviceScopeRepeaterClaim, deviceScopeRepeaterEdit}
|
|
for _, c := range []struct {
|
|
method, path string
|
|
want []string
|
|
}{
|
|
{"GET", "/api/auth/me", deviceScopes},
|
|
{"POST", "/api/auth/logout", deviceScopes},
|
|
{"PUT", "/api/account/settings", []string{deviceScopeRX}},
|
|
{"DELETE", "/api/account/companions/" + rpkA, []string{deviceScopeRX}},
|
|
{"POST", repPath(rpkA, "claim"), []string{deviceScopeRepeaterClaim}},
|
|
{"DELETE", repPath(rpkA, "claim"), []string{deviceScopeRepeaterClaim}},
|
|
{"PUT", repPath(rpkA, "info"), []string{deviceScopeRepeaterEdit}},
|
|
{"GET", repPath(rpkA, "info"), both},
|
|
{"GET", "/api/account/repeaters", both},
|
|
{"HEAD", "/api/account/repeaters", both},
|
|
{"POST", "/api/account/repeaters", nil},
|
|
{"DELETE", "/api/account/repeaters", nil},
|
|
{"GET", repPath(rpkA, "claim"), nil},
|
|
{"POST", repPath(rpkA, "info"), nil},
|
|
{"GET", "/api/repeaters/info", nil},
|
|
{"PUT", "/api/repeaters//info", nil},
|
|
{"PUT", repPath(rpkA, "info/x"), nil},
|
|
{"DELETE", "/api/admin/repeaters/" + rpkA + "/claims/1", nil},
|
|
{"GET", "/api/account/sessions", nil},
|
|
} {
|
|
if got := bearerScopesFor(c.method, c.path); !slices.Equal(got, c.want) {
|
|
t.Errorf("bearerScopesFor(%s %s) = %v, want %v", c.method, c.path, got, c.want)
|
|
}
|
|
}
|
|
for path, want := range map[string]bool{
|
|
repPath(rpkA, "info"): true, repPath(rpkA, "claim"): true, "/api/auth/device-token": true,
|
|
"/api/account/companions": true, "/api/account/repeaters": true, "/api/repeaters/info": false, "/api/account/sessions": false,
|
|
} {
|
|
if got := bearerCORSPath(path); got != want {
|
|
t.Errorf("bearerCORSPath(%s) = %v, want %v", path, got, want)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Each scope opens only its own routes; RX and repeater tokens stay apart.
|
|
func TestRepeaterTokenScopesPerRoute(t *testing.T) {
|
|
f := repeaterFixture(t)
|
|
f.registerAndActivate(t, "alice@example.org", "Alice", pw)
|
|
tokens := map[string]string{
|
|
"rx": f.deviceToken(t, "alice@example.org", pw, "RX").Token,
|
|
"claim": f.scopedToken(t, "alice@example.org", "claim", deviceScopeRepeaterClaim),
|
|
"edit": f.scopedToken(t, "alice@example.org", "edit", deviceScopeRepeaterEdit),
|
|
}
|
|
for _, c := range []struct {
|
|
token, method, path string
|
|
body any
|
|
want int
|
|
}{
|
|
{"rx", "POST", repPath(rpkA, "claim"), nil, 403},
|
|
{"rx", "PUT", repPath(rpkA, "info"), map[string]any{"heightM": 1}, 403},
|
|
{"edit", "POST", repPath(rpkA, "claim"), nil, 403},
|
|
{"claim", "PUT", repPath(rpkA, "info"), map[string]any{"heightM": 1}, 403},
|
|
{"claim", "GET", "/api/account/settings", nil, 403},
|
|
{"edit", "GET", "/api/account/companions", nil, 403},
|
|
{"claim", "GET", "/api/auth/me", nil, 200},
|
|
{"edit", "GET", "/api/auth/me", nil, 200},
|
|
{"edit", "PUT", repPath(rpkA, "info"), map[string]any{"heightM": 1}, 200},
|
|
{"claim", "POST", repPath(rpkA, "claim"), nil, 200},
|
|
{"claim", "DELETE", repPath(rpkA, "claim"), nil, 200},
|
|
} {
|
|
if w := f.do(c.method, c.path, c.body, bearer(tokens[c.token])); w.Code != c.want {
|
|
t.Errorf("%s token: %s %s = %d (%s), want %d", c.token, c.method, c.path, w.Code, w.Body.String(), c.want)
|
|
}
|
|
}
|
|
// A repeater-only token can still end its own login.
|
|
expectStatus(t, f.do("POST", "/api/auth/logout", nil, bearer(tokens["claim"])), 200)
|
|
if _, err := f.st.LookupSession(tokens["claim"]); err == nil {
|
|
t.Fatal("logout left the claim token valid")
|
|
}
|
|
}
|
|
|
|
// A claim token manages the caller's own claim only, beside other claimers.
|
|
func TestRepeaterTokenClaimsOwnClaimOnly(t *testing.T) {
|
|
f := repeaterFixture(t)
|
|
alice := f.registerAndActivate(t, "alice@example.org", "Alice", pw)
|
|
f.registerAndActivate(t, "bob@example.org", "Bob", pw)
|
|
expectStatus(t, f.do("POST", repPath(rpkA, "claim"), nil, as(alice)), 200)
|
|
bob := f.scopedToken(t, "bob@example.org", "Bob's phone", deviceScopeRepeaterClaim)
|
|
|
|
// Bob has no claim yet: his DELETE must not touch Alice's.
|
|
expectStatus(t, f.do("DELETE", repPath(rpkA, "claim"), nil, bearer(bob)), 404)
|
|
w := f.do("POST", repPath(rpkA, "claim"), nil, bearer(bob))
|
|
expectStatus(t, w, 200)
|
|
got := decode[repeaterInfoJSON](t, w)
|
|
if len(got.Claimers) != 2 || got.ClaimedByMe == nil || !*got.ClaimedByMe {
|
|
t.Fatalf("after Bob's claim: %+v", got)
|
|
}
|
|
// Repeating the claim stays a 200 without a second claim.
|
|
got = decode[repeaterInfoJSON](t, f.do("POST", repPath(rpkA, "claim"), nil, bearer(bob)))
|
|
if len(got.Claimers) != 2 {
|
|
t.Fatalf("a repeated claim changed the claimers: %+v", got.Claimers)
|
|
}
|
|
w = f.do("DELETE", repPath(rpkA, "claim"), nil, bearer(bob))
|
|
expectStatus(t, w, 200)
|
|
got = decode[repeaterInfoJSON](t, w)
|
|
if len(got.Claimers) != 1 || got.Claimers[0].DisplayName != "Alice" || *got.ClaimedByMe {
|
|
t.Fatalf("after Bob's unclaim: %+v", got)
|
|
}
|
|
expectStatus(t, f.do("POST", repPath(rpkComp, "claim"), nil, bearer(bob)), 400)
|
|
if rows := auditOf(t, f, alice.me.ID, "repeater.unclaim"); len(rows) != 0 {
|
|
t.Fatalf("Alice's claim was audited as removed: %+v", rows)
|
|
}
|
|
}
|
|
|
|
// An edit token follows the browser's rule: anyone on an unclaimed repeater,
|
|
// then only its active claimers, and admins always.
|
|
func TestRepeaterTokenEditFollowsCanEdit(t *testing.T) {
|
|
f := repeaterFixture(t, "boss@example.org")
|
|
alice := f.registerAndActivate(t, "alice@example.org", "Alice", pw)
|
|
f.registerAndActivate(t, "bob@example.org", "Bob", pw)
|
|
f.registerAndActivate(t, "boss@example.org", "Boss", pw)
|
|
bobEdit := f.scopedToken(t, "bob@example.org", "Bob", deviceScopeRepeaterEdit)
|
|
bobBoth := f.scopedToken(t, "bob@example.org", "Bob 2", deviceScopeRepeaterClaim, deviceScopeRepeaterEdit)
|
|
boss := f.scopedToken(t, "boss@example.org", "Boss", deviceScopeRepeaterEdit)
|
|
|
|
expectStatus(t, f.do("PUT", repPath(rpkA, "info"), map[string]any{"heightM": 10}, bearer(bobEdit)), 200)
|
|
expectStatus(t, f.do("POST", repPath(rpkA, "claim"), nil, as(alice)), 200)
|
|
w := f.do("PUT", repPath(rpkA, "info"), map[string]any{"heightM": 11}, bearer(bobEdit))
|
|
expectStatus(t, w, 403)
|
|
if info, _ := f.st.GetRepeaterInfo(rpkA); info == nil || info.HeightM == nil || *info.HeightM != 10 {
|
|
t.Fatalf("a refused edit changed the row: %+v", info)
|
|
}
|
|
// Claiming makes Bob a maintainer again.
|
|
expectStatus(t, f.do("POST", repPath(rpkA, "claim"), nil, bearer(bobBoth)), 200)
|
|
expectStatus(t, f.do("PUT", repPath(rpkA, "info"), map[string]any{"heightM": 12}, bearer(bobBoth)), 200)
|
|
// The admin edits a claimed repeater through a token too.
|
|
w = f.do("PUT", repPath(rpkA, "info"), map[string]any{"heightM": 13}, bearer(boss))
|
|
expectStatus(t, w, 200)
|
|
if got := decode[repeaterInfoJSON](t, w); got.CanEdit == nil || !*got.CanEdit || *got.ClaimedByMe {
|
|
t.Fatalf("admin response = %+v", got)
|
|
}
|
|
// A disabled account's token stops working.
|
|
bobMe := decode[meResponse](t, f.do("GET", "/api/auth/me", nil, bearer(bobBoth)))
|
|
bobID := bobMe.ID
|
|
// A token reads its own scopes back (review on #2429), with no CSRF token.
|
|
if !slices.Equal(bobMe.Scopes, []string{deviceScopeRepeaterClaim, deviceScopeRepeaterEdit}) || bobMe.CSRFToken != "" {
|
|
t.Fatalf("/api/auth/me for a device token = %+v", bobMe)
|
|
}
|
|
if err := f.st.SetStatus(bobID, users.StatusDisabled); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
expectStatus(t, f.do("PUT", repPath(rpkA, "info"), map[string]any{"heightM": 14}, bearer(bobBoth)), 401)
|
|
}
|
|
|
|
// Admin claim removal stays a browser-only admin action.
|
|
func TestRepeaterTokenCannotUseAdminRoute(t *testing.T) {
|
|
f := repeaterFixture(t, "boss@example.org")
|
|
alice := f.registerAndActivate(t, "alice@example.org", "Alice", pw)
|
|
f.registerAndActivate(t, "boss@example.org", "Boss", pw)
|
|
expectStatus(t, f.do("POST", repPath(rpkA, "claim"), nil, as(alice)), 200)
|
|
boss := f.scopedToken(t, "boss@example.org", "Boss", deviceScopeRepeaterClaim, deviceScopeRepeaterEdit)
|
|
expectStatus(t, f.do("DELETE", adminClaimPath(rpkA, alice.me.ID), nil, bearer(boss)), 403)
|
|
if c, _ := f.st.RepeaterClaims(rpkA); len(c) != 1 {
|
|
t.Fatalf("claims = %+v", c)
|
|
}
|
|
}
|
|
|
|
func TestRepeaterInfoGetWithToken(t *testing.T) {
|
|
f := newAuthFixture(t)
|
|
alice := seedAliceRepeater(t, f)
|
|
f.registerAndActivate(t, "bob@example.org", "Bob", pw)
|
|
aliceClaim := f.scopedToken(t, "alice@example.org", "Alice", deviceScopeRepeaterClaim)
|
|
bobEdit := f.scopedToken(t, "bob@example.org", "Bob", deviceScopeRepeaterEdit)
|
|
rx := f.deviceToken(t, "bob@example.org", pw, "RX").Token
|
|
|
|
got := decode[repeaterInfoJSON](t, f.do("GET", repPath(rpkA, "info"), nil, bearer(aliceClaim)))
|
|
if got.CanEdit == nil || !*got.CanEdit || got.ClaimedByMe == nil || !*got.ClaimedByMe {
|
|
t.Fatalf("Alice's token: %+v", got)
|
|
}
|
|
got = decode[repeaterInfoJSON](t, f.do("GET", repPath(rpkA, "info"), nil, bearer(bobEdit)))
|
|
if got.CanEdit == nil || *got.CanEdit || got.ClaimedByMe == nil || *got.ClaimedByMe {
|
|
t.Fatalf("Bob's token: %+v", got)
|
|
}
|
|
// An RX token reads the public view, like an anonymous visitor.
|
|
w := f.do("GET", repPath(rpkA, "info"), nil, bearer(rx))
|
|
expectStatus(t, w, 200)
|
|
if strings.Contains(w.Body.String(), "canEdit") {
|
|
t.Fatalf("RX token got caller fields: %s", w.Body.String())
|
|
}
|
|
// A bearer that is no live device token reads the public view: a token
|
|
// that is gone, a web session token, and an auth proxy's own header
|
|
// (review on #2429: a 401 here hid the Repeater info section).
|
|
for _, tok := range []string{"nonsense", alice.cookie.Value, "eyJhbGciOiJSUzI1NiJ9.proxy.jwt"} {
|
|
w := f.do("GET", repPath(rpkA, "info"), nil, bearer(tok))
|
|
if w.Code != http.StatusOK || strings.Contains(w.Body.String(), "canEdit") {
|
|
t.Errorf("bearer %.8s… = %d %s, want 200 with the public view", tok, w.Code, w.Body.String())
|
|
}
|
|
}
|
|
// The same foreign header still gets 401 on a write, which needs a login.
|
|
expectStatus(t, f.do("PUT", repPath(rpkA, "info"), map[string]any{"notes": "x"}, bearer("eyJhbGciOiJSUzI1NiJ9.proxy.jwt")), http.StatusUnauthorized)
|
|
// The cookie still decides when both are sent, and anonymous reads stay public.
|
|
got = decode[repeaterInfoJSON](t, f.do("GET", repPath(rpkA, "info"), nil, as(alice), bearer("nonsense")))
|
|
if got.ClaimedByMe == nil || !*got.ClaimedByMe {
|
|
t.Fatalf("cookie with a stray bearer: %+v", got)
|
|
}
|
|
if w := f.do("GET", repPath(rpkA, "info"), nil); strings.Contains(w.Body.String(), "claimedByMe") || w.Code != 200 {
|
|
t.Fatalf("anonymous read = %d %s", w.Code, w.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestRepeaterTokenWritesAuditVia(t *testing.T) {
|
|
f := repeaterFixture(t)
|
|
alice := f.registerAndActivate(t, "alice@example.org", "Alice", pw)
|
|
tok := f.scopedToken(t, "alice@example.org", "iPhone", deviceScopeRepeaterClaim, deviceScopeRepeaterEdit)
|
|
expectStatus(t, f.do("POST", repPath(rpkA, "claim"), nil, bearer(tok)), 200)
|
|
expectStatus(t, f.do("PUT", repPath(rpkA, "info"), map[string]any{"notes": "roof"}, bearer(tok)), 200)
|
|
expectStatus(t, f.do("DELETE", repPath(rpkA, "claim"), nil, bearer(tok)), 200)
|
|
expectStatus(t, f.do("POST", repPath(rpkA, "claim"), nil, as(alice)), 200)
|
|
for action, want := range map[string][]string{
|
|
"repeater.claim": {"", "device"}, "repeater.edit": {"device"}, "repeater.unclaim": {"device"},
|
|
} {
|
|
rows := auditOf(t, f, alice.me.ID, action)
|
|
var via []string
|
|
for _, r := range rows {
|
|
via = append(via, r.Detail["via"])
|
|
}
|
|
if !slices.Equal(via, want) {
|
|
t.Errorf("%s via = %q, want %q (newest first)", action, via, want)
|
|
}
|
|
}
|
|
}
|
|
|
|
// The browser path is unchanged: a cookie write still needs the CSRF token.
|
|
func TestRepeaterCookieWriteStillNeedsCSRF(t *testing.T) {
|
|
f := repeaterFixture(t)
|
|
alice := f.registerAndActivate(t, "alice@example.org", "Alice", pw)
|
|
noCSRF := &client{cookie: alice.cookie}
|
|
for _, c := range []struct{ method, what string }{{"POST", "claim"}, {"PUT", "info"}, {"DELETE", "claim"}} {
|
|
if w := f.do(c.method, repPath(rpkA, c.what), map[string]any{}, as(noCSRF)); w.Code != http.StatusForbidden {
|
|
t.Errorf("%s %s without CSRF = %d, want 403", c.method, c.what, w.Code)
|
|
}
|
|
}
|
|
if c, _ := f.st.RepeaterClaims(rpkA); len(c) != 0 {
|
|
t.Fatalf("claims = %+v", c)
|
|
}
|
|
}
|
|
|
|
// My account, Devices tells an app token's scopes apart from CoreDrive RX.
|
|
func TestAccountSessionsListScopes(t *testing.T) {
|
|
f := newAuthFixture(t)
|
|
alice := f.registerAndActivate(t, "alice@example.org", "Alice", pw)
|
|
f.deviceToken(t, "alice@example.org", pw, "RX")
|
|
f.scopedToken(t, "alice@example.org", "iPhone", deviceScopeRepeaterClaim, deviceScopeRepeaterEdit)
|
|
w := f.do("GET", "/api/account/sessions", nil, as(alice))
|
|
expectStatus(t, w, http.StatusOK)
|
|
got := map[string][]string{}
|
|
for _, s := range decode[[]sessionJSON](t, w) {
|
|
got[s.Kind+":"+s.Label] = s.Scopes
|
|
}
|
|
if s, ok := got["web:"]; !ok || s != nil {
|
|
t.Errorf("web session scopes = %v (present %v), want none", s, ok)
|
|
}
|
|
if s := got["device:RX"]; !slices.Equal(s, []string{deviceScopeRX}) {
|
|
t.Errorf("RX scopes = %v", s)
|
|
}
|
|
if s := got["device:iPhone"]; !slices.Equal(s, []string{deviceScopeRepeaterClaim, deviceScopeRepeaterEdit}) {
|
|
t.Errorf("app scopes = %v", s)
|
|
}
|
|
if strings.Contains(w.Body.String(), `"scopes":null`) {
|
|
t.Errorf("web session has a null scopes field: %s", w.Body.String())
|
|
}
|
|
}
|