n30nex
093e320c2b
## Fix Fixes #2060. Fixes #2081. Path Inspector route drawing and candidate replacement now have deterministic browser coverage. An idempotent SQL seed adds four synthetic repeaters and four edges after fixture migration, without changing packet ordering. The test uses the real API, normal clicks, visible Leaflet geometry, and removal of every previous route object. Restoring coverage exposed a desktop layout bug: drawing the first route moved the map over the next candidate button. The route sidebar now participates in the existing flex layout, including resizing and collapse, while preserving the mobile bottom sheet. The historical zero-candidate result did not reproduce on the current baseline. No search thresholds or API behavior changed. No new dependencies or customizer settings. ## Validation - Local assertion-red history: `042db2b` requires seeded candidates; `ca1d22a` exposes the blocked second click. Subsequent commits repair layout and narrow-window behavior. - All 183 standalone suites passed. Unchanged-base Go failures: #2083 readiness race (fixed in #2084) and Windows symlink privilege. - Real Chromium: 11 Path Inspector/layout checks, 33 related map checks, and core E2E (131 passed, 3 existing fixture skips). - CSS-variable checks, XSS diff check, inventory, whitespace and PII checks passed. Seed remains valid after periodic graph refresh. Local browser validation used Chromium with a 60-second navigation budget; the OpenClaw profile and external preflight script were unavailable. Repository checks ran directly. [CI run 36343343569](https://github.com/Kpa-clawbot/CoreScope/actions/runs/36343343569) records the initial assertion-red commit. Final CI must pass before merge.
3.3 KiB
Frontend tests
test-all.sh is the authoritative list of standalone frontend suites. Both
npm run test:unit and the CI Run JS unit tests step invoke it. npm test
and npm run test:coverage wrap the same runner with coverage reporting.
The inventory currently covers 280 root suites: 167 standalone suites in the runner and 113 suites classified separately by their prerequisites.
Run npm run test:unit from a checkout with Node.js, a POSIX shell, Bash, and
Python 3 available. The XSS gate's fixture test uses Bash and Python. On
Windows, use Git Bash and ensure python3 resolves to Python 3 rather than a
Microsoft Store alias; set PYTHONUTF8=1 for the gate's Unicode output.
No server or browser is started by this runner.
Tests live in tests/unit/ (standalone Node, run by test-all.sh) and
tests/e2e/ (needs a browser, a server or extra tooling). They run from the
repo root, and refer to it as REPO_ROOT. When adding a test-*.js file:
- If it runs standalone, put it in
tests/unit/and add itsnode tests/unit/test-name.jscommand totest-all.sh. - Otherwise put it in
tests/e2e/and add it toscripts/non-unit-tests.json, with a prerequisite or reason explaining why it belongs outside the unit runner. Browser suites still need explicit selection in the E2E workflow to become CI gates. - Run
node tests/unit/test-test-inventory.js. The guard rejectstest-*.jsfiles in the repo root, unclassified files, duplicate assignments, removed files left in a list, undocumented groups, and local/CI entry points that bypass the unit runner.
The separate inventory distinguishes plain Node Playwright scripts, suites
requiring the @playwright/test runner, and the jsdom integration suite.
Those last two dependencies are not currently declared in package.json;
classification records that limitation rather than installing them implicitly.
The existing E2E workflow retains its browser installation, local fixture
server, coverage collection, and repeat checks. Only use local servers for
browser tests; inventory membership alone does not mean a suite runs in CI.
Path Inspector route fixture
tests/e2e/test-path-inspector-e2e.js requires the real fixture API. After
freshening and migrating a disposable copy of test-fixtures/e2e-fixture.db,
seed it before starting the server:
sqlite3 fixture-copy.db < test-fixtures/path-inspector.sql
CHROMIUM_REQUIRE=1 BASE_URL=http://localhost:13581 node tests/e2e/test-path-inspector-e2e.js
The SQL adds four synthetic GPS repeaters and four persisted neighbor edges.
Prefixes f20601,f20602,f20603 produce two paths through different middle
repeaters. The suite requires trusted hop evidence, clicks both Show on Map
buttons, checks the real Leaflet segment coordinates, and verifies all previous
route objects leave the map when the candidate changes. Missing seeds fail;
there is no candidate-dependent skip. Rerunning the seed is safe, and it does
not add packets or alter their ordering. CI runs this setup after migration.
The historical claim that low scores remove all candidates is not how the current inspector works: scores are floored, and path trust marks evidence. An empty candidate list means at least one prefix has no relay candidate. Deterministic prefixes avoid relying on whichever graph neighbors sort first.