mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-06-05 19:01:48 +00:00
Kpa-clawbot
bfebf200b7
## What Drop the leading `/api` from the Scopes-tab `scope-stats` fetch in `public/analytics.js`. The `api()` helper already prefixes `/api`; passing `/api/scope-stats` produced a runtime URL of `/api/api/scope-stats`, which 404s, falls through to the SPA HTML, and crashes the Scopes tab with `JSON.parse: unexpected character`. Single-line behavior change. ## Why `api()` (defined earlier in the same file) prepends `/api`. Every other caller in `public/analytics.js` correctly passes a helper-relative path (`/observers`, `/nodes`, …). The Scopes loader was the lone offender. The same fix originally landed on the PR #915 branch (commit `2fd22cee`) but that branch never merged, so the bug resurfaced on subsequent rebases. The Scopes tab is therefore broken on production today — open `/analytics` → Scopes and the panel never renders. ## TDD - Red commit `b1fbc5601a985f20eb0ffee9181b7df5333248ca` adds `test-issue-1375-scope-stats-fetch.js`, which reads `public/analytics.js` and asserts: - ZERO matches of literal `api('/api/scope-stats'` (regression guard). - Exactly one match of `api('/scope-stats'` (positive — fix present). - Green commit edits the loader to drop the duplicate `/api`. - Test wired into `.github/workflows/deploy.yml` next to the existing `test-issue-*` entries. ## Manual verification After deploy, open `https://analyzer.00id.net/analytics`, click **Scopes**: panel renders cards instead of throwing a JSON parse error in DevTools console. Fixes #1375 --------- Co-authored-by: openclaw-bot <bot@openclaw.local>
51 lines
1.8 KiB
JavaScript
51 lines
1.8 KiB
JavaScript
/**
|
|
* #1375 — regression(analytics): Scopes tab fetches `/api/api/scope-stats`
|
|
* (duplicate prefix) → 404 → SPA HTML → JSON.parse error.
|
|
*
|
|
* The `api()` helper already prepends `/api`. Other callers in
|
|
* public/analytics.js correctly pass `/scope-stats` style relative paths;
|
|
* the Scopes loader was the lone offender passing `/api/scope-stats`,
|
|
* producing the doubled prefix at runtime.
|
|
*
|
|
* Fix: drop the leading `/api` from the Scopes-tab call so the helper
|
|
* builds `/api/scope-stats?window=…`.
|
|
*
|
|
* Originally landed on the PR #915 branch (commit 2fd22cee) but that
|
|
* branch never merged, so the bug resurfaced in subsequent rebases.
|
|
*/
|
|
'use strict';
|
|
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
let passed = 0, failed = 0;
|
|
function assert(cond, msg) {
|
|
if (cond) { passed++; console.log(' ✓ ' + msg); }
|
|
else { failed++; console.error(' ✗ ' + msg); }
|
|
}
|
|
|
|
const src = fs.readFileSync(
|
|
path.join(__dirname, 'public', 'analytics.js'), 'utf8');
|
|
|
|
console.log('\n=== #1375: Scopes tab scope-stats fetch path ===');
|
|
|
|
// Regression guard: the buggy doubled-prefix form must never reappear.
|
|
const badRe = /api\(\s*['"]\/api\/scope-stats/g;
|
|
const badMatches = src.match(badRe) || [];
|
|
assert(badMatches.length === 0,
|
|
"ZERO `api('/api/scope-stats'` occurrences in analytics.js " +
|
|
'(regression guard for doubled /api prefix)');
|
|
|
|
// Positive: the corrected, helper-relative form is present exactly once.
|
|
const goodRe = /api\(\s*['"]\/scope-stats/g;
|
|
const goodMatches = src.match(goodRe) || [];
|
|
assert(goodMatches.length === 1,
|
|
"Exactly one `api('/scope-stats'` call exists (the fixed loader) — " +
|
|
'found ' + goodMatches.length);
|
|
|
|
console.log('\n=== Summary ===');
|
|
console.log(' Passed: ' + passed);
|
|
console.log(' Failed: ' + failed);
|
|
console.log('\n#1375 ' + (failed === 0 ? 'PASS' : 'FAIL'));
|
|
process.exit(failed === 0 ? 0 : 1);
|