mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-09-25 20:43:46 +00:00
Alex B
893773338e
Moves 290 root test-*.js into tests/unit (177, listed in test-all.sh) and tests/e2e (113, classified in scripts/non-unit-tests.json), per #1981 and PR-D of #1385. Root goes from 348 entries to 48. test-all.sh and test-fixtures/ stay put. The inventory guard now fails if a test reappears in the root or sits in the wrong folder.
Verified independently of the diff: the invoked sets are unchanged (test-all.sh 177 before and after, deploy.yml 96 before and after, both identical as sets), and a full local run of test-all.sh on master and on the branch produced 4702 output lines each whose only differences are absolute paths, stack-trace line numbers shifted by the REPO_ROOT line, the inventory wording and two perf ratios. The guard was mutation-checked: a test back in the root, a unit suite in tests/e2e, and a suite dropped from test-all.sh each make it exit 1. CI run 35246304316 ran 97 suites from tests/e2e and is green.
Follow-up 9335c51d finished the instruction files: no bare root test command is left in AGENTS.md, the squad charters, .github or docs, and every tests/ path they name resolves.
Merged by the interim maintainer without a second human reviewer: CI and the local runs above are the independent checks.
Known and deliberately out of scope: 18 of the 113 files in tests/e2e are invoked by no runner at all, and one of them cannot run anywhere because it requires jsdom, which is not a declared dependency. Tracked separately.
CoreScope — Agent Contributor Onboarding
If you're a contributor to CoreScope using an AI coding agent (Claude Code, Codex, Cursor, Aider, OpenClaw, Continue, etc.), this directory is your onboarding pack.
The maintainers run their own agent-driven workflow against this repo. The docs here describe the process, discipline, and reusable building blocks (skills + personas) that make that workflow merge-clean. Most of it is agent-agnostic — TDD, PR polish, persona review, PII preflight, subagent briefs — and translates cleanly to whatever harness you use.
Read in this order
- WORKFLOW.md — the end-to-end pipeline (fix-issue → CI watch → pr-polish → merge-gate → merge), planning rules, PII preflight, force-push rules, worktrees.
- RULES.md — 36 hard-won rules. Skim once, re-read when something feels off.
- TDD.md — red→green is mandatory. Exemptions listed.
- SUBAGENT-BRIEF-TEMPLATE.md — required template before spawning any subagent.
- skills/ — task-specific playbooks (e.g.,
fix-issue,pr-polish,pr-preflight,corescope-release). - personas/ — adversarial / expert review voices used in pr-polish fan-out.
How to use this with your own agent
- Point your agent at this directory. Tell it: "Treat
WORKFLOW.md+RULES.md+TDD.mdas standing instructions for this repo. Use the skills as task playbooks. Use the personas as parallel review voices on PRs." - The skills are written in a tool-call style we use internally, but the structure (Inputs / Steps / Output / Failure modes) is portable. Adapt the tool invocations to your harness.
- The personas are role prompts — drop them in as system messages when you want a specific kind of review (Carmack for perf, Dijkstra for correctness, Torvalds for taste, etc.).
Non-goals
- This is not a tutorial on CoreScope internals. For that see the repo
README.mdandAGENTS.md. - This is not a harness-specific guide. We document concepts, not key bindings.