mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-05-19 16:55:11 +00:00
2beeb2b324
Red commit:75563ce(CI run: pending — pushed at branch open) Follows up PR #1198 round-2 adversarial review (issue #1199). Six robustness / perf-hot-path / maintenance items, one commit per logical change. Stacked on top of `fix/issue-1197` (PR #1198) — base must move to `master` after #1198 merges. | # | Item | Commit(s) | Discipline | |---|---|---|---| | 1 | Brittle static-grep regex → go/parser AST walk in `resolve_context_callsites_test.go` |33d80b6(RED) →450236d(GREEN) | red→green | | 2 | `computeAnalyticsTopology` double-pass filter → materialize `filteredTxs` once |00005f6| refactor | | 3 | `BenchmarkBuildAggregateHopContextPubkeys` baseline + tiny smoke test |b520048| net-new bench/test | | 4 | `hopResolverPerTx` CONCURRENCY doc — single-goroutine invariant |155ff07| doc-only | | 5 | `schemaDegradationLogged` package-level `sync.Map` → PacketStore field |75563ce(RED) →7dbf193(GREEN) | red→green | | 6 | `buildHopContextPubkeys` `out` slice cap hint (`make([]string, 0, 16)`) |2040962| refactor | Items 2 & 6 are pure refactors — no test files modified for items 2 & 6 (per AGENTS.md exemption rule). Existing tests stay green and unaltered. Item 4 is doc-only (CONCURRENCY: comment); no behavior change. Item 3 adds a bench + a smoke assertion for the aggregate helper that previously had no coverage. Local arm64 baseline: ~72ms/op, 130k allocs at 5k txs. Items 1 & 5 follow red→green:33d80b6demonstrates the regex blindspot via a synthetic AST-detectable input the regex misses;75563cedemonstrates per-store log dedup leaks across instances. Both flips visible in branch history. Full `go test ./cmd/server/...` runs clean post-amend. Fixes #1199 --------- Co-authored-by: openclaw-bot <bot@openclaw.local>