mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-10-12 02:17:16 +00:00
Part A of #2128: optional, off-by-default user accounts. With the feature off nothing changes; with it on, visitors can register and log in, and admins manage users and use the operator actions without the API key. PR #2130 (settings sync) builds on this one. The two are meant to be merged together. ## The situation - Operator actions (geofilter save and prune, backup, perf reset) need the shared `apiKey`. There is no per-person right. - Nothing in CoreScope knows who a visitor is, so the requests in #2128 that need that (#1835, #2092, #1508, #730) have nothing to build on. ## What this PR adds **Two new Go modules** - `internal/users`: a separate `users.db` (SQLite through `modernc.org/sqlite`) with users, sessions, single-use tokens, an audit log and a mail log. Passwords use argon2id. - `internal/mailer`: a `Mailer` interface with a Brevo client (send, delivery events, webhook parsing) and an in-memory fake for tests. **Server (`cmd/server`)**, active only with `userManagement.enabled` - 24 routes, all documented in OpenAPI under the `users` tag ([`auth_routes.go`](https://github.com/efiten/CoreScope/blob/feat/user-management/cmd/server/auth_routes.go)): - auth: register, activate, login, logout, me, forgot, reset; - account: profile, password, email change with confirmation, sessions, self-delete; - admin: list, detail, disable, enable, delete, role, resend activation, manual activation, mail status refresh; - a Brevo webhook, registered only when `mail.webhookSecret` is set. - `requireAdmin` replaces `requireAPIKey` at the 7 operator call sites: the API key **or** an admin session. With the feature off it is the old API-key gate (`TestRequireAdminWithoutUserManagementIsAPIKeyGate`). - `/api/config/client` gets `userManagement: {enabled: true}` only when the service started; with the feature off the response is byte-identical. **Frontend** - `auth.js` (header account control, request helper that adds the CSRF header), `account.js` (login, register, activate, forgot, reset, confirm email, my account), `admin-users.js` (`#/admin/users`, deep-linked filters), `account.css` (theme tokens only). - On phones the top-bar control is hidden, so a conditional entry goes into the bottom-nav "More" sheet and the nav drawer. - The customizer geofilter tab and the Perf "Reset stats" button use the admin session when there is one. **Config.** A `userManagement` block (`config.example.json`, [`docs/user-guide/accounts.md`](https://github.com/efiten/CoreScope/blob/feat/user-management/docs/user-guide/accounts.md)). The Brevo key can come from `CORESCOPE_BREVO_API_KEY`. The server refuses to start when the block is enabled but incomplete. ## Security choices - Session cookie `cs_session`: HttpOnly, SameSite=Lax, Secure when `publicBaseUrl` is https. Every cookie-authenticated state change needs the `X-CS-CSRF` header and a matching Origin. - Activation needs the token **and** the account password. Without the password, an attacker who keeps re-registering a known address could get the owner to activate an account that carries the attacker's password. - Register, forgot and email change answer identically for known and unknown addresses. A password reset ends all sessions, a password change ends all other sessions, and both end outstanding email-change links. - Rate limits: login 10 per 15 minutes, register and forgot 5 per hour, per IP and per address. The bucket count is capped. `trustedProxies` makes the per-IP limits see real client IPs behind a proxy. - Server logs carry `#<user id>`, never addresses, tokens or passwords; mail-provider error texts are redacted before logging. ## Performance No change to an existing hot path with the feature off. With it on: - One `users.db` lookup per authenticated request (session by token hash). - The admin user table rebuilds its `tbody` on each filter change. `users.List` caps the result at 1000 rows (`internal/users/users.go`), which bounds the rebuild. - `map[string]interface{}` in `openapi.go`: 79 before, 78 after. ## Verification - `internal/users`, `internal/mailer` and `cmd/server`: `go vet` and `go test -race` pass locally. 121 new Go tests. - `cmd/server` with `-tags e2etest`: vet and the e2e hook tests pass. - `sh test-all.sh` exits 0. `tests/unit/test-user-management-ui.js`: 67 passing (vm, real modules). - `tests/e2e/test-user-management-e2e.js` (6 steps) passed locally against an `e2etest` build with the fake mailer and against a feature-off build. CI builds the `e2etest` binary and runs the suite on a second server (`deploy.yml`). - On a staging instance with a real Brevo key: register, activation mail delivered, activate, admin table, "Refresh status" showing sent, deferred, delivered, opened and clicked. ## Not in this PR - Settings sync (#2130), the admin dashboard, approval flows and notifications (parts B to E of #2128). - A `requireReadAuth` mode (#1835). Sessions from this PR are what such a mode would accept. - Binary size and build time with `modernc.org/sqlite` linked next to `mattn/go-sqlite3` were not measured. Their driver names do not collide. #1992 discusses the driver choice. - No Brevo webhook was configured on staging; delivery status there came from "Refresh status". --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
128 lines
3.5 KiB
Go
128 lines
3.5 KiB
Go
// Package users is CoreScope's optional account store (user management,
|
|
// docs/specs/2026-10-06-user-management-design.md). It owns users.db, a
|
|
// SQLite file separate from the measurement database. cmd/server never
|
|
// writes measurement data (#1283); this package is the single, opt-in
|
|
// exception, and Open refuses to touch the measurement database by path.
|
|
package users
|
|
|
|
import (
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"time"
|
|
|
|
_ "modernc.org/sqlite"
|
|
)
|
|
|
|
var (
|
|
ErrNotFound = errors.New("users: not found")
|
|
ErrEmailTaken = errors.New("users: email already registered")
|
|
ErrTokenInvalid = errors.New("users: token invalid or already used")
|
|
ErrTokenExpired = errors.New("users: token expired")
|
|
// ErrAccountChanged: the account is no longer pending with the
|
|
// password hash the caller verified (a re-register or an admin got
|
|
// there first).
|
|
ErrAccountChanged = errors.New("users: account changed since it was read")
|
|
)
|
|
|
|
// Store is the users.db handle. Safe for concurrent use.
|
|
type Store struct {
|
|
db *sql.DB
|
|
now func() time.Time
|
|
}
|
|
|
|
// Open opens (creating if needed) the users database at path and applies
|
|
// pending migrations. forbidden lists paths Open must refuse; the server
|
|
// passes the measurement DB path so a misconfigured dbPath can never turn
|
|
// this package into a writer of measurement data.
|
|
func Open(path string, forbidden ...string) (*Store, error) {
|
|
if strings.ContainsAny(path, "?#") {
|
|
return nil, fmt.Errorf("users: database path %q must not contain '?' or '#'", path)
|
|
}
|
|
abs, err := filepath.Abs(path)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("users: resolve %s: %w", path, err)
|
|
}
|
|
for _, f := range forbidden {
|
|
if strings.TrimSpace(f) != "" && samePath(abs, f) {
|
|
return nil, fmt.Errorf("users: refusing to open %s: it is the measurement database", path)
|
|
}
|
|
}
|
|
if err := os.MkdirAll(filepath.Dir(abs), 0o755); err != nil {
|
|
return nil, fmt.Errorf("users: create dir for %s: %w", path, err)
|
|
}
|
|
db, err := sql.Open("sqlite", abs+"?_pragma=busy_timeout(5000)&_pragma=journal_mode(WAL)&_pragma=foreign_keys(1)")
|
|
if err != nil {
|
|
return nil, fmt.Errorf("users: open %s: %w", path, err)
|
|
}
|
|
// Account traffic is tiny; one connection removes SQLITE_BUSY between
|
|
// our own writers and keeps the per-connection pragmas in force.
|
|
db.SetMaxOpenConns(1)
|
|
s := &Store{db: db, now: time.Now}
|
|
if err := s.migrate(); err != nil {
|
|
db.Close()
|
|
return nil, err
|
|
}
|
|
return s, nil
|
|
}
|
|
|
|
func samePath(abs, other string) bool {
|
|
oa, err := filepath.Abs(other)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
a, errA := os.Stat(abs)
|
|
b, errB := os.Stat(oa)
|
|
if errA == nil && errB == nil {
|
|
return os.SameFile(a, b)
|
|
}
|
|
return strings.EqualFold(filepath.Clean(abs), filepath.Clean(oa))
|
|
}
|
|
|
|
// Close closes the database.
|
|
func (s *Store) Close() error { return s.db.Close() }
|
|
|
|
// SetClock replaces the time source. Tests only.
|
|
func (s *Store) SetClock(now func() time.Time) { s.now = now }
|
|
|
|
type rowScanner interface{ Scan(dest ...any) error }
|
|
|
|
func unix(t time.Time) int64 { return t.Unix() }
|
|
func fromUnix(v int64) time.Time { return time.Unix(v, 0).UTC() }
|
|
|
|
func fromNullUnix(v sql.NullInt64) *time.Time {
|
|
if !v.Valid {
|
|
return nil
|
|
}
|
|
t := fromUnix(v.Int64)
|
|
return &t
|
|
}
|
|
|
|
func nullInt(p *int64) any {
|
|
if p == nil {
|
|
return nil
|
|
}
|
|
return *p
|
|
}
|
|
|
|
func expectOne(res sql.Result, err error) error {
|
|
if err != nil {
|
|
return err
|
|
}
|
|
n, err := res.RowsAffected()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if n == 0 {
|
|
return ErrNotFound
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func isUniqueViolation(err error) bool {
|
|
return err != nil && strings.Contains(err.Error(), "UNIQUE constraint failed")
|
|
}
|