mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-10-13 13:57:21 +00:00
Alex BandClaude Opus 5.5
99efaed33d
## Summary `RegionFilter.setSelected()` saved the selection and redrew the control but never ran the `onChange` listeners; only a click (`toggleRegion`) did. A programmatic selection therefore updated the dropdown while the page kept showing data for the old selection until the next click. Affected today: the Packets page applies a `?region=` URL parameter through `setSelected`. It registers its listener afterwards, so its first load is fine, but any other page's listener that is still registered sees nothing. And anything that offers one-click region groups has to wrap `setSelected` to make it re-query (an nginx-injected overlay on one deployment does exactly that). This PR stands alone; #2170 (configurable quick picks) does not need it. `setSelected` now compares the new selection with the current one (order-insensitive; empty and null both mean "all") and, only when they differ, runs the listeners after saving and re-rendering, exactly as a click does. Re-applying the current selection stays silent, so a caller restoring state does not trigger a reload. No existing issue covers this. ## Tests - Red commit `75569b78`: `tests/unit/test-region-filter-setselected.js` loads the real `public/region-filter.js` in a `vm` sandbox. Two cases fail on `master` (a programmatic selection notifies once with the new codes; a clear notifies once with `null`). Two pass on both commits on purpose: re-applying the current selection in another order, and clearing an empty selection, must not notify. - Green commit `8a7ddfe1`: the fix. - Listed in `test-all.sh` in sorted order; `test-test-inventory.js` passes. `test-1108-region-hide-nodes.js` (the other region-filter suite) passes. Frontend suites: 194 of 195; the one failure, `test-issue-1956-release-routing.js`, needs CI's `GITHUB_REF_NAME` and fails the same way on `master` locally. ## Review notes - `packets.js` "clear all filters" calls `setSelected([])` and then reloads itself. When a region was selected, that path now also triggers the page's region listener, so the packets list is requested twice. It is a cosmetic double fetch on an explicit user action; left as is to keep this PR to the component. - No performance claim; this is a correctness fix. ## SonarLint SonarQube Community rules (the SonarLint engine) were run on the files this PR touches, and only issues on lines it adds are listed. - **Fixed** in `9e732706`: `node:` specifiers (S7772). - **Kept on purpose:** S1523 on `vm.runInContext`, which loads the repo's own `public/region-filter.js` as the other frontend unit tests do. ## Checked against the repo rules - Rebased onto `master` (`673442cc`). Each red commit was re-run and still fails on its assertions; each green commit passes (TDD.md). - `make test`: all 16 modules pass. Frontend suites: all pass except `test-issue-1956-release-routing.js`, which needs CI's `GITHUB_REF_NAME` and fails the same way on `master` locally (#2160 addresses it). - No private data: test fixtures and examples use the codes the existing tests use (SJC/SFO/LAX, `#be`-style scopes). - No new `map[string]interface{}`, no hard-coded colours. `git add` was explicit, and there is one logical change per commit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01KaR4xu8gVykQBkH8yG8m6H --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
207 lines
9.4 KiB
Bash
Executable File
207 lines
9.4 KiB
Bash
Executable File
#!/bin/sh
|
|
# Authoritative standalone frontend test list for local runs and CI.
|
|
# Every suite in tests/unit is listed here; every suite in tests/e2e is classified
|
|
# in scripts/non-unit-tests.json.
|
|
set -e
|
|
cd "$(dirname "$0")"
|
|
|
|
node tests/unit/test-test-inventory.js
|
|
node tests/unit/test-1108-region-hide-nodes.js
|
|
node tests/unit/test-1659-analytics-warmup.js
|
|
node tests/unit/test-a11y-1705-subpath-hop-prefix-e2e.js
|
|
node tests/unit/test-a11y-1715-dark-role-swatches.js
|
|
node tests/unit/test-a11y-1716-rf-range-btn-active.js
|
|
node tests/unit/test-a11y-1719-contrast-root-causes-e2e.js
|
|
node tests/unit/test-a11y-1996-scope-audit-chips.js
|
|
node tests/unit/test-a11y-axe-1668-selftest.js
|
|
node tests/unit/test-a11y-axe-routes-coverage.js
|
|
node tests/unit/test-admin-dashboard-ui.js
|
|
node tests/unit/test-aging.js
|
|
node tests/unit/test-analytics-channels-integration.js
|
|
node tests/unit/test-anl1-tooltip-render.js
|
|
node tests/unit/test-area-filter.js
|
|
node tests/unit/test-channel-color-picker.js
|
|
node tests/unit/test-channel-colors.js
|
|
node tests/unit/test-channel-decrypt-ecb.js
|
|
node tests/unit/test-channel-decrypt-insecure-context.js
|
|
node tests/unit/test-channel-decrypt-m345.js
|
|
node tests/unit/test-channel-fluid-layout.js
|
|
node tests/unit/test-channel-issue-1087.js
|
|
node tests/unit/test-channel-issue-1101.js
|
|
node tests/unit/test-channel-live-decrypt-userprefix.js
|
|
node tests/unit/test-channel-live-decrypt.js
|
|
node tests/unit/test-channel-modal-ux.js
|
|
node tests/unit/test-channel-proposals-ui.js
|
|
node tests/unit/test-channel-psk-ux.js
|
|
node tests/unit/test-channel-qr-wiring.js
|
|
node tests/unit/test-channel-qr.js
|
|
node tests/unit/test-channel-sidebar-layout.js
|
|
node tests/unit/test-channel-ux-followup.js
|
|
node tests/unit/test-channel-ux-round2.js
|
|
node tests/unit/test-channels-approved-ui.js
|
|
node tests/unit/test-channels-merge-1498-unit.js
|
|
node tests/unit/test-clear-filters.js
|
|
node tests/unit/test-color-picker-ux.js
|
|
node tests/unit/test-compare-flood-filter.js
|
|
node tests/unit/test-compare-overlap.js
|
|
node tests/unit/test-confidence-indicator.js
|
|
node tests/unit/test-coverage-gate.js
|
|
node tests/unit/test-customizer-v2.js
|
|
node tests/unit/test-drag-manager.js
|
|
node tests/unit/test-direct-rf-heard-by.js
|
|
node tests/unit/test-embed-mode-1369.js
|
|
node tests/unit/test-fetch-all-nodes-pagination.js
|
|
node tests/unit/test-fluid-scaffolding.js
|
|
node tests/unit/test-frontend-helpers.js
|
|
node tests/unit/test-geofilter-draft.js
|
|
node tests/unit/test-hash-color.js
|
|
node tests/unit/test-hop-resolver-affinity.js
|
|
node tests/unit/test-issue-1065-gesture-hints-gates.js
|
|
node tests/unit/test-issue-1107-live-layout.js
|
|
node tests/unit/test-issue-1136-observer-iata-map.js
|
|
node tests/unit/test-issue-1166-first-seen-column.js
|
|
node tests/unit/test-issue-1189-composed-cell.js
|
|
node tests/unit/test-issue-1189-live-iata-badge.js
|
|
node tests/unit/test-issue-1279-p2-code-filter.js
|
|
node tests/unit/test-issue-1293-marker-shapes.js
|
|
node tests/unit/test-issue-1356-map-a11y.js
|
|
node tests/unit/test-issue-1360-pill-letter-count.js
|
|
node tests/unit/test-issue-1361-cb-presets.js
|
|
node tests/unit/test-issue-1364-pill-no-clamp.js
|
|
node tests/unit/test-issue-1375-scope-stats-fetch.js
|
|
node tests/unit/test-issue-1380-cb-reset-button.js
|
|
node tests/unit/test-issue-1380-cb-sim-overlay.js
|
|
node tests/unit/test-issue-1407-cb-preset-propagation.js
|
|
node tests/unit/test-issue-1409-no-encrypted-flood.js
|
|
node tests/unit/test-issue-1412-customizer-no-override.js
|
|
node tests/unit/test-issue-1415-packets-layout.js
|
|
node tests/unit/test-issue-1418-cb-preset-ramp.js
|
|
node tests/unit/test-issue-1418-deeplink-hops-channels.js
|
|
node tests/unit/test-issue-1418-edge-weights.js
|
|
node tests/unit/test-issue-1418-polish-review.js
|
|
node tests/unit/test-issue-1418-raw-hex-extraction.js
|
|
node tests/unit/test-issue-1418-spider-fan.js
|
|
node tests/unit/test-issue-1420-tile-providers.js
|
|
node tests/unit/test-issue-1438-customizer-mcrole.js
|
|
node tests/unit/test-issue-1438-marker-css-vars.js
|
|
node tests/unit/test-issue-1446-cb-preset-cascade.js
|
|
node tests/unit/test-issue-1450-logo-aspect.js
|
|
node tests/unit/test-issue-1454-channels-toggle.js
|
|
node tests/unit/test-issue-1456-score-labels.js
|
|
node tests/unit/test-issue-1461-mobile-page-actions.js
|
|
node tests/unit/test-issue-1470-card-bg-contrast.js
|
|
node tests/unit/test-issue-1470-node-tile-helper.js
|
|
node tests/unit/test-issue-1473-prefix-generator.js
|
|
node tests/unit/test-issue-1473-reserved-prefixes.js
|
|
node tests/unit/test-issue-1485-live-anim-z.js
|
|
node tests/unit/test-issue-1488-marker-stroke-vars.js
|
|
node tests/unit/test-issue-1496-reset-all-complete.js
|
|
node tests/unit/test-issue-1509-detect-preset.js
|
|
node tests/unit/test-issue-1509-nav-active-bg.js
|
|
node tests/unit/test-issue-1518-home-url.js
|
|
node tests/unit/test-issue-1532-live-fullscreen.js
|
|
node tests/unit/test-issue-1562-observers-summary.js
|
|
node tests/unit/test-issue-1563-aggregate-and-inflight.js
|
|
node tests/unit/test-issue-1574-live-map-max-nodes.js
|
|
node tests/unit/test-issue-1606-pagination.js
|
|
node tests/unit/test-issue-1614-tile-url-function.js
|
|
node tests/unit/test-issue-1619-feed-detail-card-draggable.js
|
|
node tests/unit/test-issue-1633-hide-1byte-hops.js
|
|
node tests/unit/test-issue-1644-redesign.js
|
|
node tests/unit/test-issue-1646-compare-polish.js
|
|
node tests/unit/test-issue-1648-followup-phosphor-leaks.js
|
|
node tests/unit/test-issue-1648-m1-emoji-scan.js
|
|
node tests/unit/test-issue-1648-m2-emoji-scan.js
|
|
node tests/unit/test-issue-1648-m3-emoji-scan.js
|
|
node tests/unit/test-issue-1648-m4-emoji-scan.js
|
|
node tests/unit/test-issue-1648-m5-emoji-scan.js
|
|
node tests/unit/test-issue-1648-m6-final-sweep.js
|
|
node tests/unit/test-issue-1648-m6-lint-self.js
|
|
node tests/unit/test-issue-1668-m2-contrast.js
|
|
node tests/unit/test-issue-1668-m3-typography.js
|
|
node tests/unit/test-issue-1668-m4-per-route.js
|
|
node tests/unit/test-issue-1697-mqtt-mobile-e2e.js
|
|
node tests/unit/test-issue-1699-retransmission-chart.js
|
|
node tests/unit/test-issue-1705-subpath-contrast.js
|
|
node tests/unit/test-issue-1753-copy-url-slash.js
|
|
node tests/unit/test-issue-1770-mobile-row-clamp.js
|
|
node tests/unit/test-issue-1789-observer-firmware-cols.js
|
|
node tests/unit/test-issue-1825-observer-node-cross-links.js
|
|
node tests/unit/test-issue-1833-legend-toggle-vcr-offset.js
|
|
node tests/unit/test-issue-1836-crossnav-case-normalization.js
|
|
node tests/unit/test-issue-1843-node-qr-quiet-zone.js
|
|
node tests/unit/test-issue-1846-observers-width.js
|
|
node tests/unit/test-issue-1849-trace-hashbytes.js
|
|
node tests/unit/test-issue-1851-channel-message-scope.js
|
|
node tests/unit/test-issue-1862-map-region-filter.js
|
|
node tests/unit/test-issue-1868-control-decode.js
|
|
node tests/unit/test-packet-detail-channel-escape.js
|
|
node tests/unit/test-packet-detail-hash-size.js
|
|
node tests/unit/test-issue-1890-og-url.js
|
|
node tests/unit/test-issue-1956-release-routing.js
|
|
node tests/unit/test-issue-1979-scope-adverts-by-role.js
|
|
node tests/unit/test-issue-1997-distance-building.js
|
|
node tests/unit/test-issue-2042-recent-adverts-label.js
|
|
node tests/unit/test-issue-2001-map-scope-state.js
|
|
node tests/unit/test-issue-2012-clear-filters-selection.js
|
|
node tests/unit/test-issue-2095-channels-client-state.js
|
|
node tests/unit/test-issue-2097-hop-ambiguity-badge.js
|
|
node tests/unit/test-live-anims.js
|
|
node tests/unit/test-live-dt-cap-1524.js
|
|
node tests/unit/test-live-legend-helper.js
|
|
node tests/unit/test-live-multibyte-filter.js
|
|
node tests/unit/test-live-region-filter.js
|
|
node tests/unit/test-live.js
|
|
node tests/unit/test-map-clustering.js
|
|
node tests/unit/test-mqtt-status-panel.js
|
|
node tests/unit/test-my-repeaters-dashboard.js
|
|
node tests/unit/test-naive-banner-tone.js
|
|
node tests/unit/test-nav-stats-throttle.js
|
|
node tests/unit/test-node-hop-analytics.js
|
|
node tests/unit/test-node-reach-coverage-debounce.js
|
|
node tests/unit/test-node-reach-coverage.js
|
|
node tests/unit/test-nodes-export-wiring.js
|
|
node tests/unit/test-nav-drawer-version-footer.js
|
|
node tests/unit/test-nodes-export.js
|
|
node tests/unit/test-notifications-ui.js
|
|
node tests/unit/test-observer-iata-1188.js
|
|
node tests/unit/test-observer-menu-interactions.js
|
|
node tests/unit/test-observer-naive-clock-1478.js
|
|
node tests/unit/test-observer-search-filter.js
|
|
node tests/unit/test-observers-headings.js
|
|
node tests/unit/test-packet-filter-time.js
|
|
node tests/unit/test-packet-filter-ux.js
|
|
node tests/unit/test-packet-filter.js
|
|
node tests/unit/test-packets-local-channels.js
|
|
node tests/unit/test-packets.js
|
|
node tests/unit/test-panel-corner.js
|
|
node tests/unit/test-path-inspector.js
|
|
node tests/unit/test-payload-labels-content.js
|
|
node tests/unit/test-payload-labels-namespace.js
|
|
node tests/unit/test-perf-anomaly.js
|
|
node tests/unit/test-perf-disk-io-1120.js
|
|
node tests/unit/test-perf-go-runtime.js
|
|
node tests/unit/test-perf-render-1258.js
|
|
node tests/unit/test-preflight-xss-gate.js
|
|
node tests/unit/test-pull-to-reconnect-1091.js
|
|
node tests/unit/test-pull-to-reconnect.js
|
|
node tests/unit/test-region-filter-setselected.js
|
|
node tests/unit/test-repeater-metric-scatter.js
|
|
node tests/unit/test-rx-coverage-config-race.js
|
|
node tests/unit/test-rx-coverage-mine.js
|
|
node tests/unit/test-rx-coverage-escape.js
|
|
node tests/unit/test-rx-coverage-noise.js
|
|
node tests/unit/test-rx-coverage-viewport.js
|
|
node tests/unit/test-scope-audit-styles-linked.js
|
|
node tests/unit/test-settings-sync.js
|
|
node tests/unit/test-slideover-1056-rowsel-strict.js
|
|
node tests/unit/test-top-routes-overlay.js
|
|
node tests/unit/test-traces.js
|
|
node tests/unit/test-url-state.js
|
|
node tests/unit/test-user-management-ui.js
|
|
node tests/unit/test-warmup-banner.js
|
|
node tests/unit/test-ws-stale-watchdog-1074.js
|
|
node tests/unit/test-xss-escape-sinks.js
|
|
|
|
echo "All standalone frontend suites passed"
|