Kpa-clawbot 96a79ce9c1 fix(nav): floor Priority+ overflow at high-priority links — fixes nav vanishing on non-high routes (#1311) (#1312) ...

Red commit: `5f366b71` — CI: pending (will link once first run starts).

Fixes #1311

## The bug

`applyNavPriority` in `public/app.js` had no floor on the iterative
overflow loop:

```js
let i = 0;
while (!fits() && i < overflowQueue.length) {
  overflowQueue[i].classList.add('is-overflow');
  i++;
}
```

The `overflowQueue` is built non-high-first then high-priority tail.
When `fits()` kept returning `false` — because the active-route pill
renders wider than other links — the loop walked past the non-high tail
and started dropping high-priority links too. On a non-high active route
(`/#/perf`, `/#/audio-lab`, `/#/analytics`, `/#/observers`) at
~1101–1200px, this nuked Home/Packets/Map/Live/Nodes and left the user
with brand + "More ▾" + the active pill.

## Repro (master)

1. `go build ./cmd/server` and serve against the e2e fixture
2. Visit `http://localhost:13581/#/perf` at 1101px viewport
3. Inline strip shows only "More ▾" + the ⚡ Perf pill —
Home/Packets/Map/Live/Nodes are all gone
4. New E2E (`test-nav-priority-1311-e2e.js`) reproduces this: 4/16 cases
fail at 1101px on master.

## The fix

Two-line floor in the loop guard: break when the next queue item is a
high-priority link.

```js
while (!fits() && i < overflowQueue.length) {
  if (overflowQueue[i].dataset.priority === 'high') break;
  overflowQueue[i].classList.add('is-overflow');
  i++;
}
```

The `>=2` More-menu floor (#1139) gets the same guard — never promote a
high-priority link just to hit the floor. A degenerate 1-item dropdown
is a smaller paper-cut than nuking primary nav.

## TDD trail

- **RED commit `5f366b71`**: `test-nav-priority-1311-e2e.js` lands
first. Asserts (`assert.deepStrictEqual`) all 5 high-priority hrefs are
visible inline at 900/1024/1101/1200px on /#/perf, /#/audio-lab,
/#/analytics, /#/observers (16 cases). Fails 4/16 against master.
- **GREEN commit `6d1a5542`**: floor added; 16/16 pass. Existing nav
suite still green:
  - `test-nav-priority-1102-e2e.js`: 5/5 ✅
  - `test-nav-more-floor-1139-e2e.js`: 10/10 ✅
  - `test-nav-fluid-1055-e2e.js`: 20/20 ✅
- **Mutation guard**: stash the floor → test fails 4/16 again on the
same cases.

Browser verified: chromium 136 against local Go server with
`test-fixtures/e2e-fixture.db` at 900/1024/1101/1200px on each non-high
route.

E2E assertion added: `test-nav-priority-1311-e2e.js:107`
(`assert.deepStrictEqual`).

## Constraints respected

- Existing 5/5 inline behavior on /#/home (active route IS
high-priority) — preserved by 1102 suite ✅
- `<=1100` branch — unchanged (already data-priority-aware) ✅
- `>=2` More-menu floor (#1139) — preserved + extended with the same
high-pri guard ✅
- All colors via CSS vars ✅
- PII preflight clean ✅

---------

Co-authored-by: CoreScope Bot <bot@corescope>

2026-05-21 13:57:14 -07:00

..

deploy.yml

fix(nav): floor Priority+ overflow at high-priority links — fixes nav vanishing on non-high routes (#1311) (#1312)

2026-05-21 13:57:14 -07:00

squad-heartbeat.yml

chore: normalize all files to LF line endings

2026-03-30 22:52:46 -07:00

squad-issue-assign.yml

chore: normalize all files to LF line endings

2026-03-30 22:52:46 -07:00

squad-triage.yml

chore: normalize all files to LF line endings

2026-03-30 22:52:46 -07:00

sync-squad-labels.yml

chore: normalize all files to LF line endings

2026-03-30 22:52:46 -07:00