efiten and Claude Opus 5.5
abbe19531d
perf(paths): batch the resolved-path fallback for /nodes/{pk}/paths ( #2223 ) ( #2224 )
...
Fixes #2223 .
## Problem
`loadCanonicalResolvedPaths` reads the resolved path of each candidate's
longest observation in batches (#2146 ). A transmission whose longest
observation has no stored `resolved_path` then went through
`bestResolvedPath` on its own, with two queries:
- `fetchResolvedPathForObs` re-read that same observation, which the
batch had just read;
- `fetchResolvedPathsForTx` read all of the transmission's observations.
On a production database, 24% of the observations with a path have no
`resolved_path`, so most `/api/nodes/{pubkey}/paths` requests paid for
this once per such transmission.
## Change
- **`loadFallbackResolvedPaths` batches the fallback.** It reads those
transmissions' stored paths in one query per `resolvedPathBatchSize`
transmissions:
```sql
SELECT id, transmission_id, resolved_path FROM observations
WHERE resolved_path IS NOT NULL AND transmission_id IN (...)
```
On a production database the planner runs it as `SEARCH observations
USING INDEX idx_observations_tx_ts (transmission_id=?)`. It then picks
the observation `bestResolvedPath` would pick: the longest `path_json`
with a stored path, the first in snapshot order on a tie. The result
goes into the resolved-path LRU, as before.
- **`longestStoredResolvedPath`** holds that choice. `bestResolvedPath`
now uses it as well, so the rule exists in one place.
- **A failed batch still falls back.** If the first-stage batch fails,
it goes through `bestResolvedPath` per transmission, as before. A failed
fallback batch does the same for its transmissions.
The answer is the same as before, and no cache is added.
## Perf
Staging, 9 nodes, requests made from the host itself (`localhost:3001`),
so no proxy or TLS. Each node 3 times, after one warm-up round:
| | median | p90 | max | total for 27 requests |
|---|---|---|---|---|
| before | 0.174 s | 0.604 s | 0.866 s | 6.95 s |
| after | 0.079 s | 0.433 s | 0.484 s | 3.22 s |
CPU profile, 30 s each, under the same request loop:
- **Requests completed:** 180 before, 261 after.
- **CPU in `handleNodePaths` per request:** 154 ms before (27.77 s /
180), 107 ms after (27.90 s / 261).
- **Fallback cost:** `bestResolvedPath` took 13.56 s of
`loadCanonicalResolvedPaths` before. The batched
`loadFallbackResolvedPaths` takes 6.57 s.
Caveats:
- The before run was on a process that had been up longer than the after
run, so the two LRU states differ.
- One node (`060679ad…`, about 11k transmissions) did not change: 0.455
s against 0.451 s. Its time is elsewhere in the handler, and this PR
does not address it.
## Tests
- **`TestLoadCanonicalResolvedPathsBatchesFallback`:** 1,001
transmissions whose longest observation has no stored path.
- On master: 2,002 per-transmission queries.
- Now: 0 per-transmission queries and 6 batched ones (3 for the longest
observations, 3 for the fallback), with every path taken from the
shorter observation.
- **Existing tests:**
`TestLoadCanonicalResolvedPathsMatchesBestResolvedPath` still passes. It
covers the longest observation without a path (#810 ), ties, nothing
stored, an empty stored path, and an observation absent from the
snapshot. The LRU and query-count tests also still pass.
- `go vet` and `go test .` in `cmd/server` pass.
No frontend change.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com >
2026-10-21 11:58:28 +02:00
..
2026-04-21 09:09:39 -07:00
2026-10-10 18:20:49 +02:00
2026-10-08 22:16:49 +02:00
2026-10-10 18:20:49 +02:00
2026-10-07 09:25:29 +02:00
2026-10-07 09:25:29 +02:00
2026-10-08 21:38:30 +02:00
2026-10-08 21:38:30 +02:00
2026-10-10 18:20:49 +02:00
2026-10-08 22:02:39 +02:00
2026-10-08 21:38:30 +02:00
2026-10-10 18:20:49 +02:00
2026-10-08 21:38:30 +02:00
2026-10-03 12:16:55 +02:00
2026-04-03 13:51:13 -07:00
2026-10-03 12:16:55 +02:00
2026-10-03 12:16:55 +02:00
2026-10-03 12:16:55 +02:00
2026-10-03 12:16:55 +02:00
2026-10-11 09:51:48 +02:00
2026-09-22 07:55:37 +02:00
2026-05-21 14:00:15 -07:00
2026-10-11 09:51:48 +02:00
2026-09-13 19:59:37 +02:00
2026-09-13 19:59:37 +02:00
2026-09-04 16:02:59 +02:00
2026-10-17 11:46:18 +02:00
2026-10-07 09:25:29 +02:00
2026-10-08 22:02:39 +02:00
2026-10-08 22:02:39 +02:00
2026-10-08 21:38:30 +02:00
2026-10-07 09:25:29 +02:00
2026-10-20 14:53:26 +02:00
2026-10-10 18:08:51 +02:00
2026-10-08 21:38:30 +02:00
2026-10-08 22:02:39 +02:00
2026-10-08 22:02:39 +02:00
2026-10-07 09:25:29 +02:00
2026-10-07 11:20:44 +02:00
2026-10-20 14:53:26 +02:00
2026-10-11 11:28:20 +02:00
2026-10-11 11:28:20 +02:00
2026-10-10 18:20:49 +02:00
2026-10-10 18:20:49 +02:00
2026-05-03 17:56:42 -07:00
2026-05-03 17:56:42 -07:00
2026-10-10 18:20:49 +02:00
2026-10-08 16:26:10 +02:00
2026-09-16 09:02:13 +02:00
2026-05-18 22:51:23 -07:00
2026-05-18 22:51:23 -07:00
2026-05-18 22:51:23 -07:00
2026-06-27 22:03:05 -07:00
2026-10-17 11:46:18 +02:00
2026-06-04 03:21:26 -07:00
2026-09-03 18:52:03 +02:00
2026-10-09 19:58:42 +02:00
2026-10-09 19:58:42 +02:00
2026-06-04 13:14:09 +00:00
2026-09-03 18:52:03 +02:00
2026-10-17 11:46:18 +02:00
2026-04-20 21:46:34 -07:00
2026-10-05 20:32:40 +02:00
2026-09-13 20:36:34 +02:00
2026-09-03 18:52:03 +02:00
2026-05-25 22:16:14 -07:00
2026-06-07 03:43:29 -07:00
2026-09-16 09:02:13 +02:00
2026-09-16 09:02:13 +02:00
2026-09-03 18:52:03 +02:00
2026-10-17 11:46:23 +02:00
2026-06-03 13:58:04 -07:00
2026-06-06 22:45:05 -07:00
2026-10-10 18:20:49 +02:00
2026-09-02 09:50:18 +02:00
2026-09-03 18:52:03 +02:00
2026-09-02 09:50:18 +02:00
2026-05-18 12:27:44 -07:00
2026-09-03 18:52:03 +02:00
2026-09-13 19:59:37 +02:00
2026-05-21 14:00:15 -07:00
2026-10-10 18:20:49 +02:00
2026-10-10 18:20:49 +02:00
2026-10-10 18:20:49 +02:00
2026-10-10 18:20:49 +02:00
2026-05-21 11:39:49 -07:00
2026-05-21 11:39:49 -07:00
2026-05-21 11:39:49 -07:00
2026-09-03 18:52:03 +02:00
2026-10-10 21:20:40 +02:00
2026-10-13 08:44:49 +02:00
2026-10-13 08:44:49 +02:00
2026-10-13 08:44:49 +02:00
2026-10-13 08:44:49 +02:00
2026-06-06 22:45:05 -07:00
2026-10-16 09:26:45 +02:00
2026-10-10 18:20:49 +02:00
2026-05-30 13:22:41 -07:00
2026-05-30 13:22:41 -07:00
2026-10-10 18:20:49 +02:00
2026-06-19 11:37:16 -07:00
2026-06-27 22:03:05 -07:00
2026-06-27 22:03:05 -07:00
2026-10-17 11:46:18 +02:00
2026-06-04 14:41:00 -07:00
2026-09-02 13:10:43 +00:00
2026-09-23 10:05:59 +02:00
2026-10-14 21:07:20 +02:00
2026-10-14 21:07:20 +02:00
2026-10-15 10:30:28 +02:00
2026-06-12 19:10:44 -07:00
2026-05-15 22:34:21 -07:00
2026-09-03 18:52:03 +02:00
2026-09-03 18:52:03 +02:00
2026-10-10 18:20:49 +02:00
2026-10-10 18:20:49 +02:00
2026-09-22 23:55:55 +02:00
2026-10-11 09:51:48 +02:00
2026-05-05 01:16:57 -07:00
2026-09-03 18:52:03 +02:00
2026-06-29 15:53:59 -07:00
2026-09-17 21:58:34 +02:00
2026-04-16 00:09:36 -07:00
2026-09-20 15:12:36 +02:00
2026-10-17 11:46:23 +02:00
2026-10-17 11:46:18 +02:00
2026-06-04 16:27:48 -07:00
2026-05-05 01:58:52 -07:00
2026-05-19 23:53:41 -07:00
2026-03-31 01:10:56 -07:00
2026-09-05 09:57:44 +02:00
2026-10-08 21:51:42 +02:00
2026-10-07 09:25:29 +02:00
2026-06-27 22:03:05 -07:00
2026-09-04 15:15:16 +02:00
2026-09-04 15:15:16 +02:00
2026-09-03 18:52:03 +02:00
2026-06-07 09:28:51 -07:00
2026-04-03 13:11:59 -07:00
2026-06-19 11:37:16 -07:00
2026-09-16 09:02:13 +02:00
2026-06-11 10:10:12 -07:00
2026-06-11 10:10:12 -07:00
2026-10-12 12:42:17 +02:00
2026-05-15 16:21:14 +00:00
2026-05-16 19:55:00 +00:00
2026-09-03 18:52:03 +02:00
2026-05-15 20:24:55 -07:00
2026-05-15 22:46:25 -07:00
2026-09-16 09:02:13 +02:00
2026-09-06 21:00:44 +02:00
2026-10-12 12:41:46 +02:00
2026-10-13 08:37:54 +02:00
2026-09-16 09:02:13 +02:00
2026-05-21 14:00:15 -07:00
2026-10-09 19:58:42 +02:00
2026-05-02 20:35:15 -07:00
2026-05-17 16:13:11 +00:00
2026-05-19 08:08:28 -07:00
2026-05-18 23:19:27 -07:00
2026-09-16 09:02:13 +02:00
2026-06-25 05:05:46 -07:00
2026-09-16 09:02:13 +02:00
2026-06-11 07:38:36 -07:00
2026-09-03 18:52:03 +02:00
2026-06-11 07:38:36 -07:00
2026-06-06 22:44:59 -07:00
2026-09-16 09:02:13 +02:00
2026-09-16 09:02:13 +02:00
2026-10-12 11:13:53 +02:00
2026-09-16 09:02:13 +02:00
2026-09-16 09:02:13 +02:00
2026-10-11 11:28:20 +02:00
2026-10-11 11:28:20 +02:00
2026-10-16 09:26:45 +02:00
2026-09-03 18:52:03 +02:00
2026-09-16 09:02:13 +02:00
2026-09-16 09:02:13 +02:00
2026-09-02 10:27:48 +02:00
2026-06-30 15:16:31 -07:00
2026-06-12 08:11:02 -07:00
2026-09-02 10:27:48 +02:00
2026-10-08 15:58:07 +02:00
2026-09-16 09:02:13 +02:00
2026-05-03 08:56:09 -07:00
2026-05-21 14:00:15 -07:00
2026-09-16 09:02:13 +02:00
2026-09-03 18:52:03 +02:00
2026-04-02 23:45:03 -07:00
2026-09-03 18:52:03 +02:00
2026-09-03 18:52:03 +02:00
2026-05-29 02:42:21 -07:00
2026-05-29 02:42:21 -07:00
2026-05-29 02:42:21 -07:00
2026-05-29 02:42:21 -07:00
2026-05-16 10:14:44 -07:00
2026-10-17 11:46:18 +02:00
2026-10-20 10:41:01 +02:00
2026-09-16 09:02:13 +02:00
2026-10-17 11:46:23 +02:00
2026-09-16 09:02:13 +02:00
2026-05-19 23:53:41 -07:00
2026-10-16 09:27:21 +02:00
2026-10-10 11:03:56 +02:00
2026-10-10 11:03:56 +02:00
2026-09-03 18:52:03 +02:00
2026-09-13 21:09:51 +02:00
2026-09-22 07:55:37 +02:00
2026-09-22 07:55:37 +02:00
2026-10-16 10:53:10 +02:00
2026-10-15 16:31:00 +02:00
2026-09-13 19:59:56 +02:00
2026-10-16 09:27:21 +02:00
2026-09-16 09:02:13 +02:00
2026-06-09 03:23:48 -07:00
2026-10-08 16:26:15 +02:00
2026-09-16 09:02:13 +02:00
2026-10-19 00:36:51 +02:00
2026-10-19 00:36:51 +02:00
2026-10-09 21:20:34 +02:00
2026-10-19 00:36:51 +02:00
2026-06-19 11:37:16 -07:00
2026-06-19 11:37:16 -07:00
2026-10-17 11:46:18 +02:00
2026-09-23 09:45:18 +02:00
2026-05-18 09:22:27 -07:00
2026-09-03 18:52:03 +02:00
2026-10-10 21:21:50 +02:00
2026-10-08 22:02:39 +02:00
2026-10-10 20:54:35 +02:00
2026-10-10 20:54:35 +02:00
2026-10-10 20:54:35 +02:00
2026-10-10 18:20:49 +02:00
2026-10-10 20:54:35 +02:00
2026-10-10 20:54:35 +02:00
2026-10-10 20:54:35 +02:00
2026-10-08 22:02:39 +02:00
2026-10-10 20:54:35 +02:00
2026-10-11 14:31:12 +02:00
2026-10-11 14:31:12 +02:00
2026-10-13 09:01:57 +02:00
2026-09-22 11:08:17 +02:00
2026-10-14 21:07:20 +02:00
2026-10-14 21:07:20 +02:00
2026-09-03 18:52:03 +02:00
2026-10-20 10:41:01 +02:00
2026-09-03 18:52:03 +02:00
2026-09-02 09:50:26 +02:00
2026-05-29 01:08:12 -07:00
2026-05-29 01:08:12 -07:00
2026-10-13 08:37:54 +02:00
2026-05-29 02:42:21 -07:00
2026-05-29 02:42:21 -07:00
2026-09-03 18:52:03 +02:00
2026-09-03 18:52:03 +02:00
2026-10-10 17:39:33 +02:00
2026-07-07 00:12:44 -07:00
2026-09-03 18:52:03 +02:00
2026-10-16 09:26:45 +02:00
2026-10-20 10:41:01 +02:00
2026-05-17 16:13:11 +00:00
2026-05-25 22:32:00 -07:00
2026-06-04 23:48:47 -07:00
2026-10-05 20:32:40 +02:00
2026-05-15 22:46:28 -07:00
2026-05-15 22:46:28 -07:00
2026-05-15 22:46:28 -07:00
2026-05-15 22:46:28 -07:00
2026-05-15 22:46:28 -07:00
2026-09-02 09:50:09 +02:00
2026-09-03 18:52:03 +02:00
2026-10-12 12:45:41 +02:00
2026-10-08 14:34:31 +02:00
2026-10-08 14:34:31 +02:00
2026-10-12 12:41:46 +02:00
2026-09-02 14:34:20 +02:00
2026-10-08 14:34:31 +02:00
2026-10-09 19:58:42 +02:00
2026-10-21 11:58:28 +02:00
2026-09-30 11:39:25 +02:00
2026-10-09 19:58:42 +02:00
2026-09-30 11:39:25 +02:00
2026-09-30 11:39:25 +02:00
2026-09-30 11:39:25 +02:00
2026-09-03 18:52:03 +02:00
2026-09-03 18:52:03 +02:00
2026-05-08 16:29:23 -07:00
2026-05-08 16:29:23 -07:00
2026-06-07 09:28:51 -07:00
2026-05-05 17:56:56 -07:00
2026-09-16 09:02:13 +02:00
2026-04-01 19:26:11 -07:00
2026-06-06 22:45:05 -07:00
2026-05-15 09:16:39 -07:00
2026-09-16 09:02:13 +02:00
2026-10-10 18:20:49 +02:00
2026-10-08 21:51:42 +02:00
2026-10-08 21:51:42 +02:00
2026-10-07 09:25:29 +02:00
2026-06-27 22:03:05 -07:00
2026-06-27 22:03:05 -07:00
2026-05-03 19:50:01 -07:00
2026-10-10 21:21:50 +02:00
2026-10-15 16:31:00 +02:00
2026-10-10 21:23:05 +02:00
2026-10-03 12:16:55 +02:00
2026-10-17 11:46:18 +02:00
2026-10-03 12:16:55 +02:00
2026-10-13 15:42:18 +02:00
2026-05-21 11:39:43 -07:00
2026-05-20 20:57:02 -07:00
2026-09-03 18:52:03 +02:00
2026-05-28 15:01:58 -07:00
2026-10-08 14:34:31 +02:00
2026-06-06 20:46:42 -07:00
2026-06-06 20:46:42 -07:00
2026-07-08 15:13:39 -07:00
2026-09-02 18:34:59 +02:00
2026-10-12 12:41:46 +02:00
2026-05-20 20:57:02 -07:00
2026-10-08 14:34:31 +02:00
2026-10-07 09:25:29 +02:00
2026-05-15 16:21:14 +00:00
2026-05-15 09:16:39 -07:00
2026-09-03 18:52:03 +02:00
2026-09-03 18:52:03 +02:00
2026-10-17 11:46:18 +02:00
2026-10-21 11:58:28 +02:00
2026-10-09 19:58:42 +02:00
2026-10-17 11:46:23 +02:00
2026-10-17 11:46:23 +02:00
2026-10-13 09:01:57 +02:00
2026-09-13 20:37:14 +02:00
2026-10-04 22:11:34 +02:00
2026-10-04 22:11:34 +02:00
2026-10-16 09:26:45 +02:00
2026-10-16 09:26:45 +02:00
2026-10-16 09:26:45 +02:00
2026-05-18 07:36:28 -07:00
2026-05-03 17:56:12 -07:00
2026-09-03 18:52:03 +02:00
2026-10-17 11:46:18 +02:00
2026-10-20 10:41:01 +02:00
2026-10-15 10:30:08 +02:00
2026-09-03 18:52:03 +02:00
2026-06-19 11:37:16 -07:00
2026-10-10 17:39:33 +02:00
2026-10-10 17:39:33 +02:00
2026-10-10 18:20:49 +02:00
2026-10-04 17:15:50 +02:00
2026-10-10 17:39:33 +02:00
2026-10-10 18:20:49 +02:00
2026-10-10 18:20:49 +02:00
2026-05-15 16:21:14 +00:00
2026-10-11 11:17:12 +02:00
2026-09-19 11:44:47 +02:00
2026-10-11 11:17:12 +02:00
2026-09-11 15:07:31 +02:00
2026-09-11 15:07:31 +02:00
2026-09-19 11:44:47 +02:00
2026-10-10 21:22:02 +02:00
2026-10-11 11:17:12 +02:00
2026-09-09 17:58:09 +02:00
2026-09-10 22:30:24 +02:00
2026-10-07 11:20:44 +02:00
2026-10-07 11:20:44 +02:00
2026-10-07 11:20:44 +02:00
2026-10-07 11:20:44 +02:00
2026-05-03 17:40:54 -07:00
2026-06-03 13:58:04 -07:00
2026-06-30 18:21:21 -07:00
2026-04-20 23:10:33 -07:00
2026-10-20 11:04:07 +02:00
2026-10-09 19:58:42 +02:00
2026-10-20 11:04:07 +02:00
2026-10-09 19:58:42 +02:00
2026-10-20 10:41:01 +02:00
2026-04-21 09:09:39 -07:00
2026-10-20 11:04:07 +02:00
2026-05-29 02:42:21 -07:00
2026-10-12 12:41:46 +02:00
2026-10-13 08:35:16 +02:00
2026-10-12 12:41:46 +02:00
2026-10-10 21:21:13 +02:00
2026-05-03 17:41:22 -07:00
2026-05-03 17:41:22 -07:00
2026-09-16 09:02:13 +02:00
2026-10-12 12:41:46 +02:00
2026-06-27 22:03:05 -07:00
2026-09-02 18:34:59 +02:00
2026-10-13 08:35:20 +02:00
2026-10-13 08:35:20 +02:00
2026-10-16 09:27:21 +02:00
2026-06-27 22:03:05 -07:00
2026-06-27 22:03:05 -07:00
2026-06-27 22:03:05 -07:00
2026-06-27 22:03:05 -07:00
2026-10-11 11:28:20 +02:00
2026-10-11 11:28:20 +02:00
2026-10-10 18:20:49 +02:00
2026-10-08 22:16:49 +02:00
2026-10-08 22:16:49 +02:00
2026-06-29 05:48:58 -07:00
2026-09-13 19:59:18 +02:00
2026-09-13 19:59:18 +02:00
2026-09-06 21:11:29 +02:00
2026-09-06 21:11:29 +02:00
2026-09-02 14:21:42 +02:00