mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-10-12 08:37:25 +00:00
Part C of #2128: an admin area with an overview, the user table and a global audit log. Off by default like the rest of user management: with `userManagement` off nothing changes, and non-admins get no new UI. This is the first of 4 stacked PRs (C, D, E, then a small export/backup follow-up). Each later one contains this branch; review them in order. ## The situation - An admin could manage users one by one in `#/admin/users`, but nothing showed whether the instance needs attention: accounts stuck in activation, bouncing mail, someone guessing a password, an MQTT source that dropped. - The audit log existed (`internal/users/audit.go`) but could only be read per user, and logins were not recorded. ## What this PR adds **Store (`internal/users`)** - Schema v3: an index on `audit_log(at)`. - `AuditList` with filters (action or group prefix like `user.login.*`, user as actor or target, period) and keyset pagination; `PruneAudit`; `Stats` for the user figures. **Server** - `GET /api/admin/stats` (typed struct): accounts by status, admins, registrations and active users over 7 and 30 days, logins and failed logins in 24 hours, mail by final status, and the attention items computed server-side. - `GET /api/admin/audit`: filtered, newest first, `next` cursor. - `GET /api/admin/users` gains `bouncing=1`. - Logins are audited as `user.login` and `user.login.failed` (reason `wrong_password`, `pending` or `disabled`). An unknown address writes no row. The writes are asynchronous, so the login response does not wait on `users.db`. Login rows are pruned after 90 days. **Frontend** - `#/admin?tab=overview|users|audit`: `admin.js` (tab shell), `admin-overview.js` ("Needs attention", Users card, System card from the existing health, MQTT and observer endpoints), `admin-audit.js` (filters in the URL, "Load more"). `admin-users.js` becomes the Users tab; the old `#/admin/users` link rewrites to it. - `/api/healthz` is read on open and on Refresh only, not on the 60-second timer, because it walks every packet under a read lock. Spec: [`docs/specs/2026-10-07-admin-dashboard-design.md`](https://github.com/efiten/CoreScope/blob/feat/admin-dashboard/docs/specs/2026-10-07-admin-dashboard-design.md). ## Verification - `internal/users` and `cmd/server`: `go vet` and `go test` pass locally, 26 new Go tests. One upstream test, `TestSaveGeoFilterPreservesFileMode`, also fails on Windows on plain `master` (file modes) and is unrelated. - `sh test-all.sh` exits 0; the XSS gate in diff mode passes. - User-management E2E with the `e2etest` build: 13 of 13 steps locally. - Running on our staging and production instance since 7 October 2026. ## Not in this PR - Restricting existing pages (perf, MQTT status) to logged-in users or admins. The admin area adds no access mechanism of its own, so that stays a later router rule plus endpoint check. - Server-enforced customizer tab restrictions (#1508). - The 24-hour, 5-attempt and 10-minute attention thresholds are constants for now (AGENTS.md rule 8: customizer later). --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
337 lines
11 KiB
Go
337 lines
11 KiB
Go
package main
|
|
|
|
import (
|
|
"errors"
|
|
"log"
|
|
"net/http"
|
|
"strconv"
|
|
"time"
|
|
|
|
"github.com/gorilla/mux"
|
|
"github.com/meshcore-analyzer/mailer"
|
|
"github.com/meshcore-analyzer/users"
|
|
)
|
|
|
|
// adminStoreFail answers a failed store call: ErrNotFound is 404, anything
|
|
// else is logged (user id only) and answered 500.
|
|
func adminStoreFail(w http.ResponseWriter, op string, id int64, err error) {
|
|
if errors.Is(err, users.ErrNotFound) {
|
|
writeError(w, http.StatusNotFound, "user not found")
|
|
return
|
|
}
|
|
log.Printf("[users] admin %s for user #%d: %v", op, id, err)
|
|
writeError(w, http.StatusInternalServerError, "internal error")
|
|
}
|
|
|
|
// adminTarget loads {id} from the path; writes 400/404/500 and returns nil
|
|
// on failure.
|
|
func (s *Server) adminTarget(w http.ResponseWriter, r *http.Request) *users.User {
|
|
id, err := strconv.ParseInt(mux.Vars(r)["id"], 10, 64)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid user id")
|
|
return nil
|
|
}
|
|
u, err := s.auth.st.GetByID(id)
|
|
if err != nil {
|
|
adminStoreFail(w, "load", id, err)
|
|
return nil
|
|
}
|
|
return u
|
|
}
|
|
|
|
// guardRemoval blocks disabling/deleting/demoting yourself (except a
|
|
// self-demotion, allowed via allowSelf), config admins, and the last active
|
|
// admin. Writes 409 (or 500 if the admin count fails) and returns false
|
|
// when blocked. Count-then-mutate is not atomic; two admins removing each
|
|
// other concurrently can still both pass.
|
|
func (s *Server) guardRemoval(w http.ResponseWriter, actor, target *users.User, allowSelf bool) bool {
|
|
if target.ID == actor.ID && !allowSelf {
|
|
writeError(w, http.StatusConflict, "use My account to change your own account")
|
|
return false
|
|
}
|
|
if target.Role == users.RoleAdmin && s.auth.isConfigAdmin(target.Email) {
|
|
writeError(w, http.StatusConflict, "this admin is listed in adminEmails; remove them from the config first")
|
|
return false
|
|
}
|
|
if target.Role == users.RoleAdmin && target.Status == users.StatusActive {
|
|
n, err := s.auth.st.CountActiveAdmins()
|
|
if err != nil {
|
|
log.Printf("[users] admin guard: count admins for user #%d: %v", target.ID, err)
|
|
writeError(w, http.StatusInternalServerError, "internal error")
|
|
return false
|
|
}
|
|
if n <= 1 {
|
|
writeError(w, http.StatusConflict, "this is the last admin; promote someone else first")
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|
|
|
|
func (s *Server) writeAdminRow(w http.ResponseWriter, id int64) {
|
|
u, err := s.auth.st.GetByID(id)
|
|
if err != nil {
|
|
adminStoreFail(w, "reload", id, err)
|
|
return
|
|
}
|
|
last, err := s.auth.st.LatestMailByUser()
|
|
if err != nil {
|
|
log.Printf("[users] admin latest mail: %v", err)
|
|
}
|
|
writeJSON(w, s.auth.adminRow(*u, last))
|
|
}
|
|
|
|
func (s *Server) handleAdminUsers(w http.ResponseWriter, r *http.Request, _ *users.User, _ *users.Session) {
|
|
q := r.URL.Query()
|
|
f := users.ListFilter{Status: users.Status(q.Get("status")), Role: users.Role(q.Get("role")), Query: q.Get("q")}
|
|
switch f.Status {
|
|
case "", users.StatusPending, users.StatusActive, users.StatusDisabled:
|
|
default:
|
|
writeError(w, http.StatusBadRequest, "invalid status filter")
|
|
return
|
|
}
|
|
if f.Role != "" && !f.Role.Valid() {
|
|
writeError(w, http.StatusBadRequest, "invalid role filter")
|
|
return
|
|
}
|
|
switch q.Get("bouncing") {
|
|
case "":
|
|
case "1":
|
|
f.Bouncing = true
|
|
default:
|
|
writeError(w, http.StatusBadRequest, "invalid bouncing filter")
|
|
return
|
|
}
|
|
list, err := s.auth.st.List(f)
|
|
if err != nil {
|
|
log.Printf("[users] admin list: %v", err)
|
|
writeError(w, http.StatusInternalServerError, "internal error")
|
|
return
|
|
}
|
|
last, err := s.auth.st.LatestMailByUser()
|
|
if err != nil {
|
|
log.Printf("[users] admin latest mail: %v", err)
|
|
}
|
|
out := make([]adminUserJSON, 0, len(list))
|
|
for _, u := range list {
|
|
out = append(out, s.auth.adminRow(u, last))
|
|
}
|
|
writeJSON(w, out)
|
|
}
|
|
|
|
func (s *Server) handleAdminUserDetail(w http.ResponseWriter, r *http.Request, _ *users.User, _ *users.Session) {
|
|
u := s.adminTarget(w, r)
|
|
if u == nil {
|
|
return
|
|
}
|
|
a := s.auth
|
|
last, err := a.st.LatestMailByUser()
|
|
if err != nil {
|
|
log.Printf("[users] admin latest mail: %v", err)
|
|
}
|
|
d := adminUserDetailJSON{User: a.adminRow(*u, last), Sessions: []sessionJSON{}, Mail: []mailJSON{}, Audit: []auditJSON{}}
|
|
list, err := a.st.ListSessions(u.ID)
|
|
if err != nil {
|
|
adminStoreFail(w, "list sessions", u.ID, err)
|
|
return
|
|
}
|
|
for _, x := range list {
|
|
d.Sessions = append(d.Sessions, sessionToJSON(x, 0))
|
|
}
|
|
mails, err := a.st.MailForUser(u.ID, 50)
|
|
if err != nil {
|
|
adminStoreFail(w, "list mail", u.ID, err)
|
|
return
|
|
}
|
|
for _, m := range mails {
|
|
d.Mail = append(d.Mail, mailToJSON(m))
|
|
}
|
|
entries, err := a.st.AuditFor(u.ID, 100)
|
|
if err != nil {
|
|
adminStoreFail(w, "list audit", u.ID, err)
|
|
return
|
|
}
|
|
for _, e := range entries {
|
|
d.Audit = append(d.Audit, auditJSON{ID: e.ID, At: rfc3339(e.At), ActorUserID: e.ActorUserID,
|
|
Action: e.Action, TargetUserID: e.TargetUserID, Detail: e.Detail})
|
|
}
|
|
writeJSON(w, d)
|
|
}
|
|
|
|
func (s *Server) handleAdminDisable(w http.ResponseWriter, r *http.Request, actor *users.User, _ *users.Session) {
|
|
t := s.adminTarget(w, r)
|
|
if t == nil || !s.guardRemoval(w, actor, t, false) {
|
|
return
|
|
}
|
|
if t.Status != users.StatusActive {
|
|
writeError(w, http.StatusConflict, "only active accounts can be disabled; delete or activate a pending account instead")
|
|
return
|
|
}
|
|
if err := s.auth.invalidateTokens("disable", t.ID, users.PurposeActivate, users.PurposeReset, users.PurposeEmailChange); err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal error")
|
|
return
|
|
}
|
|
if err := s.auth.st.SetStatus(t.ID, users.StatusDisabled); err != nil {
|
|
adminStoreFail(w, "disable", t.ID, err)
|
|
return
|
|
}
|
|
if err := s.auth.st.DeleteUserSessions(t.ID, 0); err != nil {
|
|
// currentUser rejects non-active users, so the sessions are dead
|
|
// anyway; keep going but leave a trace.
|
|
log.Printf("[users] disable: delete sessions for user #%d: %v", t.ID, err)
|
|
}
|
|
s.auth.audit(idPtr(actor.ID), "user.disable", idPtr(t.ID), nil)
|
|
s.writeAdminRow(w, t.ID)
|
|
}
|
|
|
|
func (s *Server) handleAdminEnable(w http.ResponseWriter, r *http.Request, actor *users.User, _ *users.Session) {
|
|
t := s.adminTarget(w, r)
|
|
if t == nil {
|
|
return
|
|
}
|
|
if t.Status != users.StatusDisabled {
|
|
writeError(w, http.StatusConflict, "only disabled accounts can be enabled")
|
|
return
|
|
}
|
|
if err := s.auth.st.SetStatus(t.ID, users.StatusActive); err != nil {
|
|
adminStoreFail(w, "enable", t.ID, err)
|
|
return
|
|
}
|
|
s.auth.audit(idPtr(actor.ID), "user.enable", idPtr(t.ID), nil)
|
|
s.writeAdminRow(w, t.ID)
|
|
}
|
|
|
|
func (s *Server) handleAdminDelete(w http.ResponseWriter, r *http.Request, actor *users.User, _ *users.Session) {
|
|
t := s.adminTarget(w, r)
|
|
if t == nil || !s.guardRemoval(w, actor, t, false) {
|
|
return
|
|
}
|
|
if err := s.auth.st.Delete(t.ID); err != nil {
|
|
adminStoreFail(w, "delete", t.ID, err)
|
|
return
|
|
}
|
|
s.auth.audit(idPtr(actor.ID), "user.delete", idPtr(t.ID), nil)
|
|
writeJSON(w, okResponse{OK: true})
|
|
}
|
|
|
|
func (s *Server) handleAdminRole(w http.ResponseWriter, r *http.Request, actor *users.User, _ *users.Session) {
|
|
t := s.adminTarget(w, r)
|
|
if t == nil {
|
|
return
|
|
}
|
|
var req roleRequest
|
|
if !decodeJSON(w, r, &req) {
|
|
return
|
|
}
|
|
if !req.Role.Valid() {
|
|
writeError(w, http.StatusBadRequest, "role must be user or admin")
|
|
return
|
|
}
|
|
// Activation sets the role from adminEmails, so a change now would be
|
|
// silently lost.
|
|
if t.Status == users.StatusPending {
|
|
writeError(w, http.StatusConflict, "activate the account first")
|
|
return
|
|
}
|
|
if req.Role == t.Role {
|
|
s.writeAdminRow(w, t.ID)
|
|
return
|
|
}
|
|
if req.Role == users.RoleUser && !s.guardRemoval(w, actor, t, true) {
|
|
return
|
|
}
|
|
if err := s.auth.st.SetRole(t.ID, req.Role); err != nil {
|
|
adminStoreFail(w, "set role", t.ID, err)
|
|
return
|
|
}
|
|
s.auth.audit(idPtr(actor.ID), "user.role", idPtr(t.ID), map[string]string{"role": string(req.Role)})
|
|
s.writeAdminRow(w, t.ID)
|
|
}
|
|
|
|
func (s *Server) handleAdminResendActivation(w http.ResponseWriter, r *http.Request, actor *users.User, _ *users.Session) {
|
|
a := s.auth
|
|
t := s.adminTarget(w, r)
|
|
if t == nil {
|
|
return
|
|
}
|
|
if t.Status != users.StatusPending {
|
|
writeError(w, http.StatusConflict, "only pending accounts need activation")
|
|
return
|
|
}
|
|
if err := a.mailToken(r.Context(), t, users.PurposeActivate, 48*time.Hour, "", "activate",
|
|
func(tok string) mailer.Message { return a.activationMail(t, tok) }); err != nil {
|
|
writeError(w, http.StatusServiceUnavailable, msgMailFailed)
|
|
return
|
|
}
|
|
a.audit(idPtr(actor.ID), "user.activation.resend", idPtr(t.ID), nil)
|
|
s.writeAdminRow(w, t.ID)
|
|
}
|
|
|
|
// handleAdminActivate activates a pending user without the mail link, for
|
|
// when mail keeps failing. The address stays unverified; activated_by and
|
|
// the audit row keep that visible.
|
|
func (s *Server) handleAdminActivate(w http.ResponseWriter, r *http.Request, actor *users.User, _ *users.Session) {
|
|
a := s.auth
|
|
t := s.adminTarget(w, r)
|
|
if t == nil {
|
|
return
|
|
}
|
|
if t.Status != users.StatusPending {
|
|
writeError(w, http.StatusConflict, "only pending accounts can be activated")
|
|
return
|
|
}
|
|
if err := a.st.InvalidateTokens(t.ID, users.PurposeActivate); err != nil {
|
|
log.Printf("[users] manual activate: invalidate tokens for user #%d: %v", t.ID, err)
|
|
writeError(w, http.StatusInternalServerError, "internal error")
|
|
return
|
|
}
|
|
if err := a.st.Activate(t.ID, a.roleFor(t.Email), idPtr(actor.ID)); err != nil {
|
|
adminStoreFail(w, "activate", t.ID, err)
|
|
return
|
|
}
|
|
a.audit(idPtr(actor.ID), "user.activate.manual", idPtr(t.ID), nil)
|
|
s.writeAdminRow(w, t.ID)
|
|
}
|
|
|
|
func (s *Server) handleAdminMailRefresh(w http.ResponseWriter, r *http.Request, actor *users.User, _ *users.Session) {
|
|
a := s.auth
|
|
t := s.adminTarget(w, r)
|
|
if t == nil {
|
|
return
|
|
}
|
|
mailID, err := strconv.ParseInt(mux.Vars(r)["mailId"], 10, 64)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid mail id")
|
|
return
|
|
}
|
|
rec, err := a.st.MailByID(mailID)
|
|
if err != nil && !errors.Is(err, users.ErrNotFound) {
|
|
log.Printf("[users] admin mail refresh: load mail %d for user #%d: %v", mailID, t.ID, err)
|
|
writeError(w, http.StatusInternalServerError, "internal error")
|
|
return
|
|
}
|
|
if err != nil || rec.UserID == nil || *rec.UserID != t.ID {
|
|
writeError(w, http.StatusNotFound, "mail not found")
|
|
return
|
|
}
|
|
if rec.ProviderMessageID == "" {
|
|
writeError(w, http.StatusConflict, "this mail has no provider message id")
|
|
return
|
|
}
|
|
evs, err := a.mail.Events(r.Context(), rec.ProviderMessageID)
|
|
if err != nil {
|
|
log.Printf("[users] admin mail refresh: provider events for user #%d: %s", t.ID, redactAddrs(err))
|
|
writeError(w, http.StatusBadGateway, "mail provider unavailable")
|
|
return
|
|
}
|
|
a.ingestMailEvents(evs)
|
|
a.audit(idPtr(actor.ID), "user.mail.refresh", idPtr(t.ID), nil)
|
|
rec, err = a.st.MailByID(mailID)
|
|
if err != nil {
|
|
log.Printf("[users] admin mail refresh: reload mail %d for user #%d: %v", mailID, t.ID, err)
|
|
writeError(w, http.StatusInternalServerError, "internal error")
|
|
return
|
|
}
|
|
writeJSON(w, mailToJSON(*rec))
|
|
}
|