Files
meshcore-analyzer/test-all.sh
T
45680a22cf fix(#2191): apply the channel filter to live WebSocket packets (#2192)
Fixes #2191.

## Problem

On the Packets page the channel filter only applies to the initial load
(`/api/packets?channel=` → server-side `transmissions.channel_hash`
match). The WebSocket handler re-checks time window, type, observer,
region and node, but not `filters.channel`, and the channel filter is
not re-applied at render time. With a channel selected, every new live
packet is appended regardless of its channel.

## Fix

- New pure helper `packetMatchesChannel(p, channel)` in
`public/packets.js`, exported as `window._packetsMatchesChannelForTest`
(same pattern as `_packetsBuildChannelOptionsForTest`).
- It derives the value the server filters on from `decoded_json`,
because WS packets don't carry `channel_hash`:
  - `channel` when the server decrypted the `GRP_TXT`,
  - otherwise `'enc_' + channelHashHex.toUpperCase()`.
- Only `payload_type === 5` can match, mirroring the server (the column
is only set for `GRP_TXT`). If a packet ever does carry `channel_hash`,
that wins.
- The WS filter calls it: `if (filters.channel &&
!packetMatchesChannel(p, filters.channel)) return false;`

Checked the derivation against a production DB (live.saarmesh.de): it
equals `channel_hash` for all 3,193 `GRP_TXT` rows of the last two days,
0 mismatches.

## Performance

WS hot path, but the new check runs only while a channel filter is
active, and for non-`GRP_TXT` packets it returns before any parsing. For
`GRP_TXT` it is one `JSON.parse` of the already-received `decoded_json`
string, O(1) per packet. WS messages are already debounced/coalesced by
`debouncedOnWS`, so at typical rates (a few packets per second) this is
negligible. No new state, no allocations beyond the parse, no API calls.

## Tests

New `tests/unit/test-packets-live-channel-filter.js` (registered in
`test-all.sh`), 10 cases:

- no filter accepts everything
- decrypted name match / mismatch
- non-`GRP_TXT` rejected while a channel filter is active
- `enc_<HH>` match incl. hex case normalisation and `enc_00`
- `channel_hash` passthrough takes precedence
- already-parsed `decoded_json` object
- malformed / missing `decoded_json` doesn't throw and doesn't match
- source check that the WS filter block actually applies the helper

Without the `packets.js` change the new test fails; with it all pass.
Existing `test-packets.js` (117), `test-packets-local-channels.js` (14),
`test-packet-filter.js` (99) and `test-frontend-helpers.js` still pass.

## Browser validation

The same change is deployed on live.saarmesh.de (hot-patched
`packets.js`, server restarted so `__BUST__` refreshed; the served file
contains the fix). I have not taken a screenshot of the filtered live
table myself, so treat the in-browser check as pending until a reviewer
or operator confirms.

No config or customizer implications.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01HJcbiRjQC5cSmydVFXbPbR

Co-authored-by: SaarMesh-Bot <300107934+SaarMesh-Bot@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
2026-10-12 15:25:59 +02:00

209 lines
9.5 KiB
Bash
Executable File

#!/bin/sh
# Authoritative standalone frontend test list for local runs and CI.
# Every suite in tests/unit is listed here; every suite in tests/e2e is classified
# in scripts/non-unit-tests.json.
set -e
cd "$(dirname "$0")"
node tests/unit/test-test-inventory.js
node tests/unit/test-1108-region-hide-nodes.js
node tests/unit/test-1659-analytics-warmup.js
node tests/unit/test-a11y-1705-subpath-hop-prefix-e2e.js
node tests/unit/test-a11y-1715-dark-role-swatches.js
node tests/unit/test-a11y-1716-rf-range-btn-active.js
node tests/unit/test-a11y-1719-contrast-root-causes-e2e.js
node tests/unit/test-a11y-1996-scope-audit-chips.js
node tests/unit/test-a11y-axe-1668-selftest.js
node tests/unit/test-a11y-axe-routes-coverage.js
node tests/unit/test-admin-dashboard-ui.js
node tests/unit/test-aging.js
node tests/unit/test-analytics-channels-integration.js
node tests/unit/test-anl1-tooltip-render.js
node tests/unit/test-area-filter.js
node tests/unit/test-channel-color-picker.js
node tests/unit/test-channel-colors.js
node tests/unit/test-channel-decrypt-ecb.js
node tests/unit/test-channel-decrypt-insecure-context.js
node tests/unit/test-channel-decrypt-m345.js
node tests/unit/test-channel-fluid-layout.js
node tests/unit/test-channel-issue-1087.js
node tests/unit/test-channel-issue-1101.js
node tests/unit/test-channel-live-decrypt-userprefix.js
node tests/unit/test-channel-live-decrypt.js
node tests/unit/test-channel-modal-ux.js
node tests/unit/test-channel-proposals-ui.js
node tests/unit/test-channel-psk-ux.js
node tests/unit/test-channel-qr-wiring.js
node tests/unit/test-channel-qr.js
node tests/unit/test-channel-sidebar-layout.js
node tests/unit/test-channel-ux-followup.js
node tests/unit/test-channel-ux-round2.js
node tests/unit/test-channels-approved-ui.js
node tests/unit/test-channels-merge-1498-unit.js
node tests/unit/test-clear-filters.js
node tests/unit/test-color-picker-ux.js
node tests/unit/test-compare-flood-filter.js
node tests/unit/test-compare-overlap.js
node tests/unit/test-confidence-indicator.js
node tests/unit/test-coverage-gate.js
node tests/unit/test-customizer-v2.js
node tests/unit/test-drag-manager.js
node tests/unit/test-direct-rf-heard-by.js
node tests/unit/test-embed-mode-1369.js
node tests/unit/test-fetch-all-nodes-pagination.js
node tests/unit/test-fluid-scaffolding.js
node tests/unit/test-frontend-helpers.js
node tests/unit/test-geofilter-draft.js
node tests/unit/test-hash-color.js
node tests/unit/test-hop-resolver-affinity.js
node tests/unit/test-issue-1065-gesture-hints-gates.js
node tests/unit/test-issue-1107-live-layout.js
node tests/unit/test-issue-1136-observer-iata-map.js
node tests/unit/test-issue-1166-first-seen-column.js
node tests/unit/test-issue-1189-composed-cell.js
node tests/unit/test-issue-1189-live-iata-badge.js
node tests/unit/test-issue-1279-p2-code-filter.js
node tests/unit/test-issue-1293-marker-shapes.js
node tests/unit/test-issue-1356-map-a11y.js
node tests/unit/test-issue-1360-pill-letter-count.js
node tests/unit/test-issue-1361-cb-presets.js
node tests/unit/test-issue-1364-pill-no-clamp.js
node tests/unit/test-issue-1375-scope-stats-fetch.js
node tests/unit/test-issue-1380-cb-reset-button.js
node tests/unit/test-issue-1380-cb-sim-overlay.js
node tests/unit/test-issue-1407-cb-preset-propagation.js
node tests/unit/test-issue-1409-no-encrypted-flood.js
node tests/unit/test-issue-1412-customizer-no-override.js
node tests/unit/test-issue-1415-packets-layout.js
node tests/unit/test-issue-1418-cb-preset-ramp.js
node tests/unit/test-issue-1418-deeplink-hops-channels.js
node tests/unit/test-issue-1418-edge-weights.js
node tests/unit/test-issue-1418-polish-review.js
node tests/unit/test-issue-1418-raw-hex-extraction.js
node tests/unit/test-issue-1418-spider-fan.js
node tests/unit/test-issue-1420-tile-providers.js
node tests/unit/test-issue-1438-customizer-mcrole.js
node tests/unit/test-issue-1438-marker-css-vars.js
node tests/unit/test-issue-1446-cb-preset-cascade.js
node tests/unit/test-issue-1450-logo-aspect.js
node tests/unit/test-issue-1454-channels-toggle.js
node tests/unit/test-issue-1456-score-labels.js
node tests/unit/test-issue-1461-mobile-page-actions.js
node tests/unit/test-issue-1470-card-bg-contrast.js
node tests/unit/test-issue-1470-node-tile-helper.js
node tests/unit/test-issue-1473-prefix-generator.js
node tests/unit/test-issue-1473-reserved-prefixes.js
node tests/unit/test-issue-1485-live-anim-z.js
node tests/unit/test-issue-1488-marker-stroke-vars.js
node tests/unit/test-issue-1496-reset-all-complete.js
node tests/unit/test-issue-1509-detect-preset.js
node tests/unit/test-issue-1509-nav-active-bg.js
node tests/unit/test-issue-1518-home-url.js
node tests/unit/test-issue-1532-live-fullscreen.js
node tests/unit/test-issue-1562-observers-summary.js
node tests/unit/test-issue-1563-aggregate-and-inflight.js
node tests/unit/test-issue-1574-live-map-max-nodes.js
node tests/unit/test-issue-1606-pagination.js
node tests/unit/test-issue-1614-tile-url-function.js
node tests/unit/test-issue-1619-feed-detail-card-draggable.js
node tests/unit/test-issue-1633-hide-1byte-hops.js
node tests/unit/test-issue-1644-redesign.js
node tests/unit/test-issue-1646-compare-polish.js
node tests/unit/test-issue-1648-followup-phosphor-leaks.js
node tests/unit/test-issue-1648-m1-emoji-scan.js
node tests/unit/test-issue-1648-m2-emoji-scan.js
node tests/unit/test-issue-1648-m3-emoji-scan.js
node tests/unit/test-issue-1648-m4-emoji-scan.js
node tests/unit/test-issue-1648-m5-emoji-scan.js
node tests/unit/test-issue-1648-m6-final-sweep.js
node tests/unit/test-issue-1648-m6-lint-self.js
node tests/unit/test-issue-1668-m2-contrast.js
node tests/unit/test-issue-1668-m3-typography.js
node tests/unit/test-issue-1668-m4-per-route.js
node tests/unit/test-issue-1697-mqtt-mobile-e2e.js
node tests/unit/test-issue-1699-retransmission-chart.js
node tests/unit/test-issue-1705-subpath-contrast.js
node tests/unit/test-issue-1753-copy-url-slash.js
node tests/unit/test-issue-1770-mobile-row-clamp.js
node tests/unit/test-issue-1789-observer-firmware-cols.js
node tests/unit/test-issue-1825-observer-node-cross-links.js
node tests/unit/test-issue-1833-legend-toggle-vcr-offset.js
node tests/unit/test-issue-1836-crossnav-case-normalization.js
node tests/unit/test-issue-1843-node-qr-quiet-zone.js
node tests/unit/test-issue-1846-observers-width.js
node tests/unit/test-issue-1849-trace-hashbytes.js
node tests/unit/test-issue-1851-channel-message-scope.js
node tests/unit/test-issue-1862-map-region-filter.js
node tests/unit/test-issue-1868-control-decode.js
node tests/unit/test-packet-detail-channel-escape.js
node tests/unit/test-packet-detail-hash-size.js
node tests/unit/test-issue-1890-og-url.js
node tests/unit/test-issue-1956-release-routing.js
node tests/unit/test-issue-1979-scope-adverts-by-role.js
node tests/unit/test-issue-1997-distance-building.js
node tests/unit/test-issue-2042-recent-adverts-label.js
node tests/unit/test-issue-2001-map-scope-state.js
node tests/unit/test-issue-2012-clear-filters-selection.js
node tests/unit/test-issue-2095-channels-client-state.js
node tests/unit/test-issue-2097-hop-ambiguity-badge.js
node tests/unit/test-issue-2098-last-hop-region.js
node tests/unit/test-live-anims.js
node tests/unit/test-live-dt-cap-1524.js
node tests/unit/test-live-legend-helper.js
node tests/unit/test-live-multibyte-filter.js
node tests/unit/test-live-region-filter.js
node tests/unit/test-live.js
node tests/unit/test-map-clustering.js
node tests/unit/test-mqtt-status-panel.js
node tests/unit/test-my-repeaters-dashboard.js
node tests/unit/test-naive-banner-tone.js
node tests/unit/test-nav-stats-throttle.js
node tests/unit/test-node-hop-analytics.js
node tests/unit/test-node-reach-coverage-debounce.js
node tests/unit/test-node-reach-coverage.js
node tests/unit/test-nodes-export-wiring.js
node tests/unit/test-nav-drawer-version-footer.js
node tests/unit/test-nodes-export.js
node tests/unit/test-notifications-ui.js
node tests/unit/test-observer-iata-1188.js
node tests/unit/test-observer-menu-interactions.js
node tests/unit/test-observer-naive-clock-1478.js
node tests/unit/test-observer-search-filter.js
node tests/unit/test-observers-headings.js
node tests/unit/test-packet-filter-time.js
node tests/unit/test-packet-filter-ux.js
node tests/unit/test-packet-filter.js
node tests/unit/test-packets-local-channels.js
node tests/unit/test-packets-live-channel-filter.js
node tests/unit/test-packets.js
node tests/unit/test-panel-corner.js
node tests/unit/test-path-inspector.js
node tests/unit/test-payload-labels-content.js
node tests/unit/test-payload-labels-namespace.js
node tests/unit/test-perf-anomaly.js
node tests/unit/test-perf-disk-io-1120.js
node tests/unit/test-perf-go-runtime.js
node tests/unit/test-perf-render-1258.js
node tests/unit/test-preflight-xss-gate.js
node tests/unit/test-pull-to-reconnect-1091.js
node tests/unit/test-pull-to-reconnect.js
node tests/unit/test-region-filter-setselected.js
node tests/unit/test-repeater-metric-scatter.js
node tests/unit/test-rx-coverage-config-race.js
node tests/unit/test-rx-coverage-mine.js
node tests/unit/test-rx-coverage-escape.js
node tests/unit/test-rx-coverage-noise.js
node tests/unit/test-rx-coverage-viewport.js
node tests/unit/test-scope-audit-styles-linked.js
node tests/unit/test-settings-sync.js
node tests/unit/test-slideover-1056-rowsel-strict.js
node tests/unit/test-top-routes-overlay.js
node tests/unit/test-traces.js
node tests/unit/test-url-state.js
node tests/unit/test-user-management-ui.js
node tests/unit/test-warmup-banner.js
node tests/unit/test-ws-stale-watchdog-1074.js
node tests/unit/test-xss-escape-sinks.js
echo "All standalone frontend suites passed"