mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-10-12 12:57:17 +00:00
efitenandClaude Opus 5.5
f3004d977e
The Mobile RX coverage page (`#/rx-coverage`) shows only cells where a companion received something. Where a companion drove and received nothing is just as useful for operators, and the data is already there: the RF sample track (`client_rf_samples`, #1905/#1906) and the receptions (`client_receptions`) use the same hex grid (`hexCellAt`, `zoomToHexRes`). This PR adds those cells as a hatched layer under the reception cells. ## Changes in this PR **Server** - `GET /api/rx-coverage?...&gaps=1` adds a `gaps` member to the FeatureCollection: cells with moving (non-stationary) track samples and no reception in the same `days` window and `bbox`, each with `samples`. `gaps_truncated` is set when more than 5000 cells qualify (the most-sampled are kept, same pattern as `coverageFeatureCap` and `rfNoiseFeatureCap`). - Gaps are only returned when `clientRfSamples` is on and there is no `node` filter: with `?node=` the question would be "this node was not heard", which these cells do not answer. `?rx=` limits both the track and the receptions to that companion. - Without `gaps=1` the payload is unchanged: the `gaps` member is omitted. - New code lives in `cmd/server/rx_coverage_gaps.go` (pure `aggregateGaps` plus `queryTrackPoints`); the handler change in `rx_dashboard.go` is 14 lines. - `/api/rx-coverage` is now documented in `openapi.go` and removed from `openapi_known_gaps.json` (#1670). **Frontend** (`public/rx-coverage.js`, `public/node-reach-coverage.css`) - A "Nothing received" toggle on the signal layer, on by default, only rendered with `MC_CLIENT_RF_SAMPLES`. Hidden on the noise layer. - Gap cells use a 45-degree hatch (an SVG pattern in a dedicated renderer, so they sit under the reception cells). The hatch is denser for cells driven through more often (1 / 2-3 / 4+ samples). Tooltip: sample count. Legend entry: "driven, nothing received". - Off state is deep-linkable as `gaps=0`. - New token `--nq-cov-gap` for light and dark. Plain grey (`--nq-cov-grey`) already means "received, no SNR", so the hatch keeps the two apart. ## Threshold: one sample Measured on a live network (analyzer.on8ar.eu, Belgium, September to October 2026), with cells of about 250 m: a cell with track samples and no reception in one half of a month, driven again in the other half. How often did it receive something the second time? | Minimum samples | Cells "nothing received" | Driven again | Received something later | |---|---|---|---| | 1 | 3971 | 1263 | 29% | | 2 | 1565 | 592 | 32% | | 3 | 619 | 243 | 35% | | 5 | 142 | 63 | 40% | A higher threshold hides cells without making the rest more reliable, so the threshold is 1 and the wording is "nothing received in this period", never "no coverage". Using every decoded packet as reception evidence (including 1-byte path hashes) gave 25% to 32%, so the capture rule for 1-byte hashes is not what drives this. The median cell has 2 samples. ## Verification - Go: 7 new tests in `rx_coverage_gaps_test.go` (gap/no gap, stationary excluded, single sample, cap keeps the most-sampled, endpoint, `?rx=` filter, no `gaps` member when not asked / with `?node=` / with RF samples off). The endpoint tests fail without the handler change. Full `cmd/server` suite green locally, `go vet` and `gofmt` clean. - E2E: `tests/e2e/test-rx-coverage-gaps-e2e.js` (4 steps: no toggle with RF samples off, on by default with hatched cells under the reception cells, toggle off with `gaps=0` and deep link, noise layer hides it). 2 steps fail without the frontend change. Existing `test-rx-coverage-noise-e2e.js` and `test-rx-coverage-viewport-e2e.js` still pass. Listed in `scripts/non-unit-tests.json`. - Frontend unit suite (`test-all.sh`) green. - Real data on a staging instance (7 days, bbox 50.8,4.9,51.3,5.8, z=12): 478 reception cells and 379 gap cells, no cell in both, reception features identical with and without `gaps=1`, 0.48 s to 0.52 s per request both ways. - Browser: checked on staging with real data (light theme), and light, dark and 390 px wide with mocked data. ## Not in this PR - A per-node variant on the Reach page ("this repeater transmitted while a companion was nearby, and was not heard"). That needs the transmit moments from `observations` and is a heavier query. - `deploy.yml` does not get a line for the new E2E file, like the other entries that are only in `non-unit-tests.json` (#2037). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
138 lines
7.0 KiB
JSON
138 lines
7.0 KiB
JSON
{
|
|
"browser": {
|
|
"reason": "Requires Playwright and Chromium; most suites also require a running local fixture server via BASE_URL. Existing E2E workflow steps retain their separate setup and selection. Never point these tests at production.",
|
|
"files": [
|
|
"tests/e2e/test-1110-live-filter.js",
|
|
"tests/e2e/test-a11y-axe-1668.js",
|
|
"tests/e2e/test-analytics-fluid-charts.js",
|
|
"tests/e2e/test-audio-lab-1297-e2e.js",
|
|
"tests/e2e/test-audio-live-1297-e2e.js",
|
|
"tests/e2e/test-bottom-nav-1061-e2e.js",
|
|
"tests/e2e/test-channel-color-picker-e2e.js",
|
|
"tests/e2e/test-channel-decrypt-e2e.js",
|
|
"tests/e2e/test-channel-fluid-e2e.js",
|
|
"tests/e2e/test-channel-issue-1087-e2e.js",
|
|
"tests/e2e/test-channel-issue-1111-e2e.js",
|
|
"tests/e2e/test-channel-modal-e2e.js",
|
|
"tests/e2e/test-channel-qr-e2e.js",
|
|
"tests/e2e/test-channels-add-modal-e2e.js",
|
|
"tests/e2e/test-channels-list-render-e2e.js",
|
|
"tests/e2e/test-channels-selection-flow-e2e.js",
|
|
"tests/e2e/test-channels-share-color-e2e.js",
|
|
"tests/e2e/test-channels-ws-batch-e2e.js",
|
|
"tests/e2e/test-channels-ws-race-1498-e2e.js",
|
|
"tests/e2e/test-charts-fluid-1058-e2e.js",
|
|
"tests/e2e/test-customize-branding-e2e.js",
|
|
"tests/e2e/test-customize-display-e2e.js",
|
|
"tests/e2e/test-customize-export-e2e.js",
|
|
"tests/e2e/test-customize-theme-e2e.js",
|
|
"tests/e2e/test-drag-manager-e2e.js",
|
|
"tests/e2e/test-e2e-1267-mobile-vcr.js",
|
|
"tests/e2e/test-e2e-playwright.js",
|
|
"tests/e2e/test-filter-ux-e2e.js",
|
|
"tests/e2e/test-gesture-hints-1065-e2e.js",
|
|
"tests/e2e/test-gestures-1062-e2e.js",
|
|
"tests/e2e/test-gestures-1185-scroll-discriminator-e2e.js",
|
|
"tests/e2e/test-home-coverage-e2e.js",
|
|
"tests/e2e/test-issue-1109-hamburger-dropdown-visible-e2e.js",
|
|
"tests/e2e/test-issue-1122-packets-filter-ux-e2e.js",
|
|
"tests/e2e/test-issue-1128-multi-viewport-e2e.js",
|
|
"tests/e2e/test-issue-1128-packets-layout-e2e.js",
|
|
"tests/e2e/test-issue-1136-live-region-e2e.js",
|
|
"tests/e2e/test-issue-1146-path-link-contrast-e2e.js",
|
|
"tests/e2e/test-issue-1147-section-order-e2e.js",
|
|
"tests/e2e/test-issue-1150-404-state-e2e.js",
|
|
"tests/e2e/test-issue-1151-orphan-separators-e2e.js",
|
|
"tests/e2e/test-issue-1204-live-panel-structure-e2e.js",
|
|
"tests/e2e/test-issue-1205-live-controls-anchor-e2e.js",
|
|
"tests/e2e/test-issue-1206-resize-observer-leak-e2e.js",
|
|
"tests/e2e/test-issue-1206-vcr-overlap-e2e.js",
|
|
"tests/e2e/test-issue-1224-channels-mobile-ux-e2e.js",
|
|
"tests/e2e/test-issue-1234-live-chrome-pass2-e2e.js",
|
|
"tests/e2e/test-issue-1236-map-mobile-e2e.js",
|
|
"tests/e2e/test-issue-1244-live-vcr-row-hints-e2e.js",
|
|
"tests/e2e/test-issue-1273-qr-overlay-height-e2e.js",
|
|
"tests/e2e/test-issue-1274-legend-coverage-e2e.js",
|
|
"tests/e2e/test-issue-1279-legend-p2-e2e.js",
|
|
"tests/e2e/test-issue-1281-location-row-e2e.js",
|
|
"tests/e2e/test-issue-1306-collisions-terminology-e2e.js",
|
|
"tests/e2e/test-issue-1329-map-controls-accordion-e2e.js",
|
|
"tests/e2e/test-issue-1367-channels-chat-app-e2e.js",
|
|
"tests/e2e/test-issue-1374-route-map-a11y-e2e.js",
|
|
"tests/e2e/test-issue-1400-nav-vertical-clip.js",
|
|
"tests/e2e/test-issue-1413-nav-overlap-e2e.js",
|
|
"tests/e2e/test-issue-1486-collapse-reopens-detail-e2e.js",
|
|
"tests/e2e/test-issue-1487-byop-modal-layout-e2e.js",
|
|
"tests/e2e/test-issue-1510-live-nav-pin-e2e.js",
|
|
"tests/e2e/test-issue-1567-corner-clears-drag-e2e.js",
|
|
"tests/e2e/test-issue-1599-replay-freeze-e2e.js",
|
|
"tests/e2e/test-issue-1630-reach-mobile-e2e.js",
|
|
"tests/e2e/test-issue-1639-observers-sort-e2e.js",
|
|
"tests/e2e/test-issue-1640-compare-discovery-e2e.js",
|
|
"tests/e2e/test-issue-1648-m1-icons-e2e.js",
|
|
"tests/e2e/test-issue-1648-m2-icons-e2e.js",
|
|
"tests/e2e/test-issue-1648-m3-icons-e2e.js",
|
|
"tests/e2e/test-issue-1648-m4-icons-e2e.js",
|
|
"tests/e2e/test-issue-1648-m5-icons-e2e.js",
|
|
"tests/e2e/test-issue-1657-analytics-channels-group-sprites-e2e.js",
|
|
"tests/e2e/test-issue-1692-packets-init-parallel-e2e.js",
|
|
"tests/e2e/test-issue-1705-subpath-contrast-e2e.js",
|
|
"tests/e2e/test-issue-1758-ng-filter-rerenders-e2e.js",
|
|
"tests/e2e/test-issue-1799-label-vocab-e2e.js",
|
|
"tests/e2e/test-issue-1833-legend-toggle-clickable-e2e.js",
|
|
"tests/e2e/test-issue-1997-distance-building-e2e.js",
|
|
"tests/e2e/test-live-dedup.js",
|
|
"tests/e2e/test-live-fullscreen-1572-e2e.js",
|
|
"tests/e2e/test-live-layout-1178-1179-e2e.js",
|
|
"tests/e2e/test-live-mql-leak-1180-e2e.js",
|
|
"tests/e2e/test-live-multibyte-only-e2e.js",
|
|
"tests/e2e/test-logo-default-sage-teal-e2e.js",
|
|
"tests/e2e/test-logo-pulse-1173-e2e.js",
|
|
"tests/e2e/test-logo-rebrand-e2e.js",
|
|
"tests/e2e/test-logo-theme-e2e.js",
|
|
"tests/e2e/test-map-modal-fluid-e2e.js",
|
|
"tests/e2e/test-map-nodes-pagination-e2e.js",
|
|
"tests/e2e/test-nav-drawer-1064-e2e.js",
|
|
"tests/e2e/test-nav-fluid-1055-e2e.js",
|
|
"tests/e2e/test-nav-more-floor-1139-e2e.js",
|
|
"tests/e2e/test-nav-priority-1102-e2e.js",
|
|
"tests/e2e/test-nav-priority-1311-e2e.js",
|
|
"tests/e2e/test-nav-priority-1391-e2e.js",
|
|
"tests/e2e/test-neighbor-map-btn-clip-e2e.js",
|
|
"tests/e2e/test-node-reach-coverage-e2e.js",
|
|
"tests/e2e/test-node-reach-e2e.js",
|
|
"tests/e2e/test-nodes-export-e2e.js",
|
|
"tests/e2e/test-observer-iata-1188-e2e.js",
|
|
"tests/e2e/test-packets-compact-columns-e2e.js",
|
|
"tests/e2e/test-packets-scope-column.js",
|
|
"tests/e2e/test-path-inspector-coverage-e2e.js",
|
|
"tests/e2e/test-rx-coverage-mobile-nav-e2e.js",
|
|
"tests/e2e/test-rx-coverage-gaps-e2e.js",
|
|
"tests/e2e/test-rx-coverage-noise-e2e.js",
|
|
"tests/e2e/test-rx-coverage-viewport-e2e.js",
|
|
"tests/e2e/test-show-neighbors.js",
|
|
"tests/e2e/test-slideover-1056-e2e.js",
|
|
"tests/e2e/test-slideover-1168-munger-e2e.js",
|
|
"tests/e2e/test-table-fluid-e2e.js",
|
|
"tests/e2e/test-touch-gestures-coverage-e2e.js",
|
|
"tests/e2e/test-touch-targets.js",
|
|
"tests/e2e/test-user-management-e2e.js"
|
|
]
|
|
},
|
|
"domIntegration": {
|
|
"reason": "Requires jsdom. The JS unit gate runs with no node_modules at all (its job has no npm install), so a suite needing a third-party module cannot live in test-all.sh. It runs in the E2E job, which does npm ci, and is invoked by its own deploy.yml line.",
|
|
"files": [
|
|
"tests/e2e/test-table-sort.js"
|
|
]
|
|
},
|
|
"playwrightRunner": {
|
|
"reason": "Requires the @playwright/test runner (not plain node), its configuration, Chromium, and a local server. @playwright/test is not currently declared in package.json; these suites are inventoried but not part of the standalone unit gate.",
|
|
"files": [
|
|
"tests/e2e/test-issue-1522-trace-url-sync-e2e.js",
|
|
"tests/e2e/test-marker-outline-weight.js",
|
|
"tests/e2e/test-path-inspector-e2e.js",
|
|
"tests/e2e/test-pr-1490-live-map-gpu-animations-e2e.js"
|
|
]
|
|
}
|
|
}
|