Files
meshcore-analyzer/cmd/server
n30nexandn30nex 9341ec744b fix(observers): honour node visibility in neighbour reports (#2357)
Fixes #2356.

Observer neighbour reports now apply the existing node blacklist and
hidden-name-prefix rules before returning displayed identities. Names
are already batch-loaded, so the fix filters the request-owned slice
without another SQL query. It preserves reported totals, timestamps,
stored data, public/unknown neighbours and the existing reporter-only
observer-blacklist semantics. An all-hidden list remains `[]`.

The work is bounded by the existing 500-entry ingestion cap plus the
existing visibility checks; no new configuration, frontend change or
database write is introduced. The filter reuses the existing report
slice.

Validation:

- [RED
CI](https://github.com/Kpa-clawbot/CoreScope/actions/runs/40971452075/job/123789013428)
at `7341b334` compiled and reached the four expected visibility
assertions.
- GREEN `b38e95e6`: focused native checks passed in 6.607 s; parent
rerun passed in 1.865 s.
- Full native server passed in 189.743 s; parent ingestor suite passed
in 399.859 s. Existing neighbour frontend checks passed 7/7.
- Tests use the actual registered router, direct-node 404 controls,
casing/shared-name/unknown-node cases, metadata preservation and an
unchanged stored report.

Local standalone browser replay is unavailable because the
fixture-server launch was blocked. Fresh GREEN CI passed, including
server race checks and browser shards. Independent adversarial,
security-boundary and TDD reviews found no must-fix items. No
live-instance incident or deployment is claimed.

---------

Co-authored-by: n30nex <6686206+n30nex@users.noreply.github.com>
2026-10-31 12:01:19 +01:00
..