mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-05-12 02:54:44 +00:00
Kpa-clawbot
f33801ecb4
## Summary Implements the **Traffic axis** of the repeater usefulness score (#672). Does NOT close #672 — Bridge, Coverage, and Redundancy axes are deferred to follow-up PRs. Adds `usefulness_score` (0..1) to repeater/room node API responses representing what fraction of non-advert traffic passes through this repeater as a relay hop. ## Why traffic-axis-first The issue proposes a 4-axis composite (Bridge, Coverage, Traffic, Redundancy). Bridge/Coverage/Redundancy require betweenness centrality and neighbor graph infrastructure (#773 Neighbor Graph V2). Traffic axis can ship independently using existing path-hop data. ## Remaining work for #672 - Bridge axis (betweenness centrality — depends on #773) - Coverage axis (observer reach comparison) - Redundancy axis (node-removal simulation — depends on #687) - Composite score combining all 4 axes Partial fix for #672. --------- Co-authored-by: meshcore-bot <bot@meshcore.local>
101 lines
3.1 KiB
Go
101 lines
3.1 KiB
Go
package main
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
// TestRepeaterUsefulness_BasicShare verifies that usefulness_score is
|
|
// relay_count_24h / total_non_advert_traffic_24h. With 1 of 4 relayed
|
|
// packets going through the repeater, score should be 0.25.
|
|
//
|
|
// Issue #672. We are intentionally implementing the *traffic share*
|
|
// dimension of the composite score from the issue body — bridge,
|
|
// coverage, redundancy are deferred to follow-up work. This is the
|
|
// "Traffic" axis of the table in #672.
|
|
func TestRepeaterUsefulness_BasicShare(t *testing.T) {
|
|
db := setupCapabilityTestDB(t)
|
|
defer db.conn.Close()
|
|
|
|
pubkey := "aabbccdd11223344"
|
|
store := NewPacketStore(db, nil)
|
|
|
|
// 4 non-advert packets total in last hour. The repeater appears in
|
|
// the resolved path of exactly one of them.
|
|
pt := 1
|
|
for i := 0; i < 4; i++ {
|
|
tx := &StoreTx{RawHex: "0100", PayloadType: &pt, FirstSeen: recentTS(0)}
|
|
// Only first packet has our repeater in its path.
|
|
if i == 0 {
|
|
store.mu.Lock()
|
|
tx.ID = len(store.packets) + 1
|
|
tx.Hash = "uf-hit"
|
|
store.packets = append(store.packets, tx)
|
|
store.byHash[tx.Hash] = tx
|
|
store.byTxID[tx.ID] = tx
|
|
store.byPayloadType[pt] = append(store.byPayloadType[pt], tx)
|
|
store.byPathHop[pubkey] = append(store.byPathHop[pubkey], tx)
|
|
store.mu.Unlock()
|
|
} else {
|
|
addTestPacket(store, tx)
|
|
}
|
|
}
|
|
|
|
score := store.GetRepeaterUsefulnessScore(pubkey)
|
|
// 1 relay / 4 total = 0.25
|
|
if score < 0.24 || score > 0.26 {
|
|
t.Errorf("expected usefulness ~0.25, got %f", score)
|
|
}
|
|
}
|
|
|
|
// TestRepeaterUsefulness_NoTraffic verifies score is 0 when there is
|
|
// no non-advert traffic to share.
|
|
func TestRepeaterUsefulness_NoTraffic(t *testing.T) {
|
|
db := setupCapabilityTestDB(t)
|
|
defer db.conn.Close()
|
|
store := NewPacketStore(db, nil)
|
|
score := store.GetRepeaterUsefulnessScore("deadbeefcafebabe")
|
|
if score != 0 {
|
|
t.Errorf("expected 0 for empty store, got %f", score)
|
|
}
|
|
}
|
|
|
|
// TestRepeaterUsefulness_AdvertsExcluded verifies that ADVERT packets
|
|
// (payload_type=4) are excluded from both numerator and denominator —
|
|
// adverts don't count as forwarded traffic.
|
|
func TestRepeaterUsefulness_AdvertsExcluded(t *testing.T) {
|
|
db := setupCapabilityTestDB(t)
|
|
defer db.conn.Close()
|
|
|
|
pubkey := "11aa22bb33cc44dd"
|
|
store := NewPacketStore(db, nil)
|
|
|
|
// 2 non-advert packets, both with our repeater in path → score = 1.0
|
|
pt := 1
|
|
for i := 0; i < 2; i++ {
|
|
tx := &StoreTx{RawHex: "0100", PayloadType: &pt, FirstSeen: recentTS(0)}
|
|
store.mu.Lock()
|
|
tx.ID = len(store.packets) + 1
|
|
tx.Hash = "uf-non-advert"
|
|
if i == 1 {
|
|
tx.Hash = "uf-non-advert-2"
|
|
}
|
|
store.packets = append(store.packets, tx)
|
|
store.byHash[tx.Hash] = tx
|
|
store.byTxID[tx.ID] = tx
|
|
store.byPayloadType[pt] = append(store.byPayloadType[pt], tx)
|
|
store.byPathHop[pubkey] = append(store.byPathHop[pubkey], tx)
|
|
store.mu.Unlock()
|
|
}
|
|
// Add 100 adverts — these must be ignored.
|
|
advertPT := payloadTypeAdvert
|
|
for i := 0; i < 100; i++ {
|
|
tx := &StoreTx{RawHex: "0400", PayloadType: &advertPT, FirstSeen: recentTS(0)}
|
|
addTestPacket(store, tx)
|
|
}
|
|
|
|
score := store.GetRepeaterUsefulnessScore(pubkey)
|
|
if score < 0.99 || score > 1.01 {
|
|
t.Errorf("expected usefulness ~1.0 (adverts excluded), got %f", score)
|
|
}
|
|
}
|