mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-07-19 15:36:19 +00:00
Red commit: https://github.com/Kpa-clawbot/CoreScope/commit/eae179b99b5fd34924547632aa8f8025c405aa53 (CI: pending — opens with this PR) Finishes #1283. RED test `TestServerSourceHasNoCachedRWCalls` goes from failing (13 writer call-sites) to GREEN (zero). Per #1287 Option 4 (https://github.com/Kpa-clawbot/CoreScope/issues/1287#issuecomment-4485099992): ingestor owns the neighbor graph build + persist; server reads the snapshot. **Category A — Schema migrations** → new `internal/dbschema` package. `dbschema.Apply(rw)` runs in `cmd/ingestor` startup (in `OpenStore`). `dbschema.AssertReady(ro)` runs in `cmd/server/main.go` and FATAL-LOG-EXITS if any expected column/index/table is missing — the operator must restart the ingestor first. Covers indexes, `neighbor_edges`, `observations.resolved_path`, `observers.{inactive,last_packet_at,iata}`, `(inactive_)nodes.foreign_advert`, `transmissions.from_pubkey`. **Category B — Backfill** → ingestor. `BackfillFromPubkey` and observer-blacklist soft-delete moved to `cmd/ingestor/maintenance.go`. Server keeps an inert `fromPubkeyBackfillSnapshot` stub for `/api/healthz` API compatibility. **Category C — Neighbor-graph persistence (Option 4)** → ingestor writes, server reads. - Ingestor (`cmd/ingestor/neighbor_builder.go`): every 60s scans `observations + transmissions`, extracts edges (originator↔first-hop for ADVERTs; observer↔last-hop for all), resolves hop prefixes via a node-table prefix index, upserts into `neighbor_edges`. - Server (`cmd/server/neighbor_recomputer.go`): every 60s re-reads `neighbor_edges` and atomic-swaps the resulting `NeighborGraph` into `s.graph`. Initial load is synchronous on startup. All server-side incremental edge writers (the two `asyncPersistResolvedPathsAndEdges` paths in `cmd/server/store.go`) are gone. - Neighbor-edge daily prune (`PruneNeighborEdges`) moved to ingestor. **Why Option 4**: clean read/write separation, no startup CPU spike (server loads existing snapshot instead of rebuilding from history), no IPC/delta-protocol churn. Staleness budget ~60s — same model as the analytics recomputers in #1240 / #1248 / #672 axis 2. **Recomputer interval default for neighbor graph**: 60s (`NeighborGraphRecomputerDefaultInterval`, `NeighborEdgesBuilderInterval`). **Invariants added**: - `TestServerSourceHasNoCachedRWCalls` (RED commit eae179b9): grep enforces zero `cachedRW(`, `mode=rw`, or `sql.Open(_journal_mode=WAL…)` in non-test `cmd/server/` sources. - `TestServerStartupRequiresMigratedSchema`: server refuses to start against an unmigrated DB. - `TestNeighborGraphRecomputerLoadsSnapshot`: post-write snapshot is picked up on the next refresh. - `TestNeighborEdgesBuilderUpsertsFromObservations`: end-to-end pipeline writes the expected edge. `grep cachedRW cmd/server/*.go | grep -v _test.go` → 0 matches. Fixes #1287. --------- Co-authored-by: MeshCore Bot <bot@meshcore.local> Co-authored-by: Kpa-clawbot <Kpa-clawbot@users.noreply.github.com> Co-authored-by: corescope-bot <bot@corescope.local>
71 lines
1.8 KiB
Go
71 lines
1.8 KiB
Go
package main
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestBackfillHoursDefault(t *testing.T) {
|
|
cfg := &Config{}
|
|
if got := cfg.BackfillHours(); got != 24 {
|
|
t.Errorf("BackfillHours() = %d, want 24", got)
|
|
}
|
|
}
|
|
|
|
func TestBackfillHoursConfigured(t *testing.T) {
|
|
cfg := &Config{ResolvedPath: &ResolvedPathConfig{BackfillHours: 48}}
|
|
if got := cfg.BackfillHours(); got != 48 {
|
|
t.Errorf("BackfillHours() = %d, want 48", got)
|
|
}
|
|
}
|
|
|
|
func TestBackfillHoursZeroFallsBack(t *testing.T) {
|
|
cfg := &Config{ResolvedPath: &ResolvedPathConfig{BackfillHours: 0}}
|
|
if got := cfg.BackfillHours(); got != 24 {
|
|
t.Errorf("BackfillHours() = %d, want 24 (default for zero)", got)
|
|
}
|
|
}
|
|
|
|
func TestNeighborMaxAgeDaysDefault(t *testing.T) {
|
|
cfg := &Config{}
|
|
if got := cfg.NeighborMaxAgeDays(); got != 5 {
|
|
t.Errorf("NeighborMaxAgeDays() = %d, want 5", got)
|
|
}
|
|
}
|
|
|
|
func TestNeighborMaxAgeDaysConfigured(t *testing.T) {
|
|
cfg := &Config{NeighborGraph: &NeighborGraphConfig{MaxAgeDays: 7}}
|
|
if got := cfg.NeighborMaxAgeDays(); got != 7 {
|
|
t.Errorf("NeighborMaxAgeDays() = %d, want 7", got)
|
|
}
|
|
}
|
|
|
|
func TestGraphPruneOlderThan(t *testing.T) {
|
|
g := NewNeighborGraph()
|
|
now := time.Now().UTC()
|
|
|
|
// Add a recent edge
|
|
g.upsertEdge("aaa", "bbb", "bb", "obs1", nil, now)
|
|
// Add an old edge
|
|
g.upsertEdge("ccc", "ddd", "dd", "obs1", nil, now.Add(-60*24*time.Hour))
|
|
|
|
if len(g.AllEdges()) != 2 {
|
|
t.Fatalf("expected 2 edges, got %d", len(g.AllEdges()))
|
|
}
|
|
|
|
cutoff := now.Add(-30 * 24 * time.Hour)
|
|
pruned := g.PruneOlderThan(cutoff)
|
|
if pruned != 1 {
|
|
t.Errorf("PruneOlderThan pruned %d, want 1", pruned)
|
|
}
|
|
|
|
edges := g.AllEdges()
|
|
if len(edges) != 1 {
|
|
t.Fatalf("expected 1 edge after prune, got %d", len(edges))
|
|
}
|
|
if edges[0].NodeA != "aaa" && edges[0].NodeB != "aaa" {
|
|
t.Errorf("wrong edge survived prune: %+v", edges[0])
|
|
}
|
|
}
|
|
|