mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-07-02 14:51:44 +00:00
Kpa-clawbot
7292d60fbe
# feat(#1508): config-driven disabled tabs in customizer modal Fixes #1508. ## Why The customizer modal mixes one-shot operator chrome (`branding`, `home`, `geofilter`, `export`) with daily-use viewer toggles (`theme`, `nodes`, `display`). Non-technical users get confused by the admin tabs and skip past the controls they actually need. There's no current way to hide individual tabs server-side — only via CSS, which doesn't prevent state mutation. ## What Adds a single operator knob: `customizer.disabledTabs` in `config.json`. The named tab ids are filtered out of `_renderTabs()` in `public/customize-v2.js` before render. - `config.example.json` — new `customizer` block, default `disabledTabs: []` (zero behavior change for existing operators). - `cmd/server/config.go` — new `CustomizerConfig` type, optional pointer on `Config`. - `cmd/server/routes.go` + `cmd/server/types.go` — `/api/config/client` now surfaces `customizer.disabledTabs` (always an array, empty when unset). - `public/customize-v2.js` — `_renderTabs()` filters by id. - `cmd/server/customizer_disabled_tabs_test.go` — RED-then-green tests covering both the configured-and-defaulted shapes. ## TDD trail 1. RED commit adds the failing tests + minimal `CustomizerConfig` stub so the package still compiles; both tests fail on the assertion (`body.customizer` is `<nil>`) — not on import. 2. GREEN commit wires the field through `/api/config/client` and the frontend tab filter; both tests pass. ## Scope 5 files. No new API surface, no UI for editing the list (operator edits `config.json` directly per the issue body). Backward-compatible: missing `customizer` block defaults the list to empty. --------- Co-authored-by: bot <bot@local>
97 lines
2.9 KiB
Go
97 lines
2.9 KiB
Go
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"reflect"
|
|
"sort"
|
|
"testing"
|
|
|
|
"github.com/gorilla/mux"
|
|
)
|
|
|
|
// TestConfigClientExposesCustomizerDisabledTabs verifies that the
|
|
// /api/config/client endpoint surfaces the operator-set list of customizer
|
|
// tabs to hide, so the customize-v2 frontend can filter them out of
|
|
// _renderTabs(). Issue #1508.
|
|
func TestConfigClientExposesCustomizerDisabledTabs(t *testing.T) {
|
|
db := setupTestDB(t)
|
|
seedTestData(t, db)
|
|
cfg := &Config{
|
|
Port: 3000,
|
|
Customizer: &CustomizerConfig{
|
|
DisabledTabs: []string{"branding", "geofilter", "export"},
|
|
},
|
|
}
|
|
hub := NewHub()
|
|
srv := NewServer(db, cfg, hub)
|
|
store := NewPacketStore(db, nil)
|
|
if err := store.Load(); err != nil {
|
|
t.Fatalf("store.Load failed: %v", err)
|
|
}
|
|
srv.store = store
|
|
router := mux.NewRouter()
|
|
srv.RegisterRoutes(router)
|
|
|
|
req := httptest.NewRequest("GET", "/api/config/client", nil)
|
|
w := httptest.NewRecorder()
|
|
router.ServeHTTP(w, req)
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d (body=%s)", w.Code, w.Body.String())
|
|
}
|
|
var body map[string]interface{}
|
|
if err := json.Unmarshal(w.Body.Bytes(), &body); err != nil {
|
|
t.Fatalf("decode: %v", err)
|
|
}
|
|
custRaw, ok := body["customizer"].(map[string]interface{})
|
|
if !ok {
|
|
t.Fatalf("expected body.customizer object, got %T (body=%s)", body["customizer"], w.Body.String())
|
|
}
|
|
tabsRaw, ok := custRaw["disabledTabs"].([]interface{})
|
|
if !ok {
|
|
t.Fatalf("expected body.customizer.disabledTabs array, got %T", custRaw["disabledTabs"])
|
|
}
|
|
got := make([]string, 0, len(tabsRaw))
|
|
for _, v := range tabsRaw {
|
|
s, ok := v.(string)
|
|
if !ok {
|
|
t.Fatalf("disabledTabs element not a string: %T", v)
|
|
}
|
|
got = append(got, s)
|
|
}
|
|
want := []string{"branding", "export", "geofilter"}
|
|
sort.Strings(got)
|
|
if !reflect.DeepEqual(got, want) {
|
|
t.Errorf("disabledTabs: got %v, want %v", got, want)
|
|
}
|
|
}
|
|
|
|
// TestConfigClientDefaultsCustomizerDisabledTabsEmpty verifies the backward-
|
|
// compat default: when no customizer block is configured, the field is still
|
|
// present and is an empty array (so the frontend can blindly call .includes()).
|
|
func TestConfigClientDefaultsCustomizerDisabledTabsEmpty(t *testing.T) {
|
|
_, router := setupTestServer(t)
|
|
req := httptest.NewRequest("GET", "/api/config/client", nil)
|
|
w := httptest.NewRecorder()
|
|
router.ServeHTTP(w, req)
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d", w.Code)
|
|
}
|
|
var body map[string]interface{}
|
|
if err := json.Unmarshal(w.Body.Bytes(), &body); err != nil {
|
|
t.Fatalf("decode: %v", err)
|
|
}
|
|
custRaw, ok := body["customizer"].(map[string]interface{})
|
|
if !ok {
|
|
t.Fatalf("expected body.customizer object, got %T", body["customizer"])
|
|
}
|
|
tabsRaw, ok := custRaw["disabledTabs"].([]interface{})
|
|
if !ok {
|
|
t.Fatalf("expected body.customizer.disabledTabs array, got %T", custRaw["disabledTabs"])
|
|
}
|
|
if len(tabsRaw) != 0 {
|
|
t.Errorf("default disabledTabs should be empty, got %v", tabsRaw)
|
|
}
|
|
}
|