mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-05-12 13:54:43 +00:00
copelaje
922ebe54e7
For BYOP mode in the packet analyzer, perform signature validation on advert packets and display whether successful or not. This is added as we observed many corrupted advert packets that would be easily detectable as such if signature validation checks were performed. At present this MR is just to add this status in BYOP mode so there is minimal impact to the application and no performance penalty for having to perform these checks on all packets. Moving forward it probably makes sense to do these checks on all advert packets so that corrupt packets can be ignored in several contexts (like node lists for example). Let me know what you think and I can adjust as needed. --------- Co-authored-by: you <you@example.com>
64 lines
1.4 KiB
Go
64 lines
1.4 KiB
Go
package sigvalidate
|
|
|
|
import (
|
|
"crypto/ed25519"
|
|
"encoding/binary"
|
|
"testing"
|
|
)
|
|
|
|
func TestValidateAdvert_ValidSignature(t *testing.T) {
|
|
pub, priv, err := ed25519.GenerateKey(nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
var timestamp uint32 = 1234567890
|
|
appdata := []byte{0x02, 0x10, 0x20}
|
|
|
|
// Build the signed message: pubKey + timestamp(LE) + appdata
|
|
msg := make([]byte, 32+4+len(appdata))
|
|
copy(msg[0:32], pub)
|
|
binary.LittleEndian.PutUint32(msg[32:36], timestamp)
|
|
copy(msg[36:], appdata)
|
|
|
|
sig := ed25519.Sign(priv, msg)
|
|
|
|
valid, err := ValidateAdvert([]byte(pub), sig, timestamp, appdata)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if !valid {
|
|
t.Fatal("expected valid signature")
|
|
}
|
|
}
|
|
|
|
func TestValidateAdvert_InvalidSignature(t *testing.T) {
|
|
pub, _, err := ed25519.GenerateKey(nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
badSig := make([]byte, 64)
|
|
valid, err := ValidateAdvert([]byte(pub), badSig, 100, []byte{0x01})
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if valid {
|
|
t.Fatal("expected invalid signature")
|
|
}
|
|
}
|
|
|
|
func TestValidateAdvert_BadPubkeyLength(t *testing.T) {
|
|
_, err := ValidateAdvert([]byte{1, 2, 3}, make([]byte, 64), 0, nil)
|
|
if err == nil {
|
|
t.Fatal("expected error for short pubkey")
|
|
}
|
|
}
|
|
|
|
func TestValidateAdvert_BadSignatureLength(t *testing.T) {
|
|
_, err := ValidateAdvert(make([]byte, 32), []byte{1, 2, 3}, 0, nil)
|
|
if err == nil {
|
|
t.Fatal("expected error for short signature")
|
|
}
|
|
}
|