mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-06-05 21:02:54 +00:00
Kpa-clawbot
9383201c07
Red commit:
https://github.com/Kpa-clawbot/CoreScope/commit/eae179b99b5fd34924547632aa8f8025c405aa53
(CI: pending — opens with this PR)
Finishes #1283. RED test `TestServerSourceHasNoCachedRWCalls` goes from
failing (13 writer call-sites) to GREEN (zero). Per #1287 Option 4
(https://github.com/Kpa-clawbot/CoreScope/issues/1287#issuecomment-4485099992):
ingestor owns the neighbor graph build + persist; server reads the
snapshot.
**Category A — Schema migrations** → new `internal/dbschema` package.
`dbschema.Apply(rw)` runs in `cmd/ingestor` startup (in `OpenStore`).
`dbschema.AssertReady(ro)` runs in `cmd/server/main.go` and
FATAL-LOG-EXITS if any expected column/index/table is missing — the
operator must restart the ingestor first. Covers indexes,
`neighbor_edges`, `observations.resolved_path`,
`observers.{inactive,last_packet_at,iata}`,
`(inactive_)nodes.foreign_advert`, `transmissions.from_pubkey`.
**Category B — Backfill** → ingestor.
`BackfillFromPubkey` and observer-blacklist soft-delete moved to
`cmd/ingestor/maintenance.go`. Server keeps an inert
`fromPubkeyBackfillSnapshot` stub for `/api/healthz` API compatibility.
**Category C — Neighbor-graph persistence (Option 4)** → ingestor
writes, server reads.
- Ingestor (`cmd/ingestor/neighbor_builder.go`): every 60s scans
`observations + transmissions`, extracts edges (originator↔first-hop for
ADVERTs; observer↔last-hop for all), resolves hop prefixes via a
node-table prefix index, upserts into `neighbor_edges`.
- Server (`cmd/server/neighbor_recomputer.go`): every 60s re-reads
`neighbor_edges` and atomic-swaps the resulting `NeighborGraph` into
`s.graph`. Initial load is synchronous on startup. All server-side
incremental edge writers (the two `asyncPersistResolvedPathsAndEdges`
paths in `cmd/server/store.go`) are gone.
- Neighbor-edge daily prune (`PruneNeighborEdges`) moved to ingestor.
**Why Option 4**: clean read/write separation, no startup CPU spike
(server loads existing snapshot instead of rebuilding from history), no
IPC/delta-protocol churn. Staleness budget ~60s — same model as the
analytics recomputers in #1240 / #1248 / #672 axis 2.
**Recomputer interval default for neighbor graph**: 60s
(`NeighborGraphRecomputerDefaultInterval`,
`NeighborEdgesBuilderInterval`).
**Invariants added**:
- `TestServerSourceHasNoCachedRWCalls` (RED commit eae179b9): grep
enforces zero `cachedRW(`, `mode=rw`, or `sql.Open(_journal_mode=WAL…)`
in non-test `cmd/server/` sources.
- `TestServerStartupRequiresMigratedSchema`: server refuses to start
against an unmigrated DB.
- `TestNeighborGraphRecomputerLoadsSnapshot`: post-write snapshot is
picked up on the next refresh.
- `TestNeighborEdgesBuilderUpsertsFromObservations`: end-to-end pipeline
writes the expected edge.
`grep cachedRW cmd/server/*.go | grep -v _test.go` → 0 matches.
Fixes #1287.
---------
Co-authored-by: MeshCore Bot <bot@meshcore.local>
Co-authored-by: Kpa-clawbot <Kpa-clawbot@users.noreply.github.com>
Co-authored-by: corescope-bot <bot@corescope.local>
81 lines
1.8 KiB
Go
81 lines
1.8 KiB
Go
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
)
|
|
func TestHealthzNotReady(t *testing.T) {
|
|
// Ensure readiness is 0 (not ready)
|
|
readiness.Store(0)
|
|
defer readiness.Store(0)
|
|
|
|
srv := &Server{store: &PacketStore{}}
|
|
req := httptest.NewRequest("GET", "/api/healthz", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
srv.handleHealthz(w, req)
|
|
|
|
if w.Code != http.StatusServiceUnavailable {
|
|
t.Fatalf("expected 503, got %d", w.Code)
|
|
}
|
|
|
|
var resp map[string]interface{}
|
|
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
|
|
t.Fatalf("invalid JSON: %v", err)
|
|
}
|
|
if resp["ready"] != false {
|
|
t.Fatalf("expected ready=false, got %v", resp["ready"])
|
|
}
|
|
if resp["reason"] != "loading" {
|
|
t.Fatalf("expected reason=loading, got %v", resp["reason"])
|
|
}
|
|
}
|
|
|
|
func TestHealthzReady(t *testing.T) {
|
|
readiness.Store(1)
|
|
defer readiness.Store(0)
|
|
|
|
srv := &Server{store: &PacketStore{}}
|
|
req := httptest.NewRequest("GET", "/api/healthz", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
srv.handleHealthz(w, req)
|
|
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d", w.Code)
|
|
}
|
|
|
|
var resp map[string]interface{}
|
|
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
|
|
t.Fatalf("invalid JSON: %v", err)
|
|
}
|
|
if resp["ready"] != true {
|
|
t.Fatalf("expected ready=true, got %v", resp["ready"])
|
|
}
|
|
if _, ok := resp["loadedTx"]; !ok {
|
|
t.Fatal("missing loadedTx field")
|
|
}
|
|
if _, ok := resp["loadedObs"]; !ok {
|
|
t.Fatal("missing loadedObs field")
|
|
}
|
|
}
|
|
|
|
func TestHealthzAntiTautology(t *testing.T) {
|
|
// When readiness is 0, must NOT return 200
|
|
readiness.Store(0)
|
|
defer readiness.Store(0)
|
|
|
|
srv := &Server{store: &PacketStore{}}
|
|
req := httptest.NewRequest("GET", "/api/healthz", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
srv.handleHealthz(w, req)
|
|
|
|
if w.Code == http.StatusOK {
|
|
t.Fatal("anti-tautology: handler returned 200 when readiness=0; gating is broken")
|
|
}
|
|
}
|
|
|