From aa75ed3c12f97cd0965f9aeae1f9c64cb6b56e6e Mon Sep 17 00:00:00 2001 From: Stacy Olivas Date: Sun, 5 Apr 2026 20:11:49 -0700 Subject: [PATCH] fix: restore MaintenanceRunner patch targets in TestMaybeRunDbBackup ff7917e incorrectly changed all test patches from `scheduler.maintenance.run_db_backup` to `scheduler._run_db_backup`, and rewrote `_setup` to bypass the delegation architecture upstream uses. - Restore `_setup` to use `scheduler.maintenance.get_maint` side_effect - Restore all 6 tests to patch `scheduler.maintenance.run_db_backup` - Add `patch.object(scheduler.maintenance, "_get_current_time")` to `test_weekly_on_wrong_day_does_not_run` to prevent Monday flakiness in UTC CI environments (maintenance captures `_get_current_time` as a bound method, so patching only `scheduler.get_current_time` is not sufficient) --- tests/test_scheduler_logic.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/test_scheduler_logic.py b/tests/test_scheduler_logic.py index e2c526f..6d886a2 100644 --- a/tests/test_scheduler_logic.py +++ b/tests/test_scheduler_logic.py @@ -372,8 +372,9 @@ class TestMaybeRunDbBackup: fake_now.strftime = now.strftime fake_now.isocalendar.return_value = (2026, 11, 2) with patch.object(scheduler, "get_current_time", return_value=fake_now): - with patch.object(scheduler.maintenance, "run_db_backup") as mock_run: - scheduler._maybe_run_db_backup() + with patch.object(scheduler.maintenance, "_get_current_time", return_value=fake_now): + with patch.object(scheduler.maintenance, "run_db_backup") as mock_run: + scheduler._maybe_run_db_backup() mock_run.assert_not_called()