mirror of
https://github.com/agessaman/meshcore-bot.git
synced 2026-10-01 03:48:02 +00:00
Adam Gessaman
38b259156e
The ACK fix I wrote for the radio-lock work is now upstream and released (meshcore_py#108, v2.3.13). Before it, send_msg_with_retry reported ACKed DMs as failures: the ACK subscription was registered only after send_msg returned, so an ACK queued right behind MSG_SENT was dispatched with no listener, and each attempt accepted only its own ACK code, so a late ACK answering an earlier attempt was ignored. The bot logged "no ACK received after retries" and skipped the delivery bookkeeping for messages the recipient had in fact received. Pin 2.3.14, which also fixes send_cmd's destination-type handling. Two fixes from re-reading the merged radio-lock change: A region-scoped channel message now restores global flood even when set_flood_scope raises. The restore only ran in the finally around the send, so a set that raised left the device pinned to that region and every later send went out under it. Drop the __setattr__ left behind when _SerializedCommands became _serialize_command_frames; it sat after the function's return, unreachable, and still referenced the proxy's _commands slot.