mirror of
https://github.com/agessaman/meshcore-bot.git
synced 2026-11-04 11:57:16 +00:00
agessaman
efe074b151
A codex review of the branch found seven places where earlier refactor commits changed behavior. Each is restored here with a test: - base_service imported flood_scope relatively; the local-service loader also runs that file as local_services.base_service, where the import cannot resolve. Now absolute. - Radio-health fields were initialized after commands and services were built, so a plugin constructor reading is_radio_offline raised. They are now set before any plugin. - Removing the per-command can_execute overrides made 31 commands honor skip_channel_check, which their overrides had dropped. BaseCommand.honors_skip_channel_check (False on exactly those commands) keeps them enforcing their channel list. - CommandManager.get_plugin_metadata, WxCommand.get_weather_for_zipcode and PluginLoader.validate_plugin were public compatibility entry points; they are back. - feed_manager stopped exporting DEFAULT_MAX_FEED_RESPONSE_BYTES and DEFAULT_MAX_PARSED_FEED_ITEMS despite the commit saying it re-exported them; it does now. - wx and gwx logged companion-location lookup failures at WARNING; the shared helper logged at debug. It now takes the level. - The INFO 'MESSAGE ROUTING' / 'DIRECT MESSAGE' lines for pubkey-correlated DMs were removed with the dead path_info computation; they are logged again by a log-only helper.
83 lines
2.7 KiB
Python
83 lines
2.7 KiB
Python
"""BaseCommand.enabled_attr: the per-command enable switch checked by can_execute."""
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
from modules.commands.base_command import BaseCommand
|
|
from modules.models import MeshMessage
|
|
|
|
|
|
class _Switchable(BaseCommand):
|
|
name = "switchable"
|
|
enabled_attr = "switchable_enabled"
|
|
keywords = ["switchable"]
|
|
|
|
def __init__(self, bot, enabled):
|
|
super().__init__(bot)
|
|
self.switchable_enabled = enabled
|
|
|
|
async def execute(self, message): # pragma: no cover - not exercised
|
|
return True
|
|
|
|
|
|
def _bot():
|
|
bot = MagicMock()
|
|
bot.config.has_section.return_value = False
|
|
bot.config.has_option.return_value = False
|
|
return bot
|
|
|
|
|
|
def _dm():
|
|
return MeshMessage(content="switchable", sender_id="Ann", is_dm=True)
|
|
|
|
|
|
def test_disabled_switch_refuses_before_other_checks():
|
|
cmd = _Switchable(_bot(), enabled=False)
|
|
assert cmd.can_execute(_dm()) is False
|
|
assert cmd.can_execute(_dm(), skip_channel_check=True) is False
|
|
|
|
|
|
def test_enabled_switch_falls_through_to_base_checks():
|
|
cmd = _Switchable(_bot(), enabled=True)
|
|
assert cmd.can_execute(_dm()) is True
|
|
cmd.requires_dm = True
|
|
assert cmd.can_execute(MeshMessage(content="switchable", sender_id="Ann", channel="x", is_dm=False)) is False
|
|
|
|
|
|
def test_switch_is_read_at_call_time():
|
|
cmd = _Switchable(_bot(), enabled=True)
|
|
cmd.switchable_enabled = False
|
|
assert cmd.can_execute(_dm()) is False
|
|
|
|
|
|
def test_admin_only_requires_admin_without_acl_config():
|
|
class _Admin(BaseCommand):
|
|
name = "adminonly"
|
|
admin_only = True
|
|
|
|
async def execute(self, message): # pragma: no cover - not exercised
|
|
return True
|
|
|
|
cmd = _Admin(_bot())
|
|
assert cmd.requires_admin_access() is True
|
|
assert _Switchable(_bot(), enabled=True).requires_admin_access() is False
|
|
|
|
|
|
def test_legacy_commands_still_enforce_channels_when_asked_to_skip():
|
|
"""Commands whose old override dropped skip_channel_check keep doing so."""
|
|
from modules.commands.ping_command import PingCommand
|
|
from modules.commands.version_command import VersionCommand
|
|
|
|
assert PingCommand.honors_skip_channel_check is False
|
|
assert VersionCommand.honors_skip_channel_check is True
|
|
|
|
class _Legacy(_Switchable):
|
|
honors_skip_channel_check = False
|
|
|
|
cmd = _Legacy(_bot(), enabled=True)
|
|
cmd.allowed_channels = ["allowed"]
|
|
blocked = MeshMessage(content="switchable", sender_id="Ann", channel="blocked", is_dm=False)
|
|
assert cmd.can_execute(blocked, skip_channel_check=True) is False
|
|
modern = _Switchable(_bot(), enabled=True)
|
|
modern.allowed_channels = ["allowed"]
|
|
assert modern.can_execute(blocked, skip_channel_check=True) is True
|