mirror of
https://github.com/agessaman/meshcore-bot.git
synced 2026-09-12 10:55:35 +00:00
Verifying a channel message against the RF cache only ever checked the row strategy 4 returned — the most recent packet heard. That assumes the RF log row and the decoded CHAN event for one reception arrive back to back with nothing in between. On a dense mesh they do not: a repeater's echo of the very same packet is routinely logged in the gap. The reporter's message was heard directly (SNR 13.25, 0 hops) and again via repeater f0 185 ms later (SNR 12.0, 1 hop). Both rows carry packet hash 392926C85DCB87D0, but the check saw only the echo, disagreed on path length and SNR, and left the route unresolved — so the bot withheld a path it had decoded correctly and answered "No path information available in current message". The reporter's own observation that MultiTest still reported paths is the tell: multitest reads recent_rf_data directly and never consults the match tag, so the radio data was there the whole time. The cache is now searched for the row the payload matches rather than testing just the newest one. #80's guarantee is unchanged — a route is still only ever attributed on a positive match, never on recency — so this widens where the check looks, not what it accepts. When more than one row matches they must resolve to a single non-empty packet hash, which is only true of receptions of one packet; two unrelated packets that happen to agree on all three fields stay a fallback. A debug line now names the case where the newest row was not the message's packet, so this failure mode is visible in logs rather than silent. Side effect worth knowing: SNR and RSSI now come from the message's own reception too. The reporter's message was logged at SNR 12.0 / RSSI -10, the echo's figures, when its actual reception was 13.25 / -32. Five tests cover it, including a reproduction built from the issue's log. Three fail on the current code; the other two pin behaviour the fix must not break — newest-wins among receptions of one packet, and scope_eligible_only still filtering the search so the scope correlation cannot be handed an ineligible row.
MeshCore Bot Test Suite
This directory contains the test suite for the MeshCore Bot, focusing on graph-based path guessing functionality.
Structure
tests/
├── README.md # This file
├── conftest.py # Pytest fixtures and configuration
├── helpers.py # Test data factories and helper functions
├── unit/ # Unit tests (isolated, with mocks)
│ ├── test_mesh_graph_edges.py
│ ├── test_mesh_graph_validation.py
│ ├── test_mesh_graph_scoring.py
│ ├── test_mesh_graph_multihop.py
│ └── test_path_command_graph_selection.py
└── integration/ # Integration tests (with real database)
└── test_path_resolution.py
Running Tests
Run all tests
pytest
Run only unit tests
pytest tests/unit/
Run only integration tests
pytest tests/integration/
Run specific test file
pytest tests/unit/test_mesh_graph_edges.py
Run specific test
pytest tests/unit/test_mesh_graph_edges.py::TestMeshGraphEdges::test_add_new_edge
Run with coverage
pytest --cov=modules --cov-report=html --cov-report=term-missing
Run with verbose output
pytest -v
Run with markers
pytest -m unit # Run only unit tests
pytest -m integration # Run only integration tests
pytest -m slow # Run slow tests
Test Coverage
Unit Tests
test_mesh_graph_edges.py (15 tests)
Tests for MeshGraph edge management:
- Adding new edges
- Updating existing edges
- Public key handling
- Hop position tracking
- Geographic distance
- Edge queries (get, has, outgoing, incoming)
- Prefix normalization
test_mesh_graph_validation.py (12 tests)
Tests for path validation:
- Path segment validation
- Confidence calculation
- Recency checks
- Bidirectional edge validation
- Full path validation
- Minimum observations filtering
test_mesh_graph_scoring.py (11 tests)
Tests for candidate scoring:
- Score calculation with various edge combinations
- Bidirectional bonuses
- Hop position matching
- Geographic distance bonuses
- Minimum observations filtering
test_mesh_graph_multihop.py (12 tests)
Tests for multi-hop path inference:
- 2-hop and 3-hop path finding
- Intermediate node discovery
- Minimum observations filtering
- Bidirectional path bonuses
- Score reduction for longer paths
test_path_command_graph_selection.py (8 tests)
Tests for PathCommand._select_repeater_by_graph:
- Direct edge selection
- Stored public key bonus
- Star bias multiplier
- Multi-hop inference
- Confidence conversion
Integration Tests
test_path_resolution.py (5 tests)
End-to-end tests for full path resolution:
- Path resolution with graph edges from database
- Prefix collision resolution using graph data
- Edge persistence across graph restarts
- Graph vs geographic selection
- Real-world multi-hop scenarios
Test Fixtures
Fixtures are defined in conftest.py:
mock_logger: Mock logger for testingtest_config: Test configuration with Path_Command settingstest_db: In-memory SQLite database for testingmock_bot: Mock bot instance with all necessary attributesmesh_graph: CleanMeshGraphinstance for testingpopulated_mesh_graph:MeshGraphinstance with sample edges
Test Helpers
Helper functions in helpers.py:
create_test_repeater(): Factory for creating test repeater datacreate_test_edge(): Factory for creating test edge datacreate_test_path(): Factory for creating test path datapopulate_test_graph(): Helper to populate a graph with test edges
Writing New Tests
Unit Test Example
import pytest
from tests.helpers import create_test_edge
@pytest.mark.unit
class TestMyFeature:
def test_my_feature(self, mesh_graph):
"""Test description."""
mesh_graph.add_edge('01', '7e')
assert mesh_graph.has_edge('01', '7e')
Integration Test Example
import pytest
@pytest.mark.integration
class TestMyIntegration:
def test_my_integration(self, mock_bot, test_db):
"""Test description."""
# Use real database and bot components
pass
Test Markers
Tests are marked with:
@pytest.mark.unit: Unit tests (isolated, with mocks)@pytest.mark.integration: Integration tests (with real database)@pytest.mark.slow: Slow-running tests
Dependencies
Test dependencies are in requirements.txt:
pytest>=7.0.0pytest-asyncio>=0.21.0pytest-mock>=3.10.0pytest-cov>=4.0.0
Configuration
Pytest configuration is in pytest.ini:
- Test discovery patterns
- Async test support
- Output options
- Test markers
Notes
- Unit tests use in-memory SQLite databases for speed
- Integration tests may use real database connections
- All tests should be deterministic and not depend on external services
- Tests should clean up after themselves (fixtures handle this automatically)