Files
meshcore-bot/.github/workflows/test.yml
T
agessaman 5f97cff8d7 ci: install the geo extra so location tests match a real install
Tests (all four Python versions) failed on
test_over_budget_same_state_omits_prefix while passing locally. Root
cause: CI installed only ".[test]", leaving out the optional geo extra
(us, pycountry). normalize_us_state() returns (None, None) when `us` is
absent, so "Washington" no longer normalizes to "WA" and the AQI
prefix-budget path wrongly concluded the resolved state differed from
default_state, keeping the "Seattle, WA: " prefix.

Install ".[test,geo]" in both the test matrix and the mypy job. This
also un-skips ~27 geo-dependent tests that were silently skipping in CI
and which pass with the extra present.

Also ignore _debug/, a local scratch directory for captured configs and
logs that should never be committed.
2026-07-22 14:55:58 -07:00

162 lines
4.3 KiB
YAML

name: Tests
on:
push:
branches:
- main
- master
- dev
pull_request:
branches:
- main
- master
- dev
workflow_dispatch:
jobs:
lint-frontend:
name: Lint Frontend (HTMLHint + ESLint)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: "20"
cache: npm
- name: Install frontend lint tools
run: npm ci
- name: HTMLHint — lint HTML templates
run: npm run lint:html
- name: ESLint — lint inline JavaScript
run: npm run lint:js
lint-shell:
name: Lint Shell Scripts (ShellCheck)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install ShellCheck
run: sudo apt-get install -y shellcheck
- name: ShellCheck — lint all .sh files
run: |
find . -name "*.sh" \
-not -path "./.git/*" \
-not -path "./node_modules/*" \
-not -path "./.venv/*" \
-not -path "./venv/*" \
-not -path "./dist/*" \
-print0 | xargs -0 shellcheck --severity=warning
lint:
name: Lint (ruff)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.11"
cache: pip
- name: Install ruff
run: pip install "ruff==0.15.15"
- name: ruff check — fail on any lint error
run: ruff check modules/ tests/
- name: Log injection check — fail on new unsanitized logger calls
run: python scripts/check_log_injection.py
- name: Config validation — fail on unrecognized sections in shipped configs
run: |
set -e
for f in config.ini.example config.ini.minimal-example config.ini.quickstart config.min.ini config-pymc.ini; do
if [ -f "$f" ]; then
echo "Validating $f"
python validate_config.py --config "$f" --strict
fi
done
typecheck:
name: Type check (mypy)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.11"
cache: pip
- name: Install dependencies
run: |
pip install --upgrade pip
pip install -e ".[test,geo]"
pip install mypy
- name: mypy — strict overrides on typed modules
run: mypy modules/ --ignore-missing-imports
package:
name: Build and smoke-test distributions
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.11"
cache: pip
- name: Build wheel and source distribution
run: |
python -m pip install --upgrade pip build twine
python -m build
python -m twine check dist/*
- name: Install and smoke-test wheel outside the source tree
run: |
python -m venv /tmp/meshcore-wheel-smoke
/tmp/meshcore-wheel-smoke/bin/pip install dist/*.whl
cd /tmp
/tmp/meshcore-wheel-smoke/bin/python "$GITHUB_WORKSPACE/scripts/smoke_test_wheel.py"
/tmp/meshcore-wheel-smoke/bin/meshcore-bot --help >/dev/null
/tmp/meshcore-wheel-smoke/bin/meshcore-viewer --help >/dev/null
test:
name: Tests (Python ${{ matrix.python-version }})
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13"]
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: pip
- name: Install dependencies
run: |
pip install --upgrade pip
# `geo` (us, pycountry) is optional at runtime but drives US state and
# country normalization; without it ~27 location tests skip and the AQI
# prefix-budget behavior silently differs from a real install.
pip install -e ".[test,geo]"
- name: Run tests with coverage
run: pytest tests/ -v --tb=short