mirror of
https://github.com/agessaman/meshcore-bot.git
synced 2026-10-23 14:22:22 +00:00
Correctness:
- {path_distance} was always blank in production. The resolution code that
builds repeater_info dropped latitude/longitude in every branch, so the
calculator could never find a coordinate. My tests passed hand-built
dicts straight to the calculator and never exercised the builder, which
is why they stayed green. Coordinates are now carried through all four
construction sites, and the new tests drive _lookup_repeater_names via
its lookup_func hook so the real builder runs.
- The #80 route guard was defeated two ways in the channel handler. When
the RF data was an uncorrelated fallback, control fell through to the
raw-hex and routing_info fallbacks below, which took the route from the
unrelated packet anyway; the guard had actually made that path
reachable. message.routing_info was also assigned unconditionally, and
the path command reads it. "Not attributable" is now a terminal branch
and the routing_info hand-off checks provenance.
- Same fix was incomplete for DMs: routing_info was captured and turned
into path_info before the provenance check ran, so the later check only
declined to overwrite an already-wrong value. Guarded at the source.
- Rendering could transmit for real. Capture only intercepts
send_response, but advert calls send_advert() directly and
send_response_chunked never checked capture_sink. Chunked sends are now
captured, and rendering is opt-in via BaseCommand.render_safe (default
False) instead of a denylist that cannot be complete. This also closes
the DM-only leak: schedule is not marked safe, so {cmd:schedule} can no
longer broadcast configuration to a channel.
- Multi-part rendered output was rejoined into one oversized send.
Scheduled messages are now split to the RF body budget and sent through
send_channel_messages_chunked, on character boundaries so multi-byte
text is not corrupted.
- _last_path_distance_km is instance state that was only set on success,
so an invalid path request could show the previous request's distance.
Reset at the start of every execute().
- Stale-contact retries were only counted on non-OK results, so timeouts
and exceptions left a contact eligible forever and could recreate the
storm. All failed attempts count now.
Web viewer:
- A failed config reload was reported as a successful save. The API and
UI now distinguish "saved and active" from "saved, restart needed".
- Preview count was unbounded; clamped to 1-20.
- update_ini_values is a read-modify-replace with no locking, so two
concurrent viewer saves could lose one. Serialised behind a lock.
MeshCore Bot Test Suite
This directory contains the test suite for the MeshCore Bot, focusing on graph-based path guessing functionality.
Structure
tests/
├── README.md # This file
├── conftest.py # Pytest fixtures and configuration
├── helpers.py # Test data factories and helper functions
├── unit/ # Unit tests (isolated, with mocks)
│ ├── test_mesh_graph_edges.py
│ ├── test_mesh_graph_validation.py
│ ├── test_mesh_graph_scoring.py
│ ├── test_mesh_graph_multihop.py
│ └── test_path_command_graph_selection.py
└── integration/ # Integration tests (with real database)
└── test_path_resolution.py
Running Tests
Run all tests
pytest
Run only unit tests
pytest tests/unit/
Run only integration tests
pytest tests/integration/
Run specific test file
pytest tests/unit/test_mesh_graph_edges.py
Run specific test
pytest tests/unit/test_mesh_graph_edges.py::TestMeshGraphEdges::test_add_new_edge
Run with coverage
pytest --cov=modules --cov-report=html --cov-report=term-missing
Run with verbose output
pytest -v
Run with markers
pytest -m unit # Run only unit tests
pytest -m integration # Run only integration tests
pytest -m slow # Run slow tests
Test Coverage
Unit Tests
test_mesh_graph_edges.py (15 tests)
Tests for MeshGraph edge management:
- Adding new edges
- Updating existing edges
- Public key handling
- Hop position tracking
- Geographic distance
- Edge queries (get, has, outgoing, incoming)
- Prefix normalization
test_mesh_graph_validation.py (12 tests)
Tests for path validation:
- Path segment validation
- Confidence calculation
- Recency checks
- Bidirectional edge validation
- Full path validation
- Minimum observations filtering
test_mesh_graph_scoring.py (11 tests)
Tests for candidate scoring:
- Score calculation with various edge combinations
- Bidirectional bonuses
- Hop position matching
- Geographic distance bonuses
- Minimum observations filtering
test_mesh_graph_multihop.py (12 tests)
Tests for multi-hop path inference:
- 2-hop and 3-hop path finding
- Intermediate node discovery
- Minimum observations filtering
- Bidirectional path bonuses
- Score reduction for longer paths
test_path_command_graph_selection.py (8 tests)
Tests for PathCommand._select_repeater_by_graph:
- Direct edge selection
- Stored public key bonus
- Star bias multiplier
- Multi-hop inference
- Confidence conversion
Integration Tests
test_path_resolution.py (5 tests)
End-to-end tests for full path resolution:
- Path resolution with graph edges from database
- Prefix collision resolution using graph data
- Edge persistence across graph restarts
- Graph vs geographic selection
- Real-world multi-hop scenarios
Test Fixtures
Fixtures are defined in conftest.py:
mock_logger: Mock logger for testingtest_config: Test configuration with Path_Command settingstest_db: In-memory SQLite database for testingmock_bot: Mock bot instance with all necessary attributesmesh_graph: CleanMeshGraphinstance for testingpopulated_mesh_graph:MeshGraphinstance with sample edges
Test Helpers
Helper functions in helpers.py:
create_test_repeater(): Factory for creating test repeater datacreate_test_edge(): Factory for creating test edge datacreate_test_path(): Factory for creating test path datapopulate_test_graph(): Helper to populate a graph with test edges
Writing New Tests
Unit Test Example
import pytest
from tests.helpers import create_test_edge
@pytest.mark.unit
class TestMyFeature:
def test_my_feature(self, mesh_graph):
"""Test description."""
mesh_graph.add_edge('01', '7e')
assert mesh_graph.has_edge('01', '7e')
Integration Test Example
import pytest
@pytest.mark.integration
class TestMyIntegration:
def test_my_integration(self, mock_bot, test_db):
"""Test description."""
# Use real database and bot components
pass
Test Markers
Tests are marked with:
@pytest.mark.unit: Unit tests (isolated, with mocks)@pytest.mark.integration: Integration tests (with real database)@pytest.mark.slow: Slow-running tests
Dependencies
Test dependencies are in requirements.txt:
pytest>=7.0.0pytest-asyncio>=0.21.0pytest-mock>=3.10.0pytest-cov>=4.0.0
Configuration
Pytest configuration is in pytest.ini:
- Test discovery patterns
- Async test support
- Output options
- Test markers
Notes
- Unit tests use in-memory SQLite databases for speed
- Integration tests may use real database connections
- All tests should be deterministic and not depend on external services
- Tests should clean up after themselves (fixtures handle this automatically)