mirror of
https://github.com/threefoldtech/mycelium.git
synced 2026-06-07 00:01:40 +00:00
ae01592043
This fixes an issue where a selected route with infinite metric was considered lost every time an update for that subnet came in, potentially causing an update storm. Signed-off-by: Lee Smet <lee.smet@hotmail.com>
150 lines
4.5 KiB
Rust
150 lines
4.5 KiB
Rust
use core::fmt;
|
|
use std::{collections::HashMap, time::Duration};
|
|
|
|
use log::error;
|
|
use tokio::{sync::mpsc, task::JoinHandle};
|
|
|
|
use crate::{
|
|
babel, metric::Metric, router_id::RouterId, routing_table::RouteEntry, sequence_number::SeqNo,
|
|
subnet::Subnet,
|
|
};
|
|
|
|
/// Duration after which a source entry is deleted if it is not updated.
|
|
const SOURCE_HOLD_DURATION: Duration = Duration::from_secs(60 * 5);
|
|
|
|
#[derive(Debug, Clone, PartialEq, Eq, Hash, Copy)]
|
|
pub struct SourceKey {
|
|
subnet: Subnet,
|
|
router_id: RouterId,
|
|
}
|
|
|
|
#[derive(Debug, Clone, Copy)]
|
|
pub struct FeasibilityDistance {
|
|
metric: Metric,
|
|
seqno: SeqNo,
|
|
}
|
|
|
|
#[derive(Debug)]
|
|
pub struct SourceTable {
|
|
table: HashMap<SourceKey, (JoinHandle<()>, FeasibilityDistance)>,
|
|
}
|
|
|
|
impl FeasibilityDistance {
|
|
pub fn new(metric: Metric, seqno: SeqNo) -> Self {
|
|
FeasibilityDistance { metric, seqno }
|
|
}
|
|
|
|
/// Returns the metric for this `FeasibilityDistance`.
|
|
pub const fn metric(&self) -> Metric {
|
|
self.metric
|
|
}
|
|
|
|
/// Returns the sequence number for this `FeasibilityDistance`.
|
|
pub const fn seqno(&self) -> SeqNo {
|
|
self.seqno
|
|
}
|
|
}
|
|
|
|
impl SourceKey {
|
|
/// Create a new `SourceKey`.
|
|
pub const fn new(subnet: Subnet, router_id: RouterId) -> Self {
|
|
Self { subnet, router_id }
|
|
}
|
|
|
|
/// Returns the [`RouterId`] for this `SourceKey`.
|
|
pub const fn router_id(&self) -> RouterId {
|
|
self.router_id
|
|
}
|
|
|
|
/// Returns the [`Subnet`] for this `SourceKey`.
|
|
pub const fn subnet(&self) -> Subnet {
|
|
self.subnet
|
|
}
|
|
|
|
/// Updates the [`RouterId`] of this `SourceKey`
|
|
pub fn set_router_id(&mut self, router_id: RouterId) {
|
|
self.router_id = router_id
|
|
}
|
|
}
|
|
|
|
impl SourceTable {
|
|
pub fn new() -> Self {
|
|
Self {
|
|
table: HashMap::new(),
|
|
}
|
|
}
|
|
|
|
pub fn insert(
|
|
&mut self,
|
|
key: SourceKey,
|
|
feas_dist: FeasibilityDistance,
|
|
sink: mpsc::Sender<SourceKey>,
|
|
) {
|
|
let expiration_handle = tokio::spawn(async move {
|
|
tokio::time::sleep(SOURCE_HOLD_DURATION).await;
|
|
|
|
if let Err(e) = sink.send(key).await {
|
|
error!("Failed to notify router of expired source key {e}");
|
|
}
|
|
});
|
|
// Abort the old task if present.
|
|
if let Some((old_timeout, _)) = self.table.insert(key, (expiration_handle, feas_dist)) {
|
|
old_timeout.abort();
|
|
}
|
|
}
|
|
|
|
/// Remove an entry from the source table.
|
|
pub fn remove(&mut self, key: &SourceKey) {
|
|
if let Some((old_timeout, _)) = self.table.remove(key) {
|
|
old_timeout.abort();
|
|
};
|
|
}
|
|
|
|
/// Get the [`FeasibilityDistance`] currently associated with the [`SourceKey`].
|
|
pub fn get(&self, key: &SourceKey) -> Option<&FeasibilityDistance> {
|
|
self.table.get(key).map(|(_, v)| v)
|
|
}
|
|
|
|
/// Indicates if an update is feasible in the context of the current `SoureTable`.
|
|
pub fn is_update_feasible(&self, update: &babel::Update) -> bool {
|
|
// Before an update is accepted it should be checked against the feasbility condition
|
|
// If an entry in the source table with the same source key exists, we perform the feasbility check
|
|
// If no entry exists yet, the update is accepted as there is no better alternative available (yet)
|
|
let source_key = SourceKey::new(update.subnet(), update.router_id());
|
|
match self.get(&source_key) {
|
|
Some(entry) => {
|
|
(update.seqno().gt(&entry.seqno()))
|
|
|| (update.seqno() == entry.seqno() && update.metric() < entry.metric())
|
|
|| update.metric().is_infinite()
|
|
}
|
|
None => true,
|
|
}
|
|
}
|
|
|
|
/// Indicates if a [`RouteEntry`] is feasible according to the `SourceTable`.
|
|
pub fn route_feasible(&self, route: &RouteEntry) -> bool {
|
|
match self.get(&route.source()) {
|
|
Some(fd) => {
|
|
(route.seqno().gt(&fd.seqno))
|
|
|| (route.seqno() == fd.seqno && route.metric() < fd.metric)
|
|
|| route.metric().is_infinite()
|
|
}
|
|
None => true,
|
|
}
|
|
}
|
|
|
|
/// Get an iterator over the `SourceTable`.
|
|
pub fn iter(&self) -> impl Iterator<Item = (&SourceKey, &FeasibilityDistance)> {
|
|
self.table.iter().map(|(k, (_, v))| (k, v))
|
|
}
|
|
}
|
|
|
|
impl fmt::Display for SourceKey {
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
|
f.write_fmt(format_args!(
|
|
"{} advertised by {}",
|
|
self.subnet, self.router_id
|
|
))
|
|
}
|
|
}
|